On 23/10/06, Max Rydahl Andersen <max.andersen(a)jboss.com&gt; wrote: > > I've started some minor patches today, but was wondering if anyone > > would be offended if I reformatted the hbm2doc templates? The > > inconsistent indentation makes patching them rather hard going. > > feel free. > > I plan to apply your current patches tomorrow. Cool. I've reformatted locally with the patches included, so I'll wait until you apply the others before submitting any more to avoid conflict-hell. Mark _______________________________________________ hibernate-dev mailing list hibernate-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev

On 24/10/06, Max Rydahl Andersen <max.andersen(a)jboss.com&gt; wrote: > I've applied your current patches now. thanks. Thanks Max. If you could be so kind to apply the new reformatted templates (HBX-789) then I can base my next batch of patches from that. Mark

> I tried to verify our generated html with jtidy, but it reports too > many "false alarms" (e.g. usage of % in td/th width). > > Anyone knows of a better verifier that can be used programmatically in > unittests ? The w3c validators are normally the best bet, but they tend to be online tools rather than programmatic ones. They are open-source though, so it may be possible to integrate into unit tests.

Regarding the jtidy warnings, they are normally fair points...

... and can be fixed by moving to clean XHTML and CSS. I was contemplating the work involved when reformatting the templates, and it wouldn't be too hard. It'd be nice to move away from HTML4 and fully utilise CSS, but I wasn't sure what your minimum requirements are.

> Any HTML/CSS that looks good on IE, FireFox and Opera (and are simple to > generate) is my minimum requirements ;) Cool, well if I get the time after adding the features I need then I'll have a stab.