On 25 Feb 2010, at 08:36, Galder Zamarreno wrote:
On Wed, 24 Feb 2010 14:07:25 +0100, Manik Surtani
<manik(a)jboss.org> wrote:
> Galder
>
> I notice you have a memcached.sh script to start the memcached server.
> I believe this should be something like startServer.sh, given that we
> are not actually starting memcached? ;)
Hmmm, depends how you look at it. You could say that we're starting
Infinispan implementation of memcached, which is memcached still ;)
Negative; memcached has very different characteristics from Infinispan. It's just the
protocol that we're mimicking.
> And perhaps the script could be reused for HotRod as well ...
passing in
> a flag to specify which protocol to speak, perhaps something like:
>
> $ startServer.sh -p memcached
>
> or
>
> $ startServer.sh -p hotrod
>
> Perhaps org.infinispan.server.memcached.Main could be in the server/core
> module instead, and based on the protocol flag passed in, kick start the
> appropriate server? WDYT?
I'm easy with either option. Having a single startServer.sh script fro
both servers makes it easy to maintain since there's a single script
rather than 2.
I'll create a JIRA for this.
https://jira.jboss.org/jira/browse/ISPN-353
> Also, how do you handle graceful shutdown of the server? Do you
need to
> do something like listen on a separate, shutdown port (accepting local
> connections only) for a shutdown signal?
Shutdown is currently handled via a shutdown hook. For remote shutdown,
listening on a shutdown port might make sense, or the protocol port could
maybe be reused. I'd probably favour the 2nd to reduce the number of ports
to maintain.
No, remote shutdown is a bad idea (security hole). Shutdown hook works fine.
Note that I didn't see anything in memcached protocol wrt to this.
>
> Cheers
> Manik
> --
> Manik Surtani
> manik(a)jboss.org
> Lead, Infinispan
> Lead, JBoss Cache
>
http://www.infinispan.org
>
http://www.jbosscache.org
>
>
>
>
>
> _______________________________________________
> infinispan-dev mailing list
> infinispan-dev(a)lists.jboss.org
>
https://lists.jboss.org/mailman/listinfo/infinispan-dev
--
Galder ZamarreƱo
Sr. Software Engineer
Infinispan, JBoss Cache
_______________________________________________
infinispan-dev mailing list
infinispan-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/infinispan-dev
--
Manik Surtani
manik(a)jboss.org
Lead, Infinispan
Lead, JBoss Cache
http://www.infinispan.org
http://www.jbosscache.org