Re: [infinispan-dev] DeadlockDetection (DLD) - benchmarks and status

Manik Surtani wrote: > BTW I just thought of something (implementation detail): you have a > new LockManager impl here, right? > DeadlockDetectingLockManagerImpl? The default LockManagerImpl > exposes stuff via JMX (and JOPR) using annotations on the impl > class. Can we move these annotations onto the LockManager > interface so that we don't need to repeat this for any arbitrary > interface? Should test that these annotations are still picked up > even if they are on the interface. Not sure if this is the case. > > Cheers > Manik Well, even if we would have this annotations on the interface, the different implementations would still need to take care of implementing them, and hence the advantage would be in not repeating the annotation itself only. DeadlockDetectingLockManager is inheriting from LockMnagerImpl and hence the problem is already solved for current setup.