Re: [infinispan-dev] Question about Hibernate ORM 5.0 + Infinispan 8.0...

Good point. It works now (the issue is fixed) but we need to monitor both projects. I'll see how far that can be automated. Can I have ci spam you in case of failures? On Thu, 30 Jul 2015 15:34 Scott Marlow <smarlow(a)redhat.com <mailto:smarlow@redhat.com>> wrote: Thanks Sanne, this is a big help! IMO, we should run the Hibernate 5.0 testsuite again with Infinispan 8.x/master before releasing Infinispan 8.0.0.Final. Scott On 07/29/2015 07:24 PM, Sanne Grinovero wrote: > I'm fixing the ORM testsuite so that we can run it on both versions as > https://hibernate.atlassian.net/browse/HHH-10001 > > Looks promising: > After working around the testsuite problem I'm down to two errors - > which seem more likely related to my changes than the Infinispan > version change - but will need some sleep before debugging those ;) > > Sanne > > On 29 July 2015 at 23:09, Sanne Grinovero <sanne(a)infinispan.org <mailto:sanne@infinispan.org>> wrote: >> On 29 July 2015 at 22:08, Sanne Grinovero <sanne(a)infinispan.org <mailto:sanne@infinispan.org>> wrote: >>> On 29 July 2015 at 21:58, Scott Marlow <smarlow(a)redhat.com <mailto:smarlow@redhat.com>> wrote: >>>> With Paul's HHH-9999 fix, we can now compile and pass the ORM tests with >>>> Infinispan 7.3.x. We can also compile Hibernate 5.0 against Infinispan >>>> 8.0.0.Beta2 but get ORM test failures http://pastebin.com/T2Yt3gdn >>> >>> Let me guess.. you expect Infinispan 8 to parse configuration files >>> meant for Infinispan 7? >> >> I was wrong, the problem is caused by this commit, which makes >> Infinispan now very picky on not having used AbstractInfinispanTest as >> a base class: >> https://github.com/infinispan/infinispan/commit/c9dfb >> >> Hibernate uses the Infinispan core testing helpers, but doesn't use >> TestNG so I'm not sure what the best solution is here. >> Should we set the thread name consistently in all Hibernate tests too? >> Seems quite pointless, the tests aren't run in parallel either. >> >> Could the helper be made a bit more tolerant for other use cases? Or >> maybe I should add a system property to have it change behaviour? >> I'd prefer to set the system property for Infinispan's own use, and >> default to lenient so that other people can reuse the helpers w/o >> these contraints. >> >> Thanks, >> Sanne > _______________________________________________ > infinispan-dev mailing list > infinispan-dev(a)lists.jboss.org <mailto:infinispan-dev@lists.jboss.org> > https://lists.jboss.org/mailman/listinfo/infinispan-dev > _______________________________________________ infinispan-dev mailing list infinispan-dev(a)lists.jboss.org <mailto:infinispan-dev@lists.jboss.org> https://lists.jboss.org/mailman/listinfo/infinispan-dev _______________________________________________ infinispan-dev mailing list infinispan-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev