Hi, I heard that Infinispan 8.0 may soon be integrated into WildFly 10.0. If that happens, how does that impact Hibernate ORM 5.0 which currently integrates with Infinispan 7.2.1.Final? Does Hibernate ORM 5.0 need any changes to integrate with Infinispan 8.0? Thanks, Scott _______________________________________________ infinispan-dev mailing list infinispan-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev

Hi Radim, I suspect that Steve won't allow an Infinispan upgrade to 8 in a micro release of Hibernate.. that's against our conventions. The better plan would be to work towards a Hibernate 5.1 version for this, or make sure to talk with him in advance if that doesn't work out.

On 14 July 2015 at 16:16, Radim Vansa <rvansa(a)redhat.com&gt; wrote: > IIRC currently hibernate-infinispan module uses just the basic cache > API, which won't change. However, with certain consistency fixes ([1] > [2] and maybe more) the Interceptor API is used (as the basic > invalidation mode cannot make 2LC consistent on it own), which is about > to change in Infinispan 8.0. > I will take care of updating hibernate-infinispan module to 8.0 when it > will be out. Since that would require only changes internal to that > module, I hope this upgrade can be scoped to a micro-release. > > Radim > > [1] https://hibernate.atlassian.net/browse/HHH-9868 > [2] https://hibernate.atlassian.net/browse/HHH-9881 > > On 07/14/2015 02:34 PM, Scott Marlow wrote: >> Hi, >> >> I heard that Infinispan 8.0 may soon be integrated into WildFly 10.0. >> If that happens, how does that impact Hibernate ORM 5.0 which currently >> integrates with Infinispan 7.2.1.Final? Does Hibernate ORM 5.0 need any >> changes to integrate with Infinispan 8.0? >> >> Thanks, >> Scott >> _______________________________________________ >> infinispan-dev mailing list >> infinispan-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/infinispan-dev > > > -- > Radim Vansa <rvansa(a)redhat.com&gt; > JBoss Performance Team > > _______________________________________________ > infinispan-dev mailing list > infinispan-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/infinispan-dev _______________________________________________ infinispan-dev mailing list infinispan-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev

On 07/15/2015 03:25 PM, Scott Marlow wrote: > Looks like Hibernate 5.0 cannot be compiled against Infinispan 8.0.0.Beta1: > > " > hibernate-infinispan/src/main/java/org/hibernate/cache/infinispan/util/Caches.java:209: > error: cannot find symbol > rpcManager.broadcastRpcCommand( cmd, isSync ); > ^ > symbol: method broadcastRpcCommand(EvictAllCommand,boolean) > location: variable rpcManager of type RpcManager > " > > Will this be fixed in Hibernate ORM 5.0 or Infinispan 8.0.0.Beta2? This should be fixed in ORM 5.x, but should I do a PR that uses Infinispan 8.0.0.Beta1 as dependency, even though 8.0.0.Final won't get out before ORM 5.0.0.Final?

> > More inline below... > > On 07/14/2015 05:27 PM, Sanne Grinovero wrote: >> Hi Radim, I suspect that Steve won't allow an Infinispan upgrade to 8 >> in a micro release of Hibernate.. that's against our conventions. >> The better plan would be to work towards a Hibernate 5.1 version for >> this, or make sure to talk with him in advance if that doesn't work >> out. > The first beta of WildFly 10 is scheduled for August 6th, 2015. IMO, > with that target in mind, we should figure out if we can have a > Hibernate 5.x and Infinispan 8.x that work together. I don't > particularly care if the Hibernate ORM 5.0 release uses Infinispan 8.x, > as long as someone is making sure Infinispan 8.x and ORM 5.0, work well > together. IMO, we should either change the Infinispan 8 API to still > work with Hibernate ORM 5 or update ORM 5 to work with Infinispan 8. See above: I would 'make sure' that they work together, but it's IMO not possible until Infinispan 8.0 is released.

Radim > >> On 14 July 2015 at 16:16, Radim Vansa <rvansa(a)redhat.com&gt; wrote: >>> IIRC currently hibernate-infinispan module uses just the basic cache >>> API, which won't change. However, with certain consistency fixes ([1] >>> [2] and maybe more) the Interceptor API is used (as the basic >>> invalidation mode cannot make 2LC consistent on it own), which is about >>> to change in Infinispan 8.0. >>> I will take care of updating hibernate-infinispan module to 8.0 when it >>> will be out. Since that would require only changes internal to that >>> module, I hope this upgrade can be scoped to a micro-release. >>> >>> Radim >>> >>> [1] https://hibernate.atlassian.net/browse/HHH-9868 >>> [2] https://hibernate.atlassian.net/browse/HHH-9881 >>> >>> On 07/14/2015 02:34 PM, Scott Marlow wrote: >>>> Hi, >>>> >>>> I heard that Infinispan 8.0 may soon be integrated into WildFly 10.0. >>>> If that happens, how does that impact Hibernate ORM 5.0 which currently >>>> integrates with Infinispan 7.2.1.Final? Does Hibernate ORM 5.0 need any >>>> changes to integrate with Infinispan 8.0? >>>> >>>> Thanks, >>>> Scott >>>> _______________________________________________ >>>> infinispan-dev mailing list >>>> infinispan-dev(a)lists.jboss.org >>>> https://lists.jboss.org/mailman/listinfo/infinispan-dev >>> >>> -- >>> Radim Vansa <rvansa(a)redhat.com&gt; >>> JBoss Performance Team >>> >>> _______________________________________________ >>> infinispan-dev mailing list >>> infinispan-dev(a)lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/infinispan-dev >> _______________________________________________ >> infinispan-dev mailing list >> infinispan-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/infinispan-dev >> > _______________________________________________ > infinispan-dev mailing list > infinispan-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/infinispan-dev

On 07/15/2015 03:25 PM, Scott Marlow wrote: > Looks like Hibernate 5.0 cannot be compiled against Infinispan

> > " >

> error: cannot find symbol > rpcManager.broadcastRpcCommand( cmd,

> ^ > symbol: method broadcastRpcCommand(EvictAllCommand,boolean) > location: variable rpcManager of type RpcManager > " > > Will this be fixed in Hibernate ORM 5.0 or Infinispan 8.0.0.Beta2? This should be fixed in ORM 5.x, but should I do a PR that uses Infinispan 8.0.0.Beta1 as dependency, even though 8.0.0.Final

out before ORM 5.0.0.Final?

> > More inline below... > > On 07/14/2015 05:27 PM, Sanne Grinovero wrote: >> Hi Radim, I suspect that Steve won't allow an Infinispan

>> in a micro release of Hibernate.. that's against our conventions. >> The better plan would be to work towards a Hibernate 5.1

>> this, or make sure to talk with him in advance if that doesn't

>> out. > The first beta of WildFly 10 is scheduled for August 6th, 2015.

> with that target in mind, we should figure out if we can have a > Hibernate 5.x and Infinispan 8.x that work together. I don't > particularly care if the Hibernate ORM 5.0 release uses

> as long as someone is making sure Infinispan 8.x and ORM 5.0,

> together. IMO, we should either change the Infinispan 8 API to

> work with Hibernate ORM 5 or update ORM 5 to work with

See above: I would 'make sure' that they work together, but it's

possible until Infinispan 8.0 is released.

Radim > >> On 14 July 2015 at 16:16, Radim Vansa <rvansa(a)redhat.com

>>> IIRC currently hibernate-infinispan module uses just the basic

>>> API, which won't change. However, with certain consistency

>>> [2] and maybe more) the Interceptor API is used (as the basic >>> invalidation mode cannot make 2LC consistent on it own), which

>>> to change in Infinispan 8.0. >>> I will take care of updating hibernate-infinispan module to

>>> will be out. Since that would require only changes internal to

>>> module, I hope this upgrade can be scoped to a micro-release. >>> >>> Radim >>> >>> [1] https://hibernate.atlassian.net/browse/HHH-9868 >>> [2] https://hibernate.atlassian.net/browse/HHH-9881 >>> >>> On 07/14/2015 02:34 PM, Scott Marlow wrote: >>>> Hi, >>>> >>>> I heard that Infinispan 8.0 may soon be integrated into

>>>> If that happens, how does that impact Hibernate ORM 5.0 which

>>>> integrates with Infinispan 7.2.1.Final? Does Hibernate ORM

>>>> changes to integrate with Infinispan 8.0? >>>> >>>> Thanks, >>>> Scott >>>> _______________________________________________ >>>> infinispan-dev mailing list >>>> infinispan-dev(a)lists.jboss.org

>>>> https://lists.jboss.org/mailman/listinfo/infinispan-dev >>> >>> -- >>> Radim Vansa <rvansa(a)redhat.com <mailto:rvansa@redhat.com>> >>> JBoss Performance Team >>> >>> _______________________________________________ >>> infinispan-dev mailing list >>> infinispan-dev(a)lists.jboss.org

>>> https://lists.jboss.org/mailman/listinfo/infinispan-dev >> _______________________________________________ >> infinispan-dev mailing list >> infinispan-dev(a)lists.jboss.org

>> https://lists.jboss.org/mailman/listinfo/infinispan-dev >> > _______________________________________________ > infinispan-dev mailing list > infinispan-dev(a)lists.jboss.org

> https://lists.jboss.org/mailman/listinfo/infinispan-dev

Radim, I tried compiling Hibernate ORM 5.0 (master branch) against Infinispan 8.0.0.Beta2 and get the same compile error. I think that others want to bring Infinispan 8.0.0.Final into WildFly 10 but Infinispan 8.0.0.Final currently isn't compatible with Hibernate 5.0 (which is almost ready to go final). Would it be possible for Infinispan 8.0.0.Final to correct the below compiler error, so that WildFly 10 can work with both Hibernate 5.0 + Infinispan 8.0? Scott On 07/16/2015 04:34 AM, Radim Vansa wrote: > > On 07/15/2015 03:25 PM, Scott Marlow wrote: >> Looks like Hibernate 5.0 cannot be compiled against Infinispan 8.0.0.Beta1: >> >> " >> hibernate-infinispan/src/main/java/org/hibernate/cache/infinispan/util/Caches.java:209: >> error: cannot find symbol >> rpcManager.broadcastRpcCommand( cmd, isSync ); >> ^ >> symbol: method broadcastRpcCommand(EvictAllCommand,boolean) >> location: variable rpcManager of type RpcManager >> " >> >> Will this be fixed in Hibernate ORM 5.0 or Infinispan 8.0.0.Beta2? > > This should be fixed in ORM 5.x, but should I do a PR that uses > Infinispan 8.0.0.Beta1 as dependency, even though 8.0.0.Final won't get > out before ORM 5.0.0.Final? > >> >> More inline below... >> >> On 07/14/2015 05:27 PM, Sanne Grinovero wrote: >>> Hi Radim, I suspect that Steve won't allow an Infinispan upgrade to 8 >>> in a micro release of Hibernate.. that's against our conventions. >>> The better plan would be to work towards a Hibernate 5.1 version for >>> this, or make sure to talk with him in advance if that doesn't work >>> out. >> The first beta of WildFly 10 is scheduled for August 6th, 2015. IMO, >> with that target in mind, we should figure out if we can have a >> Hibernate 5.x and Infinispan 8.x that work together. I don't >> particularly care if the Hibernate ORM 5.0 release uses Infinispan 8.x, >> as long as someone is making sure Infinispan 8.x and ORM 5.0, work well >> together. IMO, we should either change the Infinispan 8 API to still >> work with Hibernate ORM 5 or update ORM 5 to work with Infinispan 8. > > See above: I would 'make sure' that they work together, but it's IMO not > possible until Infinispan 8.0 is released. > > Radim > >> >>> On 14 July 2015 at 16:16, Radim Vansa <rvansa(a)redhat.com&gt; wrote: >>>> IIRC currently hibernate-infinispan module uses just the basic cache >>>> API, which won't change. However, with certain consistency fixes ([1] >>>> [2] and maybe more) the Interceptor API is used (as the basic >>>> invalidation mode cannot make 2LC consistent on it own), which is about >>>> to change in Infinispan 8.0. >>>> I will take care of updating hibernate-infinispan module to 8.0 when it >>>> will be out. Since that would require only changes internal to that >>>> module, I hope this upgrade can be scoped to a micro-release. >>>> >>>> Radim >>>> >>>> [1] https://hibernate.atlassian.net/browse/HHH-9868 >>>> [2] https://hibernate.atlassian.net/browse/HHH-9881 >>>> >>>> On 07/14/2015 02:34 PM, Scott Marlow wrote: >>>>> Hi, >>>>> >>>>> I heard that Infinispan 8.0 may soon be integrated into WildFly 10.0. >>>>> If that happens, how does that impact Hibernate ORM 5.0 which currently >>>>> integrates with Infinispan 7.2.1.Final? Does Hibernate ORM 5.0 need any >>>>> changes to integrate with Infinispan 8.0? >>>>> >>>>> Thanks, >>>>> Scott >>>>> _______________________________________________ >>>>> infinispan-dev mailing list >>>>> infinispan-dev(a)lists.jboss.org >>>>> https://lists.jboss.org/mailman/listinfo/infinispan-dev >>>> >>>> -- >>>> Radim Vansa <rvansa(a)redhat.com&gt; >>>> JBoss Performance Team >>>> >>>> _______________________________________________ >>>> infinispan-dev mailing list >>>> infinispan-dev(a)lists.jboss.org >>>> https://lists.jboss.org/mailman/listinfo/infinispan-dev >>> _______________________________________________ >>> infinispan-dev mailing list >>> infinispan-dev(a)lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/infinispan-dev >>> >> _______________________________________________ >> infinispan-dev mailing list >> infinispan-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/infinispan-dev > > _______________________________________________ infinispan-dev mailing list infinispan-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev

To be fair, the RpcManager is not in an impl package, so I think it's fair for the Hibernate 2LC plugin to use it (as long as they accept more breakage than in the basic cache API). OTOH it may be a good idea to discuss what 2LC needs, and if we could integrate that in the basic API. Dan On Tue, Jul 28, 2015 at 1:13 AM, Tristan Tarrant <ttarrant(a)redhat.com&gt; wrote: > We should work to provide a public API we can maintain for the future, > instead of ORM relying on Infinispan internals. > > Tristan > > On 27/07/2015 21:51, Scott Marlow wrote: >> Radim, >> >> I tried compiling Hibernate ORM 5.0 (master branch) against Infinispan >> 8.0.0.Beta2 and get the same compile error. >> >> I think that others want to bring Infinispan 8.0.0.Final into WildFly 10 >> but Infinispan 8.0.0.Final currently isn't compatible with Hibernate 5.0 >> (which is almost ready to go final). >> >> Would it be possible for Infinispan 8.0.0.Final to correct the below >> compiler error, so that WildFly 10 can work with both Hibernate 5.0 + >> Infinispan 8.0? >> >> Scott >> >> On 07/16/2015 04:34 AM, Radim Vansa wrote: >>> >>> On 07/15/2015 03:25 PM, Scott Marlow wrote: >>>> Looks like Hibernate 5.0 cannot be compiled against Infinispan 8.0.0.Beta1: >>>> >>>> " >>>> hibernate-infinispan/src/main/java/org/hibernate/cache/infinispan/util/Caches.java:209: >>>> error: cannot find symbol >>>> rpcManager.broadcastRpcCommand( cmd, isSync ); >>>> ^ >>>> symbol: method broadcastRpcCommand(EvictAllCommand,boolean) >>>> location: variable rpcManager of type RpcManager >>>> " >>>> >>>> Will this be fixed in Hibernate ORM 5.0 or Infinispan 8.0.0.Beta2? >>> >>> This should be fixed in ORM 5.x, but should I do a PR that uses >>> Infinispan 8.0.0.Beta1 as dependency, even though 8.0.0.Final won't get >>> out before ORM 5.0.0.Final? >>> >>>> >>>> More inline below... >>>> >>>> On 07/14/2015 05:27 PM, Sanne Grinovero wrote: >>>>> Hi Radim, I suspect that Steve won't allow an Infinispan upgrade to 8 >>>>> in a micro release of Hibernate.. that's against our conventions. >>>>> The better plan would be to work towards a Hibernate 5.1 version for >>>>> this, or make sure to talk with him in advance if that doesn't work >>>>> out. >>>> The first beta of WildFly 10 is scheduled for August 6th, 2015. IMO, >>>> with that target in mind, we should figure out if we can have a >>>> Hibernate 5.x and Infinispan 8.x that work together. I don't >>>> particularly care if the Hibernate ORM 5.0 release uses Infinispan 8.x, >>>> as long as someone is making sure Infinispan 8.x and ORM 5.0, work well >>>> together. IMO, we should either change the Infinispan 8 API to still >>>> work with Hibernate ORM 5 or update ORM 5 to work with Infinispan 8. >>> >>> See above: I would 'make sure' that they work together, but it's IMO not >>> possible until Infinispan 8.0 is released. >>> >>> Radim >>> >>>> >>>>> On 14 July 2015 at 16:16, Radim Vansa <rvansa(a)redhat.com&gt; wrote: >>>>>> IIRC currently hibernate-infinispan module uses just the basic cache >>>>>> API, which won't change. However, with certain consistency fixes ([1] >>>>>> [2] and maybe more) the Interceptor API is used (as the basic >>>>>> invalidation mode cannot make 2LC consistent on it own), which is about >>>>>> to change in Infinispan 8.0. >>>>>> I will take care of updating hibernate-infinispan module to 8.0 when it >>>>>> will be out. Since that would require only changes internal to that >>>>>> module, I hope this upgrade can be scoped to a micro-release. >>>>>> >>>>>> Radim >>>>>> >>>>>> [1] https://hibernate.atlassian.net/browse/HHH-9868 >>>>>> [2] https://hibernate.atlassian.net/browse/HHH-9881 >>>>>> >>>>>> On 07/14/2015 02:34 PM, Scott Marlow wrote: >>>>>>> Hi, >>>>>>> >>>>>>> I heard that Infinispan 8.0 may soon be integrated into WildFly 10.0. >>>>>>> If that happens, how does that impact Hibernate ORM 5.0 which currently >>>>>>> integrates with Infinispan 7.2.1.Final? Does Hibernate ORM 5.0 need any >>>>>>> changes to integrate with Infinispan 8.0? >>>>>>> >>>>>>> Thanks, >>>>>>> Scott >>>>>>> _______________________________________________ >>>>>>> infinispan-dev mailing list >>>>>>> infinispan-dev(a)lists.jboss.org >>>>>>> https://lists.jboss.org/mailman/listinfo/infinispan-dev >>>>>> >>>>>> -- >>>>>> Radim Vansa <rvansa(a)redhat.com&gt; >>>>>> JBoss Performance Team >>>>>> >>>>>> _______________________________________________ >>>>>> infinispan-dev mailing list >>>>>> infinispan-dev(a)lists.jboss.org >>>>>> https://lists.jboss.org/mailman/listinfo/infinispan-dev >>>>> _______________________________________________ >>>>> infinispan-dev mailing list >>>>> infinispan-dev(a)lists.jboss.org >>>>> https://lists.jboss.org/mailman/listinfo/infinispan-dev >>>>> >>>> _______________________________________________ >>>> infinispan-dev mailing list >>>> infinispan-dev(a)lists.jboss.org >>>> https://lists.jboss.org/mailman/listinfo/infinispan-dev >>> >>> >> _______________________________________________ >> infinispan-dev mailing list >> infinispan-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/infinispan-dev >> >> > > -- > Tristan Tarrant > Infinispan Lead > JBoss, a division of Red Hat > _______________________________________________ > infinispan-dev mailing list > infinispan-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/infinispan-dev _______________________________________________ infinispan-dev mailing list infinispan-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev

Looking at the RpcManager interface in 7.x, that method had already been deprecated and the recommendation is to migrate to RpcManager.invokeRemotely(java.util.Collection, org.infinispan.commands.ReplicableCommand, RpcOptions) so I suggest the change should be in ORM rather than in Infinispan.

Tristan On 27/07/2015 21:51, Scott Marlow wrote: > Radim, > > I tried compiling Hibernate ORM 5.0 (master branch) against Infinispan > 8.0.0.Beta2 and get the same compile error. > > I think that others want to bring Infinispan 8.0.0.Final into WildFly 10 > but Infinispan 8.0.0.Final currently isn't compatible with Hibernate 5.0 > (which is almost ready to go final). > > Would it be possible for Infinispan 8.0.0.Final to correct the below > compiler error, so that WildFly 10 can work with both Hibernate 5.0 + > Infinispan 8.0? > > Scott > > On 07/16/2015 04:34 AM, Radim Vansa wrote: >> >> On 07/15/2015 03:25 PM, Scott Marlow wrote: >>> Looks like Hibernate 5.0 cannot be compiled against Infinispan 8.0.0.Beta1: >>> >>> " >>> hibernate-infinispan/src/main/java/org/hibernate/cache/infinispan/util/Caches.java:209: >>> error: cannot find symbol >>> rpcManager.broadcastRpcCommand( cmd, isSync ); >>> ^ >>> symbol: method broadcastRpcCommand(EvictAllCommand,boolean) >>> location: variable rpcManager of type RpcManager >>> " >>> >>> Will this be fixed in Hibernate ORM 5.0 or Infinispan 8.0.0.Beta2? >> >> This should be fixed in ORM 5.x, but should I do a PR that uses >> Infinispan 8.0.0.Beta1 as dependency, even though 8.0.0.Final won't get >> out before ORM 5.0.0.Final? >> >>> >>> More inline below... >>> >>> On 07/14/2015 05:27 PM, Sanne Grinovero wrote: >>>> Hi Radim, I suspect that Steve won't allow an Infinispan upgrade to 8 >>>> in a micro release of Hibernate.. that's against our conventions. >>>> The better plan would be to work towards a Hibernate 5.1 version for >>>> this, or make sure to talk with him in advance if that doesn't work >>>> out. >>> The first beta of WildFly 10 is scheduled for August 6th, 2015. IMO, >>> with that target in mind, we should figure out if we can have a >>> Hibernate 5.x and Infinispan 8.x that work together. I don't >>> particularly care if the Hibernate ORM 5.0 release uses Infinispan 8.x, >>> as long as someone is making sure Infinispan 8.x and ORM 5.0, work well >>> together. IMO, we should either change the Infinispan 8 API to still >>> work with Hibernate ORM 5 or update ORM 5 to work with Infinispan 8. >> >> See above: I would 'make sure' that they work together, but it's IMO not >> possible until Infinispan 8.0 is released. >> >> Radim >> >>> >>>> On 14 July 2015 at 16:16, Radim Vansa <rvansa(a)redhat.com&gt; wrote: >>>>> IIRC currently hibernate-infinispan module uses just the basic cache >>>>> API, which won't change. However, with certain consistency fixes ([1] >>>>> [2] and maybe more) the Interceptor API is used (as the basic >>>>> invalidation mode cannot make 2LC consistent on it own), which is about >>>>> to change in Infinispan 8.0. >>>>> I will take care of updating hibernate-infinispan module to 8.0 when it >>>>> will be out. Since that would require only changes internal to that >>>>> module, I hope this upgrade can be scoped to a micro-release. >>>>> >>>>> Radim >>>>> >>>>> [1] https://hibernate.atlassian.net/browse/HHH-9868 >>>>> [2] https://hibernate.atlassian.net/browse/HHH-9881 >>>>> >>>>> On 07/14/2015 02:34 PM, Scott Marlow wrote: >>>>>> Hi, >>>>>> >>>>>> I heard that Infinispan 8.0 may soon be integrated into WildFly 10.0. >>>>>> If that happens, how does that impact Hibernate ORM 5.0 which currently >>>>>> integrates with Infinispan 7.2.1.Final? Does Hibernate ORM 5.0 need any >>>>>> changes to integrate with Infinispan 8.0? >>>>>> >>>>>> Thanks, >>>>>> Scott >>>>>> _______________________________________________ >>>>>> infinispan-dev mailing list >>>>>> infinispan-dev(a)lists.jboss.org >>>>>> https://lists.jboss.org/mailman/listinfo/infinispan-dev >>>>> >>>>> -- >>>>> Radim Vansa <rvansa(a)redhat.com&gt; >>>>> JBoss Performance Team >>>>> >>>>> _______________________________________________ >>>>> infinispan-dev mailing list >>>>> infinispan-dev(a)lists.jboss.org >>>>> https://lists.jboss.org/mailman/listinfo/infinispan-dev >>>> _______________________________________________ >>>> infinispan-dev mailing list >>>> infinispan-dev(a)lists.jboss.org >>>> https://lists.jboss.org/mailman/listinfo/infinispan-dev >>>> >>> _______________________________________________ >>> infinispan-dev mailing list >>> infinispan-dev(a)lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/infinispan-dev >> >> > _______________________________________________ > infinispan-dev mailing list > infinispan-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/infinispan-dev > >

Paul Ferraro is going to work on a HHH-9999 change to address this that could help Hibernate ORM 5.0 work with Infinispan 8.0. If this works out, the change could be in Hibernate ORM 5.0 instead of Infinispan 8.0.0.Final. If not, we need a different solution. On 07/29/2015 02:48 PM, Scott Marlow wrote: > On 07/29/2015 08:58 AM, Tristan Tarrant wrote: >> Looking at the RpcManager interface in 7.x, that method had already been >> deprecated and the recommendation is to migrate to >> >> RpcManager.invokeRemotely(java.util.Collection, >> org.infinispan.commands.ReplicableCommand, RpcOptions) >> >> so I suggest the change should be in ORM rather than in Infinispan. > > I think that this will block WildFly 10 from upgrading to Infinispan 8, > as doing so will break Hibernate 5.0 (when Infinispan 8 is used as the > 2lc). > >> >> Tristan >> >> On 27/07/2015 21:51, Scott Marlow wrote: >>> Radim, >>> >>> I tried compiling Hibernate ORM 5.0 (master branch) against Infinispan >>> 8.0.0.Beta2 and get the same compile error. >>> >>> I think that others want to bring Infinispan 8.0.0.Final into WildFly 10 >>> but Infinispan 8.0.0.Final currently isn't compatible with Hibernate 5.0 >>> (which is almost ready to go final). >>> >>> Would it be possible for Infinispan 8.0.0.Final to correct the below >>> compiler error, so that WildFly 10 can work with both Hibernate 5.0 + >>> Infinispan 8.0? >>> >>> Scott >>> >>> On 07/16/2015 04:34 AM, Radim Vansa wrote: >>>> >>>> On 07/15/2015 03:25 PM, Scott Marlow wrote: >>>>> Looks like Hibernate 5.0 cannot be compiled against Infinispan 8.0.0.Beta1: >>>>> >>>>> " >>>>> hibernate-infinispan/src/main/java/org/hibernate/cache/infinispan/util/Caches.java:209: >>>>> error: cannot find symbol >>>>> rpcManager.broadcastRpcCommand( cmd, isSync ); >>>>> ^ >>>>> symbol: method broadcastRpcCommand(EvictAllCommand,boolean) >>>>> location: variable rpcManager of type RpcManager >>>>> " >>>>> >>>>> Will this be fixed in Hibernate ORM 5.0 or Infinispan 8.0.0.Beta2? >>>> >>>> This should be fixed in ORM 5.x, but should I do a PR that uses >>>> Infinispan 8.0.0.Beta1 as dependency, even though 8.0.0.Final won't get >>>> out before ORM 5.0.0.Final? >>>> >>>>> >>>>> More inline below... >>>>> >>>>> On 07/14/2015 05:27 PM, Sanne Grinovero wrote: >>>>>> Hi Radim, I suspect that Steve won't allow an Infinispan upgrade to 8 >>>>>> in a micro release of Hibernate.. that's against our conventions. >>>>>> The better plan would be to work towards a Hibernate 5.1 version for >>>>>> this, or make sure to talk with him in advance if that doesn't work >>>>>> out. >>>>> The first beta of WildFly 10 is scheduled for August 6th, 2015. IMO, >>>>> with that target in mind, we should figure out if we can have a >>>>> Hibernate 5.x and Infinispan 8.x that work together. I don't >>>>> particularly care if the Hibernate ORM 5.0 release uses Infinispan 8.x, >>>>> as long as someone is making sure Infinispan 8.x and ORM 5.0, work well >>>>> together. IMO, we should either change the Infinispan 8 API to still >>>>> work with Hibernate ORM 5 or update ORM 5 to work with Infinispan 8. >>>> >>>> See above: I would 'make sure' that they work together, but it's IMO not >>>> possible until Infinispan 8.0 is released. >>>> >>>> Radim >>>> >>>>> >>>>>> On 14 July 2015 at 16:16, Radim Vansa <rvansa(a)redhat.com&gt; wrote: >>>>>>> IIRC currently hibernate-infinispan module uses just the basic cache >>>>>>> API, which won't change. However, with certain consistency fixes ([1] >>>>>>> [2] and maybe more) the Interceptor API is used (as the basic >>>>>>> invalidation mode cannot make 2LC consistent on it own), which is about >>>>>>> to change in Infinispan 8.0. >>>>>>> I will take care of updating hibernate-infinispan module to 8.0 when it >>>>>>> will be out. Since that would require only changes internal to that >>>>>>> module, I hope this upgrade can be scoped to a micro-release. >>>>>>> >>>>>>> Radim >>>>>>> >>>>>>> [1] https://hibernate.atlassian.net/browse/HHH-9868 >>>>>>> [2] https://hibernate.atlassian.net/browse/HHH-9881 >>>>>>> >>>>>>> On 07/14/2015 02:34 PM, Scott Marlow wrote: >>>>>>>> Hi, >>>>>>>> >>>>>>>> I heard that Infinispan 8.0 may soon be integrated into WildFly 10.0. >>>>>>>> If that happens, how does that impact Hibernate ORM 5.0 which currently >>>>>>>> integrates with Infinispan 7.2.1.Final? Does Hibernate ORM 5.0 need any >>>>>>>> changes to integrate with Infinispan 8.0? >>>>>>>> >>>>>>>> Thanks, >>>>>>>> Scott >>>>>>>> _______________________________________________ >>>>>>>> infinispan-dev mailing list >>>>>>>> infinispan-dev(a)lists.jboss.org >>>>>>>> https://lists.jboss.org/mailman/listinfo/infinispan-dev >>>>>>> >>>>>>> -- >>>>>>> Radim Vansa <rvansa(a)redhat.com&gt; >>>>>>> JBoss Performance Team >>>>>>> >>>>>>> _______________________________________________ >>>>>>> infinispan-dev mailing list >>>>>>> infinispan-dev(a)lists.jboss.org >>>>>>> https://lists.jboss.org/mailman/listinfo/infinispan-dev >>>>>> _______________________________________________ >>>>>> infinispan-dev mailing list >>>>>> infinispan-dev(a)lists.jboss.org >>>>>> https://lists.jboss.org/mailman/listinfo/infinispan-dev >>>>>> >>>>> _______________________________________________ >>>>> infinispan-dev mailing list >>>>> infinispan-dev(a)lists.jboss.org >>>>> https://lists.jboss.org/mailman/listinfo/infinispan-dev >>>> >>>> >>> _______________________________________________ >>> infinispan-dev mailing list >>> infinispan-dev(a)lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/infinispan-dev >>> >>> >> > _______________________________________________ > infinispan-dev mailing list > infinispan-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/infinispan-dev > _______________________________________________ infinispan-dev mailing list infinispan-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev

On 29 July 2015 at 21:58, Scott Marlow <smarlow(a)redhat.com&gt; wrote: > With Paul's HHH-9999 fix, we can now compile and pass the ORM tests with > Infinispan 7.3.x. We can also compile Hibernate 5.0 against Infinispan > 8.0.0.Beta2 but get ORM test failures http://pastebin.com/T2Yt3gdn Let me guess.. you expect Infinispan 8 to parse configuration files meant for Infinispan 7?

I'm fixing the ORM testsuite so that we can run it on both versions as https://hibernate.atlassian.net/browse/HHH-10001 Looks promising: After working around the testsuite problem I'm down to two errors - which seem more likely related to my changes than the Infinispan version change - but will need some sleep before debugging those ;) Sanne On 29 July 2015 at 23:09, Sanne Grinovero <sanne(a)infinispan.org&gt; wrote: > On 29 July 2015 at 22:08, Sanne Grinovero <sanne(a)infinispan.org&gt; wrote: >> On 29 July 2015 at 21:58, Scott Marlow <smarlow(a)redhat.com&gt; wrote: >>> With Paul's HHH-9999 fix, we can now compile and pass the ORM tests with >>> Infinispan 7.3.x. We can also compile Hibernate 5.0 against Infinispan >>> 8.0.0.Beta2 but get ORM test failures http://pastebin.com/T2Yt3gdn >> >> Let me guess.. you expect Infinispan 8 to parse configuration files >> meant for Infinispan 7? > > I was wrong, the problem is caused by this commit, which makes > Infinispan now very picky on not having used AbstractInfinispanTest as > a base class: > https://github.com/infinispan/infinispan/commit/c9dfb > > Hibernate uses the Infinispan core testing helpers, but doesn't use > TestNG so I'm not sure what the best solution is here. > Should we set the thread name consistently in all Hibernate tests too? > Seems quite pointless, the tests aren't run in parallel either. > > Could the helper be made a bit more tolerant for other use cases? Or > maybe I should add a system property to have it change behaviour? > I'd prefer to set the system property for Infinispan's own use, and > default to lenient so that other people can reuse the helpers w/o > these contraints. > > Thanks, > Sanne _______________________________________________ infinispan-dev mailing list infinispan-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev

Good point. It works now (the issue is fixed) but we need to monitor both projects. I'll see how far that can be automated. Can I have ci spam you in case of failures? On Thu, 30 Jul 2015 15:34 Scott Marlow <smarlow(a)redhat.com <mailto:smarlow@redhat.com>> wrote: Thanks Sanne, this is a big help! IMO, we should run the Hibernate 5.0 testsuite again with Infinispan 8.x/master before releasing Infinispan 8.0.0.Final. Scott On 07/29/2015 07:24 PM, Sanne Grinovero wrote: > I'm fixing the ORM testsuite so that we can run it on both versions as > https://hibernate.atlassian.net/browse/HHH-10001 > > Looks promising: > After working around the testsuite problem I'm down to two errors - > which seem more likely related to my changes than the Infinispan > version change - but will need some sleep before debugging those ;) > > Sanne > > On 29 July 2015 at 23:09, Sanne Grinovero <sanne(a)infinispan.org <mailto:sanne@infinispan.org>> wrote: >> On 29 July 2015 at 22:08, Sanne Grinovero <sanne(a)infinispan.org <mailto:sanne@infinispan.org>> wrote: >>> On 29 July 2015 at 21:58, Scott Marlow <smarlow(a)redhat.com <mailto:smarlow@redhat.com>> wrote: >>>> With Paul's HHH-9999 fix, we can now compile and pass the ORM tests with >>>> Infinispan 7.3.x. We can also compile Hibernate 5.0 against Infinispan >>>> 8.0.0.Beta2 but get ORM test failures http://pastebin.com/T2Yt3gdn >>> >>> Let me guess.. you expect Infinispan 8 to parse configuration files >>> meant for Infinispan 7? >> >> I was wrong, the problem is caused by this commit, which makes >> Infinispan now very picky on not having used AbstractInfinispanTest as >> a base class: >> https://github.com/infinispan/infinispan/commit/c9dfb >> >> Hibernate uses the Infinispan core testing helpers, but doesn't use >> TestNG so I'm not sure what the best solution is here. >> Should we set the thread name consistently in all Hibernate tests too? >> Seems quite pointless, the tests aren't run in parallel either. >> >> Could the helper be made a bit more tolerant for other use cases? Or >> maybe I should add a system property to have it change behaviour? >> I'd prefer to set the system property for Infinispan's own use, and >> default to lenient so that other people can reuse the helpers w/o >> these contraints. >> >> Thanks, >> Sanne > _______________________________________________ > infinispan-dev mailing list > infinispan-dev(a)lists.jboss.org <mailto:infinispan-dev@lists.jboss.org> > https://lists.jboss.org/mailman/listinfo/infinispan-dev > _______________________________________________ infinispan-dev mailing list infinispan-dev(a)lists.jboss.org <mailto:infinispan-dev@lists.jboss.org> https://lists.jboss.org/mailman/listinfo/infinispan-dev _______________________________________________ infinispan-dev mailing list infinispan-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev

Hi Sanne Does Hibernate really need to use the Infinispan test helpers? They don't really do much unless you run the tests in parallel and you need them to be isolated...

----- Original Message ----- > On 31 July 2015 at 11:30, Dan Berindei <dan.berindei(a)gmail.com&gt; wrote: > > Hi Sanne > > > > Does Hibernate really need to use the Infinispan test helpers? They > > don't really do much unless you run the tests in parallel and you need > > them to be isolated... > > Good point. I don't know why it's using them exactly, but I guess it's > also to reduce thread pools and similar. We should ask Galder. There's not much to say other than Hibernate 2LC uses test helpers to make things easier to test, e.g. create clusters more easily, use test ping, mbeans...etc. > But I thought there was an intention to ultimately suggest Infinispan > end users to use our test helpers for development too? I talked about this in our last F2F, at some point we should create a testkit project with all the helpers...etc, independent of the testing framework used by the user. Right now, both set of helpers (test framework, and cache/cache manager creation ones) are bundled into one, and there's a fair bit of duplication around.