On 7 December 2011 11:19, Bela Ban <bban(a)redhat.com> wrote:
If you use a constant, this is not an issue, but what about:
String constant="Error message bla bla";
for(int i=1; i <=10; i++) {
log.trace(constant + "-" + i);
}
?
That should definitely be rewritten as
String constant="Error message bla bla";
if (log.isTraceEnabled()) {
final String constant="Error message bla bla";
for(int i=1; i <=10; i++) {
log.trace(constant + "-" + i);
}
}