Re: [infinispan-dev] TableManipulation refactoring

On 12 Oct 2010, at 16:57, 이희승 (Trustin Lee) wrote: > There are two on-going issues related with TableManipulation at the moment: > > https://jira.jboss.org/browse/ISPN-686 > https://jira.jboss.org/browse/ISPN-698 > > They both are related with vendor specific behavior, and the current > implementation uses switch-cases to deal with the differences between > vendors. Could we instead use inheritance to make the code look cleaner > and easier to maintain? Hibernate does so: > > > http://viewvc.jboss.org/cgi-bin/viewvc.cgi/hibernate/core/trunk/core/src/... +1. It would also be simpler for the contributors to make fixes themselves. > Also, the properties like custom types, names, prefixes, fetch/batch > sizes could be moved to AbstractJdbcCacheStoreConfig (or its subclass > because we have mixed JDBC store) instead of exposing TableManipulation > directly to a user? +1. API should't changed between 4.1 and 4.2. Perhaps deprecate the method that exposes TableManipulation and remove them entirely in 5.0?