Re: [infinispan-dev] [ISPN-176] CommandAwareRpcDispatcher.handle() should wrap throwable into ExceptionResponse

On 09/03/2009 04:05 PM, Galder Zamarreno wrote: > > On 09/03/2009 10:28 AM, Galder Zamarreno wrote: >> On 09/01/2009 06:20 PM, Galder Zamarreno wrote: >>> Hi, >>> >>> While working on the Hibernate cache provider classloader tests, >>> I've >>> come across https://jira.jboss.org/jira/browse/ISPN-176 >>> >>> IMO, the fix for this involves making >>> CommandAwareRpcDispatcher.handle() >>> return an ExceptionResponse with the throwable thrown. This would >>> require enhancing ExceptionResponse to deal with throwables >>> rather than >>> Exceptions. > > Actually, rather than modifying ExceptionResponse, I think it's > better > if a ThrowableResponse is created this type of situations. > ExceptionResponse is already being used primarily to deal with > application level exceptions, i.e. ReplicationException. > > I think it's better to have a separate one for unexpected ones that > covers the rest. Forget what I said, the sender side is not ready to handle Throwables, so easiest is to simply do: return new ExceptionResponse(new CacheException("Problems invoking command.", x));