+1 to integrate it.
Also, +1 on Radim's comment to remove the existing one: just yesterday
I had a problem with Infinispan blowing up with weird Externalizer
exceptions because I was attempting to activate data from a
FilesystemCacheStore which was stored with version 5.2.x, and I was
loading it from 5.3.0 : that doesn't work as apparently some encoding
changed, so unless we want to fix that there is no point in keeping
the existing CacheStore around.
Sanne
On 9 July 2013 10:07, Radim Vansa <rvansa(a)redhat.com> wrote:
----- Original Message -----
| From: "Galder ZamarreƱo" <galder(a)redhat.com>
| To: "infinispan -Dev List" <infinispan-dev(a)lists.jboss.org>
| Sent: Tuesday, July 9, 2013 10:32:52 AM
| Subject: [infinispan-dev] Integrating Karsten's FCS
|
| Hi,
|
| I think we all agree that Karsten's file cache store is a good base
| replacement for the current file cache store, particularly for caches with
| relatively small keys, or not a huge amount of them.
|
| I'm working with Radim to try to figure out what would be the tipping point
| at which LevelDB based cache store behaves better compared to Karsten's
| cache store.
|
| In the mean time, I think we should integrate Karsten's FCS into master and
| have it ready for people to try from Alpha1. There's one or two things that
| do require a bit of review, but I can pin point them in the pull req.
|
| The question is, how should we name it? And what should we do about the
| current FCS implementation?
|
| Shall we keep the current FCS implementation, deprecate it, and get rid of it
| in the next minor/major version? Some users might have data stored in the
| current FCS and would be quite abrupt to just get rid of it right now.
I'd remove it in Final, it cannot be seriously used either. Users can migrate the
data using rolling upgrades.
|
| If so, what do we name karsten's file cache store? AppendOnlyFileCacheStore?
You must have mixed something, Karsten is far from append-only, it writes to first big
enough empty space in the data file.
I'd emphasise that the keys are still in memory, therefore something like
InMemoryKeysFCS or MemKeysFCS. Or, we will not be as descriptive and call it HotFCS or
NextFCS...
|
| Cheers,
| --
| Galder ZamarreƱo
| galder(a)redhat.com
|
twitter.com/galderz
|
| Project Lead, Escalante
|
http://escalante.io
|
| Engineer, Infinispan
|
http://infinispan.org
|
|
| _______________________________________________
| infinispan-dev mailing list
| infinispan-dev(a)lists.jboss.org
|
https://lists.jboss.org/mailman/listinfo/infinispan-dev
|
_______________________________________________
infinispan-dev mailing list
infinispan-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/infinispan-dev