+1, looks good.
Sent from my mobile phone
On 15 Jun 2011, at 15:01, Vladimir Blagojevic <vblagoje(a)redhat.com> wrote:
On 11-06-15 3:52 AM, Galder ZamarreƱo wrote:
> Hey Vladimir,
>
> Couple of things, did you consider putting that logic in JGroupsTransport rather than
RpcManagerImpl? It looks to be more suited for the first since it's something specific
about the transport.
>
> I think the logic looks cleaner now with mimicPartialFlushViaRPC(stateSender, false)
called within a finally section.
>
Hey Galder,
Yes, I suppose we can do that as well and bury flushViaRPC to lower
levels of transport. If there are no side effects I'll go with that option!
Thanks for review!
Vladimir
_______________________________________________
infinispan-dev mailing list
infinispan-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/infinispan-dev