On Aug 4, 2011, at 4:28 PM, Galder Zamarreño wrote:
On Aug 4, 2011, at 4:22 PM, Sanne Grinovero wrote:
> 2011/8/4 Galder Zamarreño <galder(a)redhat.com>:
>>
>> </snip>
>
> agreed, as discussed with Dan we won't throw exceptions but log a
> warning to recommend people use the startCaches().
>
> Dan I still think the #startCaches method should at least log a
> warning if it's invoked more than once: it's very useful to be aware
> of the ISPN-658 as early as possible in the application design, and
> this is a good chance for us to detect the unsupported usage pattern.
> I think these two warnings combined can save a lot of time and stress,
> and won't affect any body who is doing it correctly already.
Hmmmm, not sure about the warn message. Surely a no-op and if it's no-op from the 2nd
time onwards, what's the warning about?
Btw, whatever is done, start() and stop() need to be symmetric, and currently calling
stop() on a already stopped cache does nothing.
In fact, a debug message is shown to indicate that the 2nd call is ignored:
AbstractComponentRegistry.stop():
getLog().debugf("Ignoring call to stop() as current state is %s", this);
> Cheers,
> Sanne
>
> _______________________________________________
> infinispan-dev mailing list
> infinispan-dev(a)lists.jboss.org
>
https://lists.jboss.org/mailman/listinfo/infinispan-dev
--
Galder Zamarreño
Sr. Software Engineer
Infinispan, JBoss Cache
_______________________________________________
infinispan-dev mailing list
infinispan-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/infinispan-dev
--
Galder Zamarreño
Sr. Software Engineer
Infinispan, JBoss Cache