Re: [infinispan-dev] Distributed execution framework - API proposal(s)

Hi there. Lets take the 2 API sets (M/R and distributed exec) separately: M/R * Why does MapReduceTask extend Set? It probably shouldn't even extend DistributedRemoteTask, since some methods such as execute(Callable) doesn't make sense for MapReduceTask. Perhaps a common super-interface? That alone should simplify the generics... * Why does Mapper.map() return a Map? [1] Shouldn't it return a single transformation for a given K and V? * Reducer.reduce()'s return type should not necessarily be the same type as the mapped transformation. Also, does the reducer really need the key? Surely just the transformed version of each K/V pair. * Similarly, Collator.add() should just need the address and the reduced result from each node (each node would only produce 1 result!) DistExec * Why do you have execute() and executeAsync() with no params? What do these methods do? * Not sure what DistributedTaskContext is all about. What does read() and write() do? Is this meant to be a "layer" in front of the cache in question? Why not just pass in a ref to the cache? * What does Factory do? Almost there! :-) Cheers Manik [1] How many times can I say "map" in one sentence? :) On 10 Jan 2011, at 19:28, Vladimir Blagojevic wrote: -- Manik Surtani manik(a)jboss.org twitter.com/maniksurtani Lead, Infinispan http://www.infinispan.org