Re: [infinispan-dev] infinispan-spring module

Am 21.04.11 19:47, schrieb Manik Surtani: > > > On 21 Apr 2011, at 18:17, Olaf Bergner wrote: > >> Hi Manik, >> >> Am 21.04.11 16:11, schrieb Manik Surtani: > >> Since it's just a new module that doesn't affect the current code base >> in any way I too think that it makes sense to have this in 4.2.x. Are >> there any commit rules I should pay attention to? I.e. do I create this >> module in 4.2.x and merge that into master? Or the other way around? How >> do you usually handle this? > > Since this is a new and clean module it doesn't matter which direction it goes. Maybe commit into 4.2.x and cherry pick the commit onto master? Remember that you still should use topic branches for each of these commits and issue a pull request to upstream. Topic branches are a given. So I will move Spring-Infinispan to a new submodule using a new topic branch t_ispn961, rebase that on 4.2.x and issue a pull request. Provided that is accepted, I'll do likewise on master, correct? > > http://community.jboss.org/wiki/InfinispanandGitHub > > Also have a look at one of the other modules' pom.xml files (e.g., tree) to see how it inherits from infinispan-parent. I'll do. One hopefully minor issue, though: expecting to have this accepted as an official Spring Extension I used JUnit instead of TestNG since the latter isn't used in Spring land. Do I have to port those tests or is it OK to pull JUnit in? Cheers, Olaf > > Cheers > Manik > > -- > Manik Surtani > manik(a)jboss.org > twitter.com/maniksurtani > > Lead, Infinispan > http://www.infinispan.org > > > > > _______________________________________________ > infinispan-dev mailing list > infinispan-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/infinispan-dev _______________________________________________ infinispan-dev mailing list infinispan-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev