On 25 Oct 2010, at 16:24, Vladimir Blagojevic wrote:
On 2010-10-25, at 11:08 AM, Manik Surtani wrote:
>
> On 25 Oct 2010, at 15:58, Vladimir Blagojevic wrote:
>
>> What do you mean by "may be interested in a @ViewChanged callback during a
merge as well"? Removing @Merged altogether?
>
> No, just that a merge event as detected from JGroups should trigger both view changed
as well as merged notifications.
>
> +1 to most of your changes in the changeset though, including the MergeEvent extends
ViewChangedEvent. I'm just removing the unnecessary @Merged annotations in our code
since they wil be triggered by the @ViewChanged annotation anyway.
+1 for that logic as well. However, I think you have to slightly change firing of those
events from JGroupsTransport in order to implement what we want. Please verify :)
Yep, I have changed how these events are fired.
--
Manik Surtani
manik(a)jboss.org
Lead, Infinispan
Lead, JBoss Cache
http://www.infinispan.org
http://www.jbosscache.org