Re: [infinispan-dev] ISPN-2463: Removing some deprecated methods within MultipleCacheManagersTest?
On 14.11.2012 06:46, Navin Surtani wrote:
Hey all,
Possibly the first of a few emails with questions on this JIRA and understanding the
state of things since I haven't been looking at code on this project in a long, long
time.
This JIRA (ISPN-2463) is essentially about cleaning up the use of the configuration API -
i.e. not using org.infinispan.config.Configuration and using
org.infinispan.configuration.cache.Configuration - and removing a lot of calls to the
deprecated Configuration class within the test-suite. Should the methods that make calls
to the now deprecated Configuration class be removed in the abstract test classes such as
MultipleCacheManagersTest? For example, should this method [1] be removed and any other
methods that call it be modified appropriately?
In fact beside the test for compatibility of the old api and adaption no
org.infinispan.config stuff should be used in test cases.
When you have migrated all the usages to the current methods, this can
be removed. From time to time I migrate also some test classes in/for 5.2.
ISPN is well tested (yay :-), so the migration is straight forward work.
But be careful, I noticed slighly differences in the defaults used in
the old configuration compared with the new one. For example it may be
needed that you set LockingMode.PESSIMISTIC when tx is used, since the
old config defaults are more or less the same as the current
PESSIMISTIC. The new configuration api defaults using
LockingMode.OPTIMISTIC as default.