Hello all, could anybody explain why the ComponentRegistry is performing the following operation ? The method AbstractComponentRegistry#getFromConfiguration(Class<T>) which invokes: org.infinispan.util.BeanUtils.getterMethod(Class, Class) and this one throws thousands of NoSuchMethodException if you have a rather large number of caches to see if it can find a matching element, and seems to slow down startup significantly in some cases. Throwing such an exception seems to be expected since it's inspecting Configuration.class (statically!) - it always returns null. I've tried to remove all those methods and short-circuit a nicely performing "return null": not a single test failed.

> sounds sensible to me: this is not public API and that method's logic is pretty straight forward. Of course we can start a discussion on IRC about this if you want... Not sure I understand you. You mean it makes sense to remove the code, or the code makes sense to you so I'm missing something? IRC won't work since you're not online :) Cheers, Sanne _______________________________________________ infinispan-dev mailing list infinispan-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev

2011/8/3 Dan Berindei <dan.berindei(a)gmail.com&gt;: > I think it's supposed to be an automatic version of > https://github.com/infinispan/infinispan/blob/master/core/src/main/java/o... > I prefer the manual version in GlobalConfiguration, although I don't > think there are any users for those components either. > > Dan I was thinking something similar, but would like to know if it's still used, somebody must know about this code? Initially I thought it was some clever way to extract instances from a user-customizable configuration instance, but since it's reflecting on the static definition of Configuration it doesn't look like it's meant to support extensions of it. If it's used we could cache the references to existing methods and track also which methods don't exist, so we limit the number of exceptions to a single one per attempted method name (i.e. starting 500 caches would cost as starting one).

_______________________________________________ infinispan-dev mailing list infinispan-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev

Hello all, could anybody explain why the ComponentRegistry is performing the following operation ? The method AbstractComponentRegistry#getFromConfiguration(Class<T>) which invokes: org.infinispan.util.BeanUtils.getterMethod(Class, Class) and this one throws thousands of NoSuchMethodException if you have a rather large number of caches to see if it can find a matching element, and seems to slow down startup significantly in some cases. Throwing such an exception seems to be expected since it's inspecting Configuration.class (statically!) - it always returns null. I've tried to remove all those methods and short-circuit a nicely performing "return null": not a single test failed. (No test failed -> useless code, or missing tests) Shall I remove the code? Cheers, Sanne _______________________________________________ infinispan-dev mailing list infinispan-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev