Hi again, Another thing I've spotted. I've realised that you can MBeanServer.invoke() to call any method on a class that is exposed as MBean via @MBean annotation because of the logic in ResourceDMBean.invoke(). Shouldn't such invocations be limited only to those methods that have been exposed via @ManagedOperation?

Cheers,

Yeah, this is correct. In a standard MBean, the operation called must be part of the MBean interface, otherwise it fails. So, it must be exposed somehow. In a required model mbean, the operation must have been defined as an MBean method. So, yeah, ResourceDMBean.invoke() needs to check whether the method called is a managed operation or not. I'll create a jira for this asap.

On Sep 8, 2009, at 8:38 PM, Vladimir Blagojevic wrote: > Bela and I deviated from spec intentionally because we liked the fact > that you could expose all class methods by simply annotating class > with > @MBean. Either way it should be simple to fix. > yep, perhaps we should have an exposeByDefault attribute on @MBean that is defaulted to false.

On 09-09-09 4:57 AM, Mircea Markus wrote: > On Sep 8, 2009, at 8:38 PM, Vladimir Blagojevic wrote: > > >> Bela and I deviated from spec intentionally because we liked the fact >> that you could expose all class methods by simply annotating class >> with >> @MBean. Either way it should be simple to fix. >> > yep, perhaps we should have an exposeByDefault attribute on @MBean > that is defaulted to false. > > I think Galder's point is to be as close to spec as possible and I agree if we are going to have components that third-party people are going to decorate. One day when jdk 7 goes live, and we start using real JMX annotations the transition will be easier.

_______________________________________________ infinispan-dev mailing list infinispan-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev

On 09/09/2009 10:57 AM, Mircea Markus wrote: > > On Sep 8, 2009, at 8:38 PM, Vladimir Blagojevic wrote: > >> On 09-09-08 12:58 PM, Galder Zamarreno wrote: >>> Yeah, this is correct. In a standard MBean, the operation called >>> must be >>> part of the MBean interface, otherwise it fails. So, it must be >>> exposed >>> somehow. In a required model mbean, the operation must have been >>> defined >>> as an MBean method. >>> >>> So, yeah, ResourceDMBean.invoke() needs to check whether the method >>> called is a managed operation or not. I'll create a jira for this >>> asap. >>> >> Bela and I deviated from spec intentionally because we liked the >> fact >> that you could expose all class methods by simply annotating class >> with >> @MBean. Either way it should be simple to fix. > yep, perhaps we should have an exposeByDefault attribute on @MBean > that is defaulted to false. Hmmm, don't think so. We shouldn't try to use JMX as a swiss knife. If we wanna expose something, we should annotate it accordingly, otherwise it shouldn't be called via JMX. >> >> Cheers >> _______________________________________________ >> infinispan-dev mailing list >> infinispan-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/infinispan-dev > > _______________________________________________ > infinispan-dev mailing list > infinispan-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/infinispan-dev -- Galder Zamarreño Sr. Software Engineer Infinispan, JBoss Cache _______________________________________________ infinispan-dev mailing list infinispan-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev