Sanne, that is different. I am talking about tests related to issue
ISPN-xxxx which is know to fail as a proof of ISPN-xxxx existence. These
tests should be attached/referenced in related JIRA, not merged in
master through PRs.
On 12-10-25 11:37 AM, Sanne Grinovero wrote:
Hi Vladimir,
I'm not sure I understood you. are these pulls you mention having failing tests?
I've sent a test related PR yesterday which was just changing a single
test from using deprecated code to new code, there is nothing to fix.
Sanne
On 25 October 2012 15:52, Vladimir Blagojevic <vblagoje(a)redhat.com> wrote:
> Hi,
>
> I noticed that we recently have had many PR for unit tests integration
> into master. Would it not make more sense to integrate unit tests with
> actual fixes rather than having them merged directly to master as PRs?
> I'd say leave a unit test attached/referenced in JIRA and a
> developer/contributor fixing the issue will integrate both the fix and
> the unit test in a single PR.
>
> WDYT?
>
> Regards,
> Vladimir
>
>
>
> _______________________________________________
> infinispan-dev mailing list
> infinispan-dev(a)lists.jboss.org
>
https://lists.jboss.org/mailman/listinfo/infinispan-dev
_______________________________________________
infinispan-dev mailing list
infinispan-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/infinispan-dev