At least Infinispan -all.zip distro does not include a log4j jar in the root lib/ directory. This means that by default it logs using JDK logging. However, we ship an etc/log4j.xml and it might not be obvious to people that they need to bring in log4j.jar to see changes being made to etc/log4j.xml having an effect. So, I'd propose to include a log4j jar in the root lib/ directory. Any objections to that? -- Galder Zamarreño Sr. Software Engineer Infinispan, JBoss Cache _______________________________________________ infinispan-dev mailing list infinispan-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev

Not sure which one is more used: if it is log4j (which I think it is) then this way we would help the majority of people that wouldn't need to download it. On 1 Jul 2010, at 18:11, Manik Surtani wrote: > Hmm ... has this been a problem for people so far? > > On 1 Jul 2010, at 16:05, Galder Zamarreño wrote: > >> At least Infinispan -all.zip distro does not include a log4j jar in the root lib/ directory. >> >> This means that by default it logs using JDK logging. However, we ship an etc/log4j.xml and it might not be obvious to people that they need to bring in log4j.jar to see changes being made to etc/log4j.xml having an effect. >> >> So, I'd propose to include a log4j jar in the root lib/ directory. >> >> Any objections to that? >> -- >> Galder Zamarreño >> Sr. Software Engineer >> Infinispan, JBoss Cache >> >> >> _______________________________________________ >> infinispan-dev mailing list >> infinispan-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/infinispan-dev > > -- > Manik Surtani > manik(a)jboss.org > Lead, Infinispan > Lead, JBoss Cache > http://www.infinispan.org > http://www.jbosscache.org > > > > > > _______________________________________________ > infinispan-dev mailing list > infinispan-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/infinispan-dev _______________________________________________ infinispan-dev mailing list infinispan-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev

On 2 Jul 2010, at 17:24, Galder Zamarreño wrote: > Not so much about which one is more used but the fact that we ship a log4j.xml. So, people expect changes to that to work out of the box. I do at least but that's not the case with at least GUI and server modules. > > Some other modules do include log4j.jar which is why when those modules are in use, logging works. > > So, right now, these are the modules that ship log4j.jar: > > ./modules/ec2/lib/log4j-1.2.14.jar > ./modules/gui/lib/log4j-1.2.14.jar > ./modules/lucene-directory-demo/lib/log4j-1.2.14.jar > > This is a bit wasteful cos we're shipping the same jar in diff modules. On the other hand, only when one of these modules it's used, log4j.xml changes work. > > Shipping log4j.jar under root lib/ and removing these other jars would prob be better Ok. Create a JIRA and I'll look into it before we cut CR1 > > On Jul 1, 2010, at 5:13 PM, Mircea Markus wrote: > >> Not sure which one is more used: if it is log4j (which I think it is) then this way we would help the majority of people that wouldn't need to download it. >> On 1 Jul 2010, at 18:11, Manik Surtani wrote: >> >>> Hmm ... has this been a problem for people so far? >>> >>> On 1 Jul 2010, at 16:05, Galder Zamarreño wrote: >>> >>>> At least Infinispan -all.zip distro does not include a log4j jar in the root lib/ directory. >>>> >>>> This means that by default it logs using JDK logging. However, we ship an etc/log4j.xml and it might not be obvious to people that they need to bring in log4j.jar to see changes being made to etc/log4j.xml having an effect. >>>> >>>> So, I'd propose to include a log4j jar in the root lib/ directory. >>>> >>>> Any objections to that? >>>> -- >>>> Galder Zamarreño >>>> Sr. Software Engineer >>>> Infinispan, JBoss Cache >>>> >>>> >>>> _______________________________________________ >>>> infinispan-dev mailing list >>>> infinispan-dev(a)lists.jboss.org >>>> https://lists.jboss.org/mailman/listinfo/infinispan-dev >>> >>> -- >>> Manik Surtani >>> manik(a)jboss.org >>> Lead, Infinispan >>> Lead, JBoss Cache >>> http://www.infinispan.org >>> http://www.jbosscache.org >>> >>> >>> >>> >>> >>> _______________________________________________ >>> infinispan-dev mailing list >>> infinispan-dev(a)lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/infinispan-dev >> >> >> _______________________________________________ >> infinispan-dev mailing list >> infinispan-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/infinispan-dev > > -- > Galder Zamarreño > Sr. Software Engineer > Infinispan, JBoss Cache > > > _______________________________________________ > infinispan-dev mailing list > infinispan-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/infinispan-dev -- Manik Surtani manik(a)jboss.org Lead, Infinispan Lead, JBoss Cache http://www.infinispan.org http://www.jbosscache.org _______________________________________________ infinispan-dev mailing list infinispan-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev

In fact, I think someone on IRC had that issue today. He said: "michaelb joined the chat room. [3:01pm]michaelb:hi [3:02pm]michaelb:the logging of the gui demo doesn't seem to work out of the box" Unfortunately he was gone by the time I replied to him. I'm fairly confident the issue is to do with this. log4j.xml modifications when using the GUI have no effect without it. I had this issue myself when trying to enable logging to figure out what was wrong with Hot Rod. That's how I realised that log4j jar was not on the classpath. On Jul 1, 2010, at 5:11 PM, Manik Surtani wrote: > Hmm ... has this been a problem for people so far? > > On 1 Jul 2010, at 16:05, Galder Zamarreño wrote: > >> At least Infinispan -all.zip distro does not include a log4j jar in the root lib/ directory. >> >> This means that by default it logs using JDK logging. However, we ship an etc/log4j.xml and it might not be obvious to people that they need to bring in log4j.jar to see changes being made to etc/log4j.xml having an effect. >> >> So, I'd propose to include a log4j jar in the root lib/ directory. >> >> Any objections to that? >> -- >> Galder Zamarreño >> Sr. Software Engineer >> Infinispan, JBoss Cache >> >> >> _______________________________________________ >> infinispan-dev mailing list >> infinispan-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/infinispan-dev > > -- > Manik Surtani > manik(a)jboss.org > Lead, Infinispan > Lead, JBoss Cache > http://www.infinispan.org > http://www.jbosscache.org > > > > > > _______________________________________________ > infinispan-dev mailing list > infinispan-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/infinispan-dev -- Galder Zamarreño Sr. Software Engineer Infinispan, JBoss Cache _______________________________________________ infinispan-dev mailing list infinispan-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev