On 26 Jan 2011, at 12:19, Manik Surtani wrote:
On 26 Jan 2011, at 12:17, Mircea Markus wrote:
> On 25 Jan 2011, at 17:12, Manik Surtani wrote:
>> How's this for a solution:
>>
>> 1) Test suite remains the same
> I don't think performance is affected by using JBossTM for test runs, I'll
need to check by running it
It should be quicker. There is no maintenance of a persistent tx log.
Not
necessarily: the log would only be written for tx that span more than an participant (have
more than 1 XAReource enlisted). AFAIK there are very few tests like that in ISPN (I can
only remember one). If only one participant in tx the TM would doesn't have to persist
the log to disk.
>> 2) Running tests locally remains the same (using the DummyTM)
> Is there any advantage in doing that besides being able to run tests more quickly?
:-)
Nope.
>> 3) Our Hudson environment runs the testsuite with the -Dinfinispan.tm=jbosstm
parameter.
>>
>> This way, at least our CI builds will use a *real* TM. If we find failures on
Hudson that we want to debug locally, we add -Dinfinispan.tm=jbosstm parameter. to any
local run we want to trace.
>>
>> Thoughts?
> My concern is that we'll have to enhance DummyTM to be "more" compliant
with the jta spec. As long as that's not going to happen I'm fine with using it
for local test. IMO no point spending effort enhancing DummyTM.
I agree with you that there is no point expending effort to enhance the DummyTM - but IMO
I don't think this is necessary right now.
not now but it most likely will need
to be extended. E.g. DummyTM DOES call XAResource.commit on read only resources, and that
functionality will need to be corrected once a tests is added in which 1 out of 3
resources return a readonly response. IMO DTM's scope should only be fore batching.
Cheers
Manik
--
Manik Surtani
manik(a)jboss.org
twitter.com/maniksurtani
Lead, Infinispan
http://www.infinispan.org
_______________________________________________
infinispan-dev mailing list
infinispan-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/infinispan-dev