Thanks.
Yes, I see a little annoyance of adding --keep-content here. The reason
I left it required is for being consistent wrt what triggers removal of
the content.
If in some cases it's not required then it's not consistent and maybe
misleading. I can then easily imagine forgetting to add --keep-content
after listing all the server groups in --server-groups=... and
unintentionally removing the content.
So currently, if you want the content to remain in the repository you
*always* include --keep-content and this manifests your intention.
Otherwise it's removed or results in an error if it can't be.
Perhaps, it makes sense to reverse the behaviour, i.e. make undeploy
keep the content by default and have --remove-content instead. What do
you think?
BTW, there is a similar thing with deploy, i.e. it enables the
deployment by default and has --disabled switch if you want to just add
the content to the repository w/o enabling it.
Alexey
On 05/03/2011 02:46 PM, Jaikiran Pai wrote:
Looks great!
The doc mentions that undeploying an app from only a specific subset of
server groups is done as follows:
undeploy test-deployment.sar --server-groups=other-server-group
--keep-content
and without the --keep-content the command is going to fail since some
other server group requires the deployment.
How about making the --keep-content as default in cases like these where
there are some server groups refering to that deployment? That way the
user doesn't have to explicitly keep passing that param. Additionally,
we can then improve the return message letting the user know that the
content wasn't discarded.
-Jaikiran
On Monday 02 May 2011 03:17 PM, Alexey Loubyansky wrote:
> This is what's currently implemented
>
http://community.jboss.org/wiki/DeployAndUndeployWithTheCLI
>
> As usually, suggestions are welcome.
>
> Thanks,
> Alexey
> _______________________________________________
> jboss-as7-dev mailing list
> jboss-as7-dev(a)lists.jboss.org
>
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
_______________________________________________
jboss-as7-dev mailing list
jboss-as7-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev