I don't see a significant downside. Am I missing something?
If you worry that the op request format in the cli will become more
complex then I don't think it's a big issue. We can add some other
brackets for the headers or something. It'll probably turn out to be an
advantage at the end.
Also, the current expectation is that with the maturity of the cli and
the list of supported commands, the raw operation requests will become
less popular.
I think, this structural change makes sense. I'd also consider a
separate node for the properties since every other child node name is
fixed (operation, address) and to avoid collisions between the property
names and the fixed name.
Alexey
On 03/22/2011 08:30 PM, Brian Stansberry wrote:
Heiko, Ike, Alexey (or others with thoughts):
In the operation request format there are a couple of extraneous bits
that have crept in that basically tell the server information about how
to execute the operation rather than the body of the operation itself.
Wanted to get your opinion on an idea that came up today (see JIRA
below) to segregate these from the rest of the operation.
Basically, instead of the current
{
"operation"=>"add",
"address"=>{"subsystem"=>"foo"},
"paramX"=>"A",
"paramY"=>true,
"rollback-on-runtime-failure"=>"false",
"rollout-plan"=>{.....}
}
It would be:
{
"operation"=>"add",
"address"=>{"subsystem"=>"foo"},
"paramX"=>"A",
"paramY"=>true,
"operation-headers"=>{
"rollback-on-runtime-failure"=>"false",
"rollout-plan"=>{.....}
}
}
Alexey, I first thought about the CLI just as I was about to send this.
This idea would make setting this kind of thing via the CLI harder for
users, which is a significant downside.
On 3/22/11 10:38 AM, Brian Stansberry (JIRA) wrote:
> Create an "operation-header" section in operation requests
> ----------------------------------------------------------
>
> Key: JBAS-9112
> URL:
https://issues.jboss.org/browse/JBAS-9112
> Project: JBoss Application Server
> Issue Type: Task
> Security Level: Public (Everyone can see)
> Components: Domain Management
> Reporter: Brian Stansberry
> Assignee: Brian Stansberry
> Fix For: 7.0.0.Beta2
>
>
> For the oddball stuff that goes along with some ops:
>
>
"operation-headers"=>{"rollout-plan"=>{..},"rollback-on-runtime-failure"=>false,
"ignore-restart-required"=>true,...}
>
> "operation" and "address" would not move -- too disruptive
>
> --
> This message is automatically generated by JIRA.
> For more information on JIRA, see:
http://www.atlassian.com/software/jira