Yes, it's mainly a performance thing for resource bundles not being
used. We did however just do a new release of the tooling,
jboss-logging-processor-1.0.3.Final, that will validate translations and
fallback to the original message if the translation message is invalid.
On 05/15/2012 04:09 AM, Bartosz Baranowski wrote:
I wonder why ResourceBundle is not used ? jboss-log* stuff seems to
have this fallback in source. Is the instrumentation introduced purely for performance?
----- Original Message -----
From: "Carlo de Wolf"<cdewolf(a)redhat.com>
To: jboss-as7-dev(a)lists.jboss.org
Sent: Tuesday, May 15, 2012 11:35:40 AM
Subject: Re: [jboss-as7-dev] Process for patching localized translation files
The properties files themselves are not the real owner of the messages.
The generated logging classes are.
Can someone elaborate a bit more on this process?
Maybe we can work from a case by just creating a translation from
scratch without touching AS code / build?
Carlo
On 05/14/2012 08:55 PM, Brian Stansberry wrote:
> OK, thanks. We won't merge changes to these localized properties files then.
>
> I added Component "Localization" to the AS7 project in JIRA. So problems
> with the translations can be filed against the component to make it easy
> for your team to find them.
>
> We'll encourage contributors to help via zanata, but if they don't want
> to an option is to attach patches to JIRAs filed against the
> Localization component.
>
> On 5/13/12 11:30 PM, Manuel Ospina wrote:
>> Hello Brian,
>>
>> The best is to fix the error in Zanata itself. Otherwise it would be necessary to
pull the content from Zanata, apply the patch and push the translations back to zanata.
>>
>> Regards,
>> Manuel
>>
>> ----- Original Message -----
>> From: "Brian Stansberry"<brian.stansberry(a)redhat.com>
>> To: "Manuel Ospina"<mospina(a)redhat.com>
>> Cc: "jboss-as7-dev(a)lists.jboss.org
Development"<jboss-as7-dev(a)lists.jboss.org>
>> Sent: Friday, May 11, 2012 3:47:40 AM
>> Subject: Process for patching localized translation files
>>
>> Hi Manuel,
>>
>> Can you describe a bit what process we should follow for handling
>> community updates to the localized text files in the AS? For example,
>> the various LocalDescriptions_fr.properties files.
>>
>> The files are now in the AS codebase itself, so naturally people are
>> going to start sending in patches that directly edit them [1]. But I
>> suspect that's not the correct process, and perhaps changes need to go
>> through
https://translate.jboss.org/ with the person proposing the patch
>> signing up and joining the appropriate language team?
>>
>> If the process isn't as simple as us directly accepting patches via
>> github, it would be great to include some comments at the top of each
>> file pointing to instructions on how to submit fixes.
>>
>> [1] For example,
https://github.com/jbossas/jboss-as/pull/2292
>>
_______________________________________________
jboss-as7-dev mailing list
jboss-as7-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
_______________________________________________
jboss-as7-dev mailing list
jboss-as7-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
--
James R. Perkins
JBoss by Red Hat