[JBoss JIRA] (WFCORE-3655) Improve embedded HC started with empty config state reporting?
by Ken Wills (JIRA)
[ https://issues.jboss.org/browse/WFCORE-3655?page=com.atlassian.jira.plugi... ]
Ken Wills commented on WFCORE-3655:
-----------------------------------
[~brian.stansberry] Thanks Brian. This is basically the reason why I thought creating this issue for the discussion would probably be a good idea.
The API definetly sounds like the way to go. Although, short term, if we're concerned, it may be sufficient to poll on the host resource being visible in the model to avoid this specific race?
> Improve embedded HC started with empty config state reporting?
> --------------------------------------------------------------
>
> Key: WFCORE-3655
> URL: https://issues.jboss.org/browse/WFCORE-3655
> Project: WildFly Core
> Issue Type: Enhancement
> Reporter: Ken Wills
> Assignee: Ken Wills
> Priority: Minor
>
> This is a discussion ticket, and I'm really only making it to track the discussion at the moment.
> Alexey and I had a discussion regarding this, and I thought it would be useful to open this and get other feedback.
> Currently, when an embedded host controller is started with an empty config, a partial domain controller start is performed and then paused until the /host=foo:add command is issued.
> In the case that the HC is being started programatically it seems desirable to be able to check this step has been completed.
> Using the command from the CLI / inside a cli script doesn't have this problem as the CLI waits for the response before continuuing.
> Some clients poll on the /host=foo:host-status attribute, this isn't present until a host has been actually added though.
> the existing options are:
> (a) Like the CLI, just wait until the operation completes. I think this should currently always work.
> (b) Poll on the existence of the /host resource. If this is registered, then you can safely try to add your host (after all there may already be one.)
> Since the host hasn't been added, it doesn't make a lot of sense to provided a default status, as theres no /host=foo to hold the attribute.
> Other thoughts? Personally I'm a fan of (a). And I think that should always be sufficient. I'm not really sure what the programmatic expectations are for using ops like this are in general. Is behavior always assumed to be synchronous, so the end client doesn't need to poll or wait etc?
> [~aloubyansky] Feel free to comment and correct me if I was inaccurate about something.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 8 months
[JBoss JIRA] (WFCORE-3655) Improve embedded HC started with empty config state reporting?
by Alexey Loubyansky (JIRA)
[ https://issues.jboss.org/browse/WFCORE-3655?page=com.atlassian.jira.plugi... ]
Alexey Loubyansky commented on WFCORE-3655:
-------------------------------------------
I think Brian's idea is how I'd personally like it to be implemented. There could also be a method that would block until the embedded process has reached the usable state.
> Improve embedded HC started with empty config state reporting?
> --------------------------------------------------------------
>
> Key: WFCORE-3655
> URL: https://issues.jboss.org/browse/WFCORE-3655
> Project: WildFly Core
> Issue Type: Enhancement
> Reporter: Ken Wills
> Assignee: Ken Wills
> Priority: Minor
>
> This is a discussion ticket, and I'm really only making it to track the discussion at the moment.
> Alexey and I had a discussion regarding this, and I thought it would be useful to open this and get other feedback.
> Currently, when an embedded host controller is started with an empty config, a partial domain controller start is performed and then paused until the /host=foo:add command is issued.
> In the case that the HC is being started programatically it seems desirable to be able to check this step has been completed.
> Using the command from the CLI / inside a cli script doesn't have this problem as the CLI waits for the response before continuuing.
> Some clients poll on the /host=foo:host-status attribute, this isn't present until a host has been actually added though.
> the existing options are:
> (a) Like the CLI, just wait until the operation completes. I think this should currently always work.
> (b) Poll on the existence of the /host resource. If this is registered, then you can safely try to add your host (after all there may already be one.)
> Since the host hasn't been added, it doesn't make a lot of sense to provided a default status, as theres no /host=foo to hold the attribute.
> Other thoughts? Personally I'm a fan of (a). And I think that should always be sufficient. I'm not really sure what the programmatic expectations are for using ops like this are in general. Is behavior always assumed to be synchronous, so the end client doesn't need to poll or wait etc?
> [~aloubyansky] Feel free to comment and correct me if I was inaccurate about something.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 8 months
[JBoss JIRA] (WFCORE-3655) Improve embedded HC started with empty config state reporting?
by Alexey Loubyansky (JIRA)
[ https://issues.jboss.org/browse/WFCORE-3655?page=com.atlassian.jira.plugi... ]
Alexey Loubyansky commented on WFCORE-3655:
-------------------------------------------
Thanks Ken for creating an issue for this.
Which operation did you imply in (a)? Was that /host=name:add?
> Improve embedded HC started with empty config state reporting?
> --------------------------------------------------------------
>
> Key: WFCORE-3655
> URL: https://issues.jboss.org/browse/WFCORE-3655
> Project: WildFly Core
> Issue Type: Enhancement
> Reporter: Ken Wills
> Assignee: Ken Wills
> Priority: Minor
>
> This is a discussion ticket, and I'm really only making it to track the discussion at the moment.
> Alexey and I had a discussion regarding this, and I thought it would be useful to open this and get other feedback.
> Currently, when an embedded host controller is started with an empty config, a partial domain controller start is performed and then paused until the /host=foo:add command is issued.
> In the case that the HC is being started programatically it seems desirable to be able to check this step has been completed.
> Using the command from the CLI / inside a cli script doesn't have this problem as the CLI waits for the response before continuuing.
> Some clients poll on the /host=foo:host-status attribute, this isn't present until a host has been actually added though.
> the existing options are:
> (a) Like the CLI, just wait until the operation completes. I think this should currently always work.
> (b) Poll on the existence of the /host resource. If this is registered, then you can safely try to add your host (after all there may already be one.)
> Since the host hasn't been added, it doesn't make a lot of sense to provided a default status, as theres no /host=foo to hold the attribute.
> Other thoughts? Personally I'm a fan of (a). And I think that should always be sufficient. I'm not really sure what the programmatic expectations are for using ops like this are in general. Is behavior always assumed to be synchronous, so the end client doesn't need to poll or wait etc?
> [~aloubyansky] Feel free to comment and correct me if I was inaccurate about something.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 8 months
[JBoss JIRA] (WFCORE-3655) Improve embedded HC started with empty config state reporting?
by Brian Stansberry (JIRA)
[ https://issues.jboss.org/browse/WFCORE-3655?page=com.atlassian.jira.plugi... ]
Brian Stansberry commented on WFCORE-3655:
------------------------------------------
I don't know all the details of this, but my instinct is this needs to be more generic.
Some context: The server launch needs to be asynchronous from the thread that does the launch so that thread has the ability to terminate the server if it hangs during boot.
Because it's asynchronous, right now in the CLI that calling thread is polling (with a timeout) checking for the value of an address+attribute combo (differs with a server vs an HC). That polling needs special error handling etc. It's about 40 LOC in EmbedServerHandler, about the same in EmbedHostControllerHandler. And since it's based on reading a particular attribute it can't work with an empty host config.
It would be better if EmbeddedManagedProcess offered a simple API for this kind of wait. The impl of that can directly look at the ControlledProcessState; it doesn't need to care about particular address+attribute combos that might not exist. This wait would also be useful when handling reload.
Note that afaict the current CLI EmbedHostControllerHandler has a race when emptyHost==true. The embed-host-controller command returns and the client is therefore available, but the boot may not have reached RUNNING state. If the CLI user attempts to use the client it may get failed operations.
> Improve embedded HC started with empty config state reporting?
> --------------------------------------------------------------
>
> Key: WFCORE-3655
> URL: https://issues.jboss.org/browse/WFCORE-3655
> Project: WildFly Core
> Issue Type: Enhancement
> Reporter: Ken Wills
> Assignee: Ken Wills
> Priority: Minor
>
> This is a discussion ticket, and I'm really only making it to track the discussion at the moment.
> Alexey and I had a discussion regarding this, and I thought it would be useful to open this and get other feedback.
> Currently, when an embedded host controller is started with an empty config, a partial domain controller start is performed and then paused until the /host=foo:add command is issued.
> In the case that the HC is being started programatically it seems desirable to be able to check this step has been completed.
> Using the command from the CLI / inside a cli script doesn't have this problem as the CLI waits for the response before continuuing.
> Some clients poll on the /host=foo:host-status attribute, this isn't present until a host has been actually added though.
> the existing options are:
> (a) Like the CLI, just wait until the operation completes. I think this should currently always work.
> (b) Poll on the existence of the /host resource. If this is registered, then you can safely try to add your host (after all there may already be one.)
> Since the host hasn't been added, it doesn't make a lot of sense to provided a default status, as theres no /host=foo to hold the attribute.
> Other thoughts? Personally I'm a fan of (a). And I think that should always be sufficient. I'm not really sure what the programmatic expectations are for using ops like this are in general. Is behavior always assumed to be synchronous, so the end client doesn't need to poll or wait etc?
> [~aloubyansky] Feel free to comment and correct me if I was inaccurate about something.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 8 months
[JBoss JIRA] (WFCORE-3652) insufficient privileges with security manager causes tests to fail
by Jeff Mesnil (JIRA)
[ https://issues.jboss.org/browse/WFCORE-3652?page=com.atlassian.jira.plugi... ]
Jeff Mesnil updated WFCORE-3652:
--------------------------------
Fix Version/s: 4.0.0.CR2
(was: 4.0.0.CR1)
> insufficient privileges with security manager causes tests to fail
> ------------------------------------------------------------------
>
> Key: WFCORE-3652
> URL: https://issues.jboss.org/browse/WFCORE-3652
> Project: WildFly Core
> Issue Type: Task
> Components: Remoting
> Reporter: Scott Marlow
> Assignee: David Lloyd
> Fix For: 4.0.0.CR2
>
>
> Please address below failure that we get during testing:
> {code}
> Caused by: java.security.AccessControlException: WFSM000001: Permission check failed (permission "("java.lang.RuntimePermission" "accessDeclaredMembers")" in code source "(vfs:/content/ejb3_sec_permsxml.ear/ejb3_sec_permsxml_client.jar <no signer certificates>)" of "ModuleClassLoader for Module "deployment.ejb3_sec_permsxml.ear.ejb3_sec_permsxml_client.jar" from Service Module Loader")
> \u001b[0m\u001b[0m11:18:48,855 INFO [stdout] (Thread-189) at org.wildfly.security.manager.WildFlySecurityManager.checkPermission(WildFlySecurityManager.java:295)
> \u001b[0m\u001b[0m11:18:48,855 INFO [stdout] (Thread-189) at org.wildfly.security.manager.WildFlySecurityManager.checkPermission(WildFlySecurityManager.java:192)
> \u001b[0m\u001b[0m11:18:48,855 INFO [stdout] (Thread-189) at java.lang.Class.checkMemberAccess(Class.java:2348)
> \u001b[0m\u001b[0m11:18:48,856 INFO [stdout] (Thread-189) at java.lang.Class.getDeclaredField(Class.java:2067)
> \u001b[0m\u001b[0m11:18:48,856 INFO [stdout] (Thread-189) at org.jboss.marshalling.river.RiverUnmarshaller.<clinit>(RiverUnmarshaller.java:106)
> \u001b[0m\u001b[0m11:18:48,856 INFO [stdout] (Thread-189) ... 40 more
> {code}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 8 months
[JBoss JIRA] (WFCORE-3579) ERROR log occurs during CLI reload operation on server
by Jeff Mesnil (JIRA)
[ https://issues.jboss.org/browse/WFCORE-3579?page=com.atlassian.jira.plugi... ]
Jeff Mesnil updated WFCORE-3579:
--------------------------------
Fix Version/s: 4.0.0.CR2
(was: 4.0.0.CR1)
> ERROR log occurs during CLI reload operation on server
> ------------------------------------------------------
>
> Key: WFCORE-3579
> URL: https://issues.jboss.org/browse/WFCORE-3579
> Project: WildFly Core
> Issue Type: Bug
> Components: CLI, Domain Management
> Affects Versions: 4.0.0.Alpha9
> Reporter: Marek Kopecký
> Assignee: Brian Stansberry
> Priority: Blocker
> Fix For: 4.0.0.CR2
>
> Attachments: cli.script.txt
>
>
> *Description of the issue:*
> ERROR log occurs during CLI reload operation on server:
> {{ERROR \[org.jboss.as.controller.management-operation\] (pool-3-thread-2) WFLYCTL0013: Operation ("read-attribute") failed - address: (\[("host" => "master")\]) - failure description: "WFLYCTL0201: Unknown attribute 'host-state'"}}
> This issue is regression against WF11
> Reload handler and its "host-state" code is [here|https://github.com/wildfly/wildfly-core/blob/master/cli/src/main/jav...], but this issue is probably caused by some "debug -> error" logging change ...
> I'm able to reproduce this only on embedded server. Non-embedded server is probably too slow to hit this issue
> *How reproducible:*
> I see this intermittently on fast virtual machines
> *Steps to Reproduce:*
> # ./jboss-cli.sh --file=cli.script.txt
> *Content of cli.script.txt file*
> This file is attached to this jira, beginning of this file:
> {noformat}
> embed-host-controller --std-out=echo
> reload --host=master --admin-only=true
> reload --host=master --admin-only=true
> reload --host=master --admin-only=true
> reload --host=master --admin-only=true
> reload --host=master --admin-only=true
> reload --host=master --admin-only=true
> reload --host=master --admin-only=true
> {noformat}
> *Actual results:*
> Standard output:
> {noformat}
> ...
> [0m[0m01:36:06,021 INFO [org.jboss.as] (MSC service thread 1-1) WFLYSRV0049: WildFly Full 12.0.0.Alpha1-SNAPSHOT (WildFly Core 4.0.0.Alpha9) starting
> [0m[31m01:36:06,061 ERROR [org.jboss.as.controller.management-operation] (CLI command executor) WFLYCTL0013: Operation ("read-attribute") failed - address: ([("host" => "master")]) - failure description: "WFLYCTL0201: Unknown attribute 'host-state'"
> [0m[0m01:36:06,072 INFO [org.jboss.as.controller.management-deprecated] (Controller Boot Thread) WFLYCTL0028: Attribute 'security-realm' in the resource at address '/host=master/core-service=management/management-interface=native-interface' is deprecated, and may be removed in a future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation.
> [0m[0m01:36:06,073 INFO [org.jboss.as.controller.management-deprecated] (Controller Boot Thread) WFLYCTL0028: Attribute 'security-realm' in the resource at address '/host=master/core-service=management/management-interface=http-interface' is deprecated, and may be removed in a future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation.
> [0m[0m01:36:06,097 INFO [org.jboss.as.patching] (MSC service thread 1-3) WFLYPAT0050: WildFly Full cumulative patch ID is: base, one-off patches include: none
> [0m[33m01:36:06,102 WARN [org.jboss.as.domain.management.security] (MSC service thread 1-1) WFLYDM0111: Keystore /home/hudson/hudson_workspace/workspace/early-testing-cli-embedded-manual/4b767fc2/wildfly/domain/configuration/application.keystore not found, it will be auto generated on first use with a self signed certificate for host localhost
> [0m[0m01:36:06,185 INFO [org.jboss.as.controller.management-deprecated] (Controller Boot Thread) WFLYCTL0028: Attribute 'security-realm' in the resource at address '/profile=default/subsystem=undertow/server=default-server/https-listener=https' is deprecated, and may be removed in a future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation.
> [0m[0m01:36:06,196 INFO [org.jboss.as.controller.management-deprecated] (Controller Boot Thread) WFLYCTL0028: Attribute 'security-realm' in the resource at address '/profile=ha/subsystem=undertow/server=default-server/https-listener=https' is deprecated, and may be removed in a future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation.
> [0m[0m01:36:06,204 INFO [org.jboss.as.controller.management-deprecated] (Controller Boot Thread) WFLYCTL0028: Attribute 'security-realm' in the resource at address '/profile=full/subsystem=undertow/server=default-server/https-listener=https' is deprecated, and may be removed in a future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation.
> [0m[0m01:36:06,217 INFO [org.jboss.as.controller.management-deprecated] (Controller Boot Thread) WFLYCTL0028: Attribute 'security-realm' in the resource at address '/profile=full-ha/subsystem=undertow/server=default-server/https-listener=https' is deprecated, and may be removed in a future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation.
> [0m[0m01:36:06,287 INFO [org.jboss.as] (Controller Boot Thread) WFLYSRV0025: WildFly Full 12.0.0.Alpha1-SNAPSHOT (WildFly Core 4.0.0.Alpha9) (Host Controller) started in 266ms - Started 54 of 59 services (18 services are lazy, passive or on-demand)
> ...
> {noformat}
> *Expected results:*
> No errors in logs
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 8 months
[JBoss JIRA] (WFCORE-2235) Intermittent module loading failure in InterdependentDeploymentTestCase
by Jeff Mesnil (JIRA)
[ https://issues.jboss.org/browse/WFCORE-2235?page=com.atlassian.jira.plugi... ]
Jeff Mesnil updated WFCORE-2235:
--------------------------------
Fix Version/s: 4.0.0.CR2
(was: 4.0.0.CR1)
> Intermittent module loading failure in InterdependentDeploymentTestCase
> -----------------------------------------------------------------------
>
> Key: WFCORE-2235
> URL: https://issues.jboss.org/browse/WFCORE-2235
> Project: WildFly Core
> Issue Type: Bug
> Components: Modules, Server
> Affects Versions: 4.0.0.Alpha6
> Reporter: Brian Stansberry
> Assignee: Richard Opalka
> Fix For: 4.0.0.CR2
>
> Attachments: WFCORE-2235svcdump.txt
>
>
> InterdependentDeploymentTestCase tests deployment handling of a set of interdependent deployments, where some of the dependencies are optional.
> The test intermittently fails due to a ModuleLoadException while deploying one of the modules:
> https://ci.wildfly.org/viewLog.html?buildId=42957&buildTypeId=WildFlyCore...
> The most notable bit of info in the log is:
> {code}
> 17:32:08,639 ERROR [org.jboss.msc.service.fail] (MSC service thread 1-2) MSC000001: Failed to start service jboss.module.service."deployment.interrelated-c.jar".main: org.jboss.msc.service.StartException in service jboss.module.service."deployment.interrelated-c.jar".main: WFLYSRV0179: Failed to load module: deployment.interrelated-c.jar
> at org.jboss.as.server.moduleservice.ModuleLoadService.start(ModuleLoadService.java:91)
> at org.jboss.msc.service.ServiceControllerImpl$StartTask.startService(ServiceControllerImpl.java:2032)
> at org.jboss.msc.service.ServiceControllerImpl$StartTask.run(ServiceControllerImpl.java:1955)
> at org.jboss.msc.service.MSCExecutor$1.run(MSCExecutor.java:77)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> Caused by: org.jboss.modules.ModuleNotFoundException: deployment.interrelated-c.jar
> at org.jboss.modules.ModuleLoader$FutureModule.getModule(ModuleLoader.java:834)
> at org.jboss.modules.ModuleLoader.loadModuleLocal(ModuleLoader.java:472)
> at org.jboss.modules.ModuleLoader.loadModuleLocal(ModuleLoader.java:457)
> at org.jboss.modules.ModuleLoader.preloadModule(ModuleLoader.java:370)
> at org.jboss.as.server.moduleservice.ServiceModuleLoader.preloadModule(ServiceModuleLoader.java:147)
> at org.jboss.modules.ModuleLoader.preloadModule(ModuleLoader.java:387)
> at org.jboss.modules.ModuleLoader.loadModule(ModuleLoader.java:282)
> at org.jboss.modules.ModuleLoader.loadModule(ModuleLoader.java:270)
> at org.jboss.as.server.moduleservice.ModuleLoadService.start(ModuleLoadService.java:68)
> ... 6 more
> {code}
> The interrelated-c.jar deployment depends (*not optionally*) on interrelated-a.jar.The failure occurs during execution of a management op that redeploys interrelated-a.jar. FWIW, another deployment in the set, interrelated-f.jar, does depend optionally on interrelated-c.jar.
> The full stdout output for the failed test in the above linked CI run also includes a dump of all MSC services following the failure. Note though that the failure does not result in MSC not obtaining stability. Inability to reach stability was the initial problem that led to the introduction of this test (see https://github.com/wildfly/wildfly-core/pull/2099.)
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 8 months
[JBoss JIRA] (WFCORE-3656) Replace commons-logging implementation with one that can delegate to jboss-logging
by James Perkins (JIRA)
James Perkins created WFCORE-3656:
-------------------------------------
Summary: Replace commons-logging implementation with one that can delegate to jboss-logging
Key: WFCORE-3656
URL: https://issues.jboss.org/browse/WFCORE-3656
Project: WildFly Core
Issue Type: Bug
Components: Logging
Reporter: James Perkins
Assignee: James Perkins
Fix For: 5.0.0.Alpha1
The current Apache Commons Logging implementation delegates to the JBoss Log Manager. This can be a problem for embedded servers where the JBoss Log Manager may not be used. We should have an implementation that writes to JBoss Logging. This will allow any log manager that JBoss Logging supports to be used.
This is currently blocking provisioning from working with the embedded server API.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 8 months