[ http://jira.jboss.com/jira/browse/JBREM-542?page=comments#action_12339633 ] Tom Elrod commented on JBREM-542: ---------------------------------- The org.jboss.remoting.transport.servlet.web.ServerInvokerServlet has been changed so that instead of looking for the 'invokerName' init-param, will now look for 'locatorUrl'. The value of the locatorUrl param should be the invoker locator url of the servlet server invoker. An example of the web.xml configuration within servlet-invoker.war/WEB-INF/web.xml would be: <?xml version="1.0" encoding="UTF-8"?> <!DOCTYPE web-app PUBLIC "-//Sun Microsystems, Inc.//DTD Web Application 2.3//EN" "http://java.sun.com/dtd/web-app_2_3.dtd"> <!-- The the JBossRemoting server invoker servlet web.xml descriptor $Id: web.xml,v 1.1 2005/06/16 21:12:48 telrod Exp $ --> <web-app> <servlet> <servlet-name>ServerInvokerServlet</servlet-name> <description>The ServerInvokerServlet receives requests via HTTP protocol from within a web container and passes it onto the ServletServerInvoker for processing. </description> <servlet-class>org.jboss.remoting.transport.servlet.web.ServerInvokerServlet</servlet-class> <init-param> <param-name>locatorUrl</param-name> <param-value>servlet://localhost:8080/servlet-invoker/ServerInvokerServlet</param-value> <description>The servlet server invoker locator url</description> </init-param> <load-on-startup>1</load-on-startup> </servlet> <servlet-mapping> <servlet-name>ServerInvokerServlet</servlet-name> <url-pattern>/ServerInvokerServlet/*</url-pattern> </servlet-mapping> </web-app> And the service xml for deploying the servlet server invoker would look something like: <?xml version="1.0" encoding="UTF-8"?> <server> <mbean code="org.jboss.remoting.transport.Connector" name="jboss.remoting:service=Connector,transport=SSLServlet" display-name="Servlet transport Connector"> <attribute name="InvokerLocator"> servlet://localhost:8080/servlet-invoker/ServerInvokerServlet </attribute> <attribute name="Configuration"> <config> <handlers> <handler subsystem="test">org.jboss.test.remoting.transport.web.WebInvocationHandler</handler> </handlers> </config> </attribute> </mbean> </server> -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBREM-542?page=comments#action_12339638 ] Tom Elrod commented on JBREM-542: ---------------------------------- BTW, this will make servlet invoker portable to other web containers and app servers. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBREM-542?page=comments#action_12339646 ] John Mazzitelli commented on JBREM-542: --------------------------------------- I just rebuilt from HEAD and output/lib/servlet-invoker.war still has the old web.xml with the invokerName param. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBREM-542?page=all ] John Mazzitelli reopened JBREM-542: ----------------------------------- Tom - can I ask that this be re-opened and the "old" way of specifying locatorName re-introduced. You can leave this new way (locatorUrl) also supported, but I would also like to use the locatorName and NOT the locator URL. Here's why I need it back in. Suppose I'm writing a server app that I distribute to my customers. I pre-package a JBossAS server and I bundle this war in it. I ship it to my customers that they unzip and run. If you force me to configure this servlet with the locator URL, my customers will be forced to go into this web.xml and modify it so it matches their hostname in the URL (they would need to change "localhost" to their hostname or IP) - same with the port. That or I need to write an "installer" script that auto-modifies this web.xml. But no matter what, if the customer ever changes the hostname or IP of the box, they will be forced to change the web.xml (they would first have to KNOW to do this and remember to do it). The original way you had it, the web.xml didn't have to change - the JMX ObjectName was always the same. I just took the stock web.xml that came out of the Remoting build and it works across any machine - whether or not the port was on 8080 or the bind address was localhost. Before you say, "ah... but you'd still have the jboss-service.xml <mbean> for the Connector that you'd have to change with that information" - In my use case, I don't have a <mbean> that directly installs a Connector. I have my own custom bootstrap <mbean> that installs my Connector in a custom way. It does this by reading a configuration file that my customers will have full control over (all the configuration will be here, just not this connector stuff). It is THIS configuration file that the customer will specify things like what the hostname or port number will be - I don't want the customer to have to modify any jboss-service.xml or web.xml file, I only want them touching this custom config file. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBREM-542?page=all ] Tom Elrod resolved JBREM-542. ------------------------------ Resolution: Done I have put back in the ability to us 'invokerName' param as well as the 'locatorUrl' (which is basically a copy of the patch provided. Only change is to not use the JBoss jmx implementation specific MBeanServerLocator. So is going to still require the servlet have access to jmx classes, but at least won't have to be the jboss specific implementation now (in the case they are using jdk 1.5 implementation). Since the Connector also requires jmx implementation classes (due to imports), this seems acceptable requirements. Also the point about not having to change config out of the box is a compelling one. web.xml config can now be: <?xml version="1.0" encoding="UTF-8"?> <!DOCTYPE web-app PUBLIC "-//Sun Microsystems, Inc.//DTD Web Application 2.3//EN" "http://java.sun.com/dtd/web-app_2_3.dtd"> <!-- The the JBossRemoting server invoker servlet web.xml descriptor $Id: web.xml,v 1.2 2006/07/17 03:44:00 telrod Exp $ --> <web-app> <servlet> <servlet-name>ServerInvokerServlet</servlet-name> <description>The ServerInvokerServlet receives requests via HTTP protocol from within a web container and passes it onto the ServletServerInvoker for processing. </description> <servlet-class>org.jboss.remoting.transport.servlet.web.ServerInvokerServlet</servlet-class> <init-param> <param-name>invokerName</param-name> <param-value>jboss.remoting:service=invoker,transport=servlet</param-value> <description>The servlet server invoker</description> <!-- <param-name>locatorUrl</param-name> <param-value>servlet://localhost:8080/servlet-invoker/ServerInvokerServlet</param-value> <description>The servlet server invoker locator url</description> --> </init-param> <load-on-startup>1</load-on-startup> </servlet> <servlet-mapping> <servlet-name>ServerInvokerServlet</servlet-name> <url-pattern>/ServerInvokerServlet/*</url-pattern> </servlet-mapping> </web-app> where can swap out the 'invokerName' and 'locatorUrl' params. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira