[JBoss JIRA] (JBRULES-3257) MarshallerWriteContext.objectMarshallingStrategyStore contains an unpredictable list of ObjectMarshallingStrategy objects which can break WorkItemInfo unmarshalling (wrt backwards compatibility)
by Marco Rietveld (Created) (JIRA)
MarshallerWriteContext.objectMarshallingStrategyStore contains an unpredictable list of ObjectMarshallingStrategy objects which can break WorkItemInfo unmarshalling (wrt backwards compatibility)
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Key: JBRULES-3257
URL: https://issues.jboss.org/browse/JBRULES-3257
Project: Drools
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: drools-core
Affects Versions: 5.3.0.Beta1, 5.2.0.Final, 5.4.0.Beta1
Reporter: Marco Rietveld
Assignee: Marco Rietveld
Priority: Minor
Fix For: 5.4.0.Beta1
The reason that this is a minor bug is that the user can always fix this by putting the proper ObjectMarshallingStrategy instance into the environment passed to the object doing the unmarshaller.
The following code is where the bug is (see second comment):
{code}
public static void writeWorkItem(MarshallerWriteContext context,
WorkItem workItem) throws IOException {
// ... other code
for ( String key : parameters.keySet() ) {
Object object = parameters.get( key );
if ( object != null ) {
stream.writeUTF( key );
// Next 2 lines: we store the _index_ of the ObjectMarshallingStrategy object in the stream
int index = context.objectMarshallingStrategyStore.getStrategy( object );*
stream.writeInt( index );*
ObjectMarshallingStrategy strategy = context.objectMarshallingStrategyStore.getStrategy( index );
if ( strategy.accept( object ) ) {
strategy.write( stream,
object );
}
}
}
}
{code}
The logic used above is also used when serializing the FactHandle (see here: [OutputMarshaller (most recent commit)|https://github.com/droolsjbpm/drools/blob/0dc2ef742078138e8747b17...
When the marshalled (WorkItem) data is unmarshalled, the {{context.objectMarshallingStrategyStore}} must contain at least the same set of ObjectMarshallingStrategy objects that were used when the WorkItem object was marshalled.
----
Instead of using the _index_ of the class, my proposed solution is to use the class name, and throw a descriptive exception when the ObjectMarshallingStrategy object sought, can not be found.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
14 years, 1 month
[JBoss JIRA] Created: (AS7-1931) Unable to configure more than one pooled-connection-factory in the messaging subsystem
by Vincent MATHON (JIRA)
Unable to configure more than one pooled-connection-factory in the messaging subsystem
--------------------------------------------------------------------------------------
Key: AS7-1931
URL: https://issues.jboss.org/browse/AS7-1931
Project: Application Server 7
Issue Type: Bug
Affects Versions: 7.0.2.Final, 7.0.1.Final, 7.0.0.Final
Environment: Windows7, sun jdk 1.6_25
Reporter: Vincent MATHON
Adding another pooled connection factory in the standalone-preview.xml file provided by any of the 7.0.x.Final releases as follow
<pooled-connection-factory name="hornetq-ra">
<transaction mode="xa"/>
<connectors>
<connector-ref connector-name="in-vm"/>
</connectors>
<entries>
<entry name="java:/JmsXA"/>
</entries>
</pooled-connection-factory>
<pooled-connection-factory name="hornetq-ra-nonxa">
<transaction mode="local"/>
<connectors>
<connector-ref connector-name="in-vm"/>
</connectors>
<entries>
<entry name="java:/JmsNonXA"/>
</entries>
</pooled-connection-factory>
leads to the following exception:
12:44:31,621 ERROR [org.jboss.msc.service.fail] (MSC service thread 1-2) MSC00001: Failed to start service jboss.messaging.pooled-connection-factory.hornetq-ra-nonxa: org.jboss.msc.service.StartException in service jboss.messaging.pooled-connection-factory.hornetq-ra-nonxa: failed to create resource adapter
at org.jboss.as.messaging.jms.PooledConnectionFactoryService.start(PooledConnectionFactoryService.java:174)
at org.jboss.msc.service.ServiceControllerImpl$StartTask.startService(ServiceControllerImpl.java:1824)
at org.jboss.msc.service.ServiceControllerImpl$StartTask.run(ServiceControllerImpl.java:1759)
at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) [:1.6.0_25]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) [:1.6.0_25]
at java.lang.Thread.run(Thread.java:662) [:1.6.0_25]
Caused by: org.jboss.msc.service.DuplicateServiceException: Service jboss.raactivator is already registered
at org.jboss.msc.service.ServiceRegistrationImpl.setInstance(ServiceRegistrationImpl.java:154)
at org.jboss.msc.service.ServiceControllerImpl.startInstallation(ServiceControllerImpl.java:226)
at org.jboss.msc.service.ServiceContainerImpl.install(ServiceContainerImpl.java:560)
at org.jboss.msc.service.ServiceTargetImpl.install(ServiceTargetImpl.java:201)
at org.jboss.msc.service.ServiceControllerImpl$ChildServiceTarget.install(ServiceControllerImpl.java:2211)
at org.jboss.msc.service.ServiceBuilderImpl.install(ServiceBuilderImpl.java:307)
at org.jboss.as.messaging.jms.PooledConnectionFactoryService.createService(PooledConnectionFactoryService.java:232)
at org.jboss.as.messaging.jms.PooledConnectionFactoryService.start(PooledConnectionFactoryService.java:172)
... 5 more
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
14 years, 1 month
[JBoss JIRA] (AS7-2267) The Console logs the DMR commands
by Rich Raposa (Created) (JIRA)
The Console logs the DMR commands
---------------------------------
Key: AS7-2267
URL: https://issues.jboss.org/browse/AS7-2267
Project: Application Server 7
Issue Type: Feature Request
Reporter: Rich Raposa
It would be nice if changes made to the configuration file via the Console were logged in DMR format so that the commands could be executed as a CLI script.
A simpler option would be to provide a link next to a resource that shows the CLI command you would use to create that resource. For example, in the list of datasources on the Datasources Configuration tab, next to each datasource would be a link that would contain the CLI command for defining that datasource.
The use case is this: I can take advantage of the ease-of-use of the Console to define a resource, then copy-and-paste the CLI command to define a script so that the resource can be defined over and over again on all of my EAP deployments.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
14 years, 1 month