[JBoss JIRA] (JGRP-2011) Rsp: optimize in-memory size
by Bela Ban (JIRA)
[ https://issues.jboss.org/browse/JGRP-2011?page=com.atlassian.jira.plugin.... ]
Bela Ban updated JGRP-2011:
---------------------------
Description:
The in-memory size of {{Rsp}} can be made smaller. Currently, it looks like this:
{noformat}
public class Rsp {
protected boolean received;
protected boolean suspected;
protected boolean unreachable;
protected final Address sender;
protected T retval;
protected Throwable exception;
}
{noformat}
Optimizations:
# received, suspected and unreachable can be compacted into a byte field (flags)
# retval and exception can be merged into {{Object value}}
# sender can be removed: {{RspList}} already has the sender
New format:
{noformat}
public class Rsp {
protected byte flags;
protected Object value;
}
{noformat}
Size of {{Rsp}} is 32 bytes (used JOL to measure) before, and 24 bytes after the changes.
was:
The in-memory size of {{Rsp}} can be made smaller. Currently, it looks like this:
{noformat}
public class Rsp {
protected boolean received;
protected boolean suspected;
protected boolean unreachable;
protected final Address sender;
protected T retval;
protected Throwable exception;
}
{noformat}
Optimizations:
# received, suspected and unreachable can be compacted into a byte field (flags)
# retval and exception can be merged into {{Object value}}
# sender can be removed: {{RspList}} already has the sender
New format:
{noformat}
public class Rsp {
protected byte flags;
protected Object value;
}
{noformat}
Size of {{Rsp}} is 32 bytes (used JOL to measure) before, and 24 bytes after the changes.
> Rsp: optimize in-memory size
> ----------------------------
>
> Key: JGRP-2011
> URL: https://issues.jboss.org/browse/JGRP-2011
> Project: JGroups
> Issue Type: Enhancement
> Reporter: Bela Ban
> Assignee: Bela Ban
> Priority: Minor
> Fix For: 3.6.8, 4.0
>
>
> The in-memory size of {{Rsp}} can be made smaller. Currently, it looks like this:
> {noformat}
> public class Rsp {
> protected boolean received;
> protected boolean suspected;
> protected boolean unreachable;
> protected final Address sender;
> protected T retval;
> protected Throwable exception;
> }
> {noformat}
> Optimizations:
> # received, suspected and unreachable can be compacted into a byte field (flags)
> # retval and exception can be merged into {{Object value}}
> # sender can be removed: {{RspList}} already has the sender
> New format:
> {noformat}
> public class Rsp {
> protected byte flags;
> protected Object value;
> }
> {noformat}
> Size of {{Rsp}} is 32 bytes (used JOL to measure) before, and 24 bytes after the changes.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 4 months
[JBoss JIRA] (JGRP-1605) API changes
by Bela Ban (JIRA)
[ https://issues.jboss.org/browse/JGRP-1605?page=com.atlassian.jira.plugin.... ]
Bela Ban updated JGRP-1605:
---------------------------
Description:
API changes to be done in 4.0, which break code:
* MessageDispatcher: remove MessageListener
* Merge AsyncRequestHandler and RequestHandler, OR make them 2 separate interfaces, ie. AsyncRH doesn't extend RH
* DONE: Remove @Deprecated methods, properties or classes
* Remove direct access to Message in JChannel.send() methods (to prevent passing in the same message more than once)
* Make {{RspFilter}} --> {{RspFilter<T>}}
* {{ProtocolStack.findProtocol(Class<?> clazz)}} should return generic type {{<T extends Protocol>>}}, so no casting is needed. Requires changes to a number of methods in the same class.
* Request<T>
* RpcDispatcher: only 1 Marshaller, not separate ones for reqs and rsps
* RpcDispatcher: use CompletableFuture instead of NotifiyingFuture
* Rsp: see https://issues.jboss.org/browse/JGRP-2011
was:
API changes to be done in 4.0, which break code:
* MessageDispatcher: remove MessageListener
* Merge AsyncRequestHandler and RequestHandler, OR make them 2 separate interfaces, ie. AsyncRH doesn't extend RH
* DONE: Remove @Deprecated methods, properties or classes
* Remove direct access to Message in JChannel.send() methods (to prevent passing in the same message more than once)
* Make {{RspFilter}} --> {{RspFilter<T>}}
* {{ProtocolStack.findProtocol(Class<?> clazz)}} should return generic type {{<T extends Protocol>>}}, so no casting is needed. Requires changes to a number of methods in the same class.
* Request<T>
* RpcDispatcher: only 1 Marshaller, not separate ones for reqs and rsps
* RpcDispatcher: use CompletableFuture instead of NotifiyingFuture
* Rsp:
** Club {{received}}, {{suspected}}, {{unreachable}} into 1 boolean field, use 1 field for result/exception
** Remove {{sender}}
> API changes
> -----------
>
> Key: JGRP-1605
> URL: https://issues.jboss.org/browse/JGRP-1605
> Project: JGroups
> Issue Type: Task
> Reporter: Bela Ban
> Assignee: Bela Ban
> Fix For: 4.0
>
>
> API changes to be done in 4.0, which break code:
> * MessageDispatcher: remove MessageListener
> * Merge AsyncRequestHandler and RequestHandler, OR make them 2 separate interfaces, ie. AsyncRH doesn't extend RH
> * DONE: Remove @Deprecated methods, properties or classes
> * Remove direct access to Message in JChannel.send() methods (to prevent passing in the same message more than once)
> * Make {{RspFilter}} --> {{RspFilter<T>}}
> * {{ProtocolStack.findProtocol(Class<?> clazz)}} should return generic type {{<T extends Protocol>>}}, so no casting is needed. Requires changes to a number of methods in the same class.
> * Request<T>
> * RpcDispatcher: only 1 Marshaller, not separate ones for reqs and rsps
> * RpcDispatcher: use CompletableFuture instead of NotifiyingFuture
> * Rsp: see https://issues.jboss.org/browse/JGRP-2011
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 4 months
[JBoss JIRA] (JGRP-2011) Rsp: optimize in-memory size
by Bela Ban (JIRA)
[ https://issues.jboss.org/browse/JGRP-2011?page=com.atlassian.jira.plugin.... ]
Bela Ban updated JGRP-2011:
---------------------------
Description:
The in-memory size of {{Rsp}} can be made smaller. Currently, it looks like this:
{noformat}
public class Rsp {
protected boolean received;
protected boolean suspected;
protected boolean unreachable;
protected final Address sender;
protected T retval;
protected Throwable exception;
}
{noformat}
Optimizations:
# received, suspected and unreachable can be compacted into a byte field (flags)
# retval and exception can be merged into {{Object value}}
# sender can be removed: {{RspList}} already has the sender
New format:
{noformat}
public class Rsp {
protected byte flags;
protected Object value;
}
{noformat}
Size of {{Rsp}} is 32 bytes (used JOL to measure) before, and 24 bytes after the changes.
was:
The in-memory size of {{Rsp}} can be made smaller. Currently, it looks like this:
{noformat}
public class Rsp {
protected boolean received;
protected boolean suspected;
protected boolean unreachable;
protected final Address sender;
protected T retval;
protected Throwable exception;
}
{noformat}
Optimizations:
# received, suspected and unreachable can be compacted into a byte field (flags)
# retval and exception can be merged into {{Object value}}
# sender can be removed: {{RspList}} already has the sender
Size of {{Rsp}} is 32 bytes (used JOL to measure) before, and 24 bytes after the changes.
> Rsp: optimize in-memory size
> ----------------------------
>
> Key: JGRP-2011
> URL: https://issues.jboss.org/browse/JGRP-2011
> Project: JGroups
> Issue Type: Enhancement
> Reporter: Bela Ban
> Assignee: Bela Ban
> Priority: Minor
> Fix For: 3.6.8, 4.0
>
>
> The in-memory size of {{Rsp}} can be made smaller. Currently, it looks like this:
> {noformat}
> public class Rsp {
> protected boolean received;
> protected boolean suspected;
> protected boolean unreachable;
> protected final Address sender;
> protected T retval;
> protected Throwable exception;
> }
> {noformat}
> Optimizations:
> # received, suspected and unreachable can be compacted into a byte field (flags)
> # retval and exception can be merged into {{Object value}}
> # sender can be removed: {{RspList}} already has the sender
> New format:
> {noformat}
> public class Rsp {
> protected byte flags;
> protected Object value;
> }
> {noformat}
> Size of {{Rsp}} is 32 bytes (used JOL to measure) before, and 24 bytes after the changes.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 4 months
[JBoss JIRA] (JGRP-2011) Rsp: optimize in-memory size
by Bela Ban (JIRA)
Bela Ban created JGRP-2011:
------------------------------
Summary: Rsp: optimize in-memory size
Key: JGRP-2011
URL: https://issues.jboss.org/browse/JGRP-2011
Project: JGroups
Issue Type: Enhancement
Reporter: Bela Ban
Assignee: Bela Ban
Priority: Minor
Fix For: 3.6.8, 4.0
The in-memory size of {{Rsp}} can be made smaller. Currently, it looks like this:
{noformat}
public class Rsp {
protected boolean received;
protected boolean suspected;
protected boolean unreachable;
protected final Address sender;
protected T retval;
protected Throwable exception;
}
{noformat}
Optimizations:
# received, suspected and unreachable can be compacted into a byte field (flags)
# retval and exception can be merged into {{Object value}}
# sender can be removed: {{RspList}} already has the sender
Size of {{Rsp}} is 32 bytes (used JOL to measure)
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 4 months
[JBoss JIRA] (JGRP-2011) Rsp: optimize in-memory size
by Bela Ban (JIRA)
[ https://issues.jboss.org/browse/JGRP-2011?page=com.atlassian.jira.plugin.... ]
Bela Ban updated JGRP-2011:
---------------------------
Description:
The in-memory size of {{Rsp}} can be made smaller. Currently, it looks like this:
{noformat}
public class Rsp {
protected boolean received;
protected boolean suspected;
protected boolean unreachable;
protected final Address sender;
protected T retval;
protected Throwable exception;
}
{noformat}
Optimizations:
# received, suspected and unreachable can be compacted into a byte field (flags)
# retval and exception can be merged into {{Object value}}
# sender can be removed: {{RspList}} already has the sender
Size of {{Rsp}} is 32 bytes (used JOL to measure) before, and 24 bytes after the changes.
was:
The in-memory size of {{Rsp}} can be made smaller. Currently, it looks like this:
{noformat}
public class Rsp {
protected boolean received;
protected boolean suspected;
protected boolean unreachable;
protected final Address sender;
protected T retval;
protected Throwable exception;
}
{noformat}
Optimizations:
# received, suspected and unreachable can be compacted into a byte field (flags)
# retval and exception can be merged into {{Object value}}
# sender can be removed: {{RspList}} already has the sender
Size of {{Rsp}} is 32 bytes (used JOL to measure)
> Rsp: optimize in-memory size
> ----------------------------
>
> Key: JGRP-2011
> URL: https://issues.jboss.org/browse/JGRP-2011
> Project: JGroups
> Issue Type: Enhancement
> Reporter: Bela Ban
> Assignee: Bela Ban
> Priority: Minor
> Fix For: 3.6.8, 4.0
>
>
> The in-memory size of {{Rsp}} can be made smaller. Currently, it looks like this:
> {noformat}
> public class Rsp {
> protected boolean received;
> protected boolean suspected;
> protected boolean unreachable;
> protected final Address sender;
> protected T retval;
> protected Throwable exception;
> }
> {noformat}
> Optimizations:
> # received, suspected and unreachable can be compacted into a byte field (flags)
> # retval and exception can be merged into {{Object value}}
> # sender can be removed: {{RspList}} already has the sender
> Size of {{Rsp}} is 32 bytes (used JOL to measure) before, and 24 bytes after the changes.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 4 months
[JBoss JIRA] (JGRP-1605) API changes
by Bela Ban (JIRA)
[ https://issues.jboss.org/browse/JGRP-1605?page=com.atlassian.jira.plugin.... ]
Bela Ban updated JGRP-1605:
---------------------------
Description:
API changes to be done in 4.0, which break code:
* MessageDispatcher: remove MessageListener
* Merge AsyncRequestHandler and RequestHandler, OR make them 2 separate interfaces, ie. AsyncRH doesn't extend RH
* DONE: Remove @Deprecated methods, properties or classes
* Remove direct access to Message in JChannel.send() methods (to prevent passing in the same message more than once)
* Make {{RspFilter}} --> {{RspFilter<T>}}
* {{ProtocolStack.findProtocol(Class<?> clazz)}} should return generic type {{<T extends Protocol>>}}, so no casting is needed. Requires changes to a number of methods in the same class.
* Request<T>
* RpcDispatcher: only 1 Marshaller, not separate ones for reqs and rsps
* RpcDispatcher: use CompletableFuture instead of NotifiyingFuture
* Rsp:
** Club {{received}}, {{suspected}}, {{unreachable}} into 1 boolean field, use 1 field for result/exception
** Remove {{sender}}
was:
API changes to be done in 4.0, which break code:
* MessageDispatcher: remove MessageListener
* Merge AsyncRequestHandler and RequestHandler, OR make them 2 separate interfaces, ie. AsyncRH doesn't extend RH
* DONE: Remove @Deprecated methods, properties or classes
* Remove direct access to Message in JChannel.send() methods (to prevent passing in the same message more than once)
* Make {{RspFilter}} --> {{RspFilter<T>}}
* {{ProtocolStack.findProtocol(Class<?> clazz)}} should return generic type {{<T extends Protocol>>}}, so no casting is needed. Requires changes to a number of methods in the same class.
* Request<T>
* RpcDispatcher: only 1 Marshaller, not separate ones for reqs and rsps
* RpcDispatcher: use CompletableFuture instead of NotifiyingFuture
* Rsp:
** Club {{received}}, {{suspected}}, {{unreachable}} into 1 boolean field, use 1 field for result/exception
** Remove {{sender}}
** Remove {{equals()}} and {{hashCode()}}
> API changes
> -----------
>
> Key: JGRP-1605
> URL: https://issues.jboss.org/browse/JGRP-1605
> Project: JGroups
> Issue Type: Task
> Reporter: Bela Ban
> Assignee: Bela Ban
> Fix For: 4.0
>
>
> API changes to be done in 4.0, which break code:
> * MessageDispatcher: remove MessageListener
> * Merge AsyncRequestHandler and RequestHandler, OR make them 2 separate interfaces, ie. AsyncRH doesn't extend RH
> * DONE: Remove @Deprecated methods, properties or classes
> * Remove direct access to Message in JChannel.send() methods (to prevent passing in the same message more than once)
> * Make {{RspFilter}} --> {{RspFilter<T>}}
> * {{ProtocolStack.findProtocol(Class<?> clazz)}} should return generic type {{<T extends Protocol>>}}, so no casting is needed. Requires changes to a number of methods in the same class.
> * Request<T>
> * RpcDispatcher: only 1 Marshaller, not separate ones for reqs and rsps
> * RpcDispatcher: use CompletableFuture instead of NotifiyingFuture
> * Rsp:
> ** Club {{received}}, {{suspected}}, {{unreachable}} into 1 boolean field, use 1 field for result/exception
> ** Remove {{sender}}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 4 months
[JBoss JIRA] (WFCORE-1348) Specify filesystem rights for deployment content
by ehsavoie Hugonnet (JIRA)
[ https://issues.jboss.org/browse/WFCORE-1348?page=com.atlassian.jira.plugi... ]
ehsavoie Hugonnet reassigned WFCORE-1348:
-----------------------------------------
Assignee: ehsavoie Hugonnet (was: Brian Stansberry)
> Specify filesystem rights for deployment content
> ------------------------------------------------
>
> Key: WFCORE-1348
> URL: https://issues.jboss.org/browse/WFCORE-1348
> Project: WildFly Core
> Issue Type: Enhancement
> Components: Domain Management
> Affects Versions: 2.0.10.Final
> Reporter: ehsavoie Hugonnet
> Assignee: ehsavoie Hugonnet
>
> Currently when we add a content to the ContentRepository we are using Files.createTempFile whitout specifying the file attributes. On GNU/Linux this may create a file with only read write rights for the user (and not the group or other). We should change that as this could lead to some strange errors.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 4 months
[JBoss JIRA] (WFCORE-1348) Specify filesystem rights for deployment content
by ehsavoie Hugonnet (JIRA)
ehsavoie Hugonnet created WFCORE-1348:
-----------------------------------------
Summary: Specify filesystem rights for deployment content
Key: WFCORE-1348
URL: https://issues.jboss.org/browse/WFCORE-1348
Project: WildFly Core
Issue Type: Enhancement
Components: Domain Management
Affects Versions: 2.0.10.Final
Reporter: ehsavoie Hugonnet
Assignee: Brian Stansberry
Currently when we add a content to the ContentRepository we are using Files.createTempFile whitout specifying the file attributes. On GNU/Linux this may create a file with only read write rights for the user (and not the group or other). We should change that as this could lead to some strange errors.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 4 months