[JBoss JIRA] Created: (JGRP-457) Optimization: make threads return immediately if NAKACK has another active thread for the same sender
by Bela Ban (JIRA)
Optimization: make threads return immediately if NAKACK has another active thread for the same sender
-----------------------------------------------------------------------------------------------------
Key: JGRP-457
URL: http://jira.jboss.com/jira/browse/JGRP-457
Project: JGroups
Issue Type: Feature Request
Reporter: Bela Ban
Assigned To: Bela Ban
Priority: Minor
Fix For: 2.5
In NAKACK, when a thread places a message for sender S into the NakReceiverWindow NRW, it subsequently acquires a lock on NRW (lock by sender) and removes as many messages as possible and passes them up.
If many threads do this at the same time, all threads but one are blocked, and - when finally unblocked - usually return. This causes context switches and possibly cache flushing, so a better way would be to have the threads check whether another thread is already removing messages using a CAS operation *before* acquiring the lock.
The effect should be that no threads will wait on the lock unnecessarily, and thus fewer context switches, and more threads available to the pool.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1 week, 2 days
[JBoss JIRA] (WFLY-9138) Warning message mistake
by Stuart Douglas (JIRA)
[ https://issues.jboss.org/browse/WFLY-9138?page=com.atlassian.jira.plugin.... ]
Stuart Douglas resolved WFLY-9138.
----------------------------------
Resolution: Duplicate Issue
https://issues.jboss.org/browse/WFLY-7228
> Warning message mistake
> -----------------------
>
> Key: WFLY-9138
> URL: https://issues.jboss.org/browse/WFLY-9138
> Project: WildFly
> Issue Type: Bug
> Components: CDI / Weld
> Affects Versions: 10.1.0.Final
> Reporter: Baturman Şen
> Assignee: Stuart Douglas
> Priority: Trivial
>
> I am not native english speaker but, following warning message should be fixed.
> {panel:title=Original Message}
> 09:52:31,242 WARN [org.jboss.weld.deployer] (MSC service thread 1-5) WFLYWELD0013: Deployment deployment "xxxx" contains CDI annotations but no bean archive was not found. (No beans.xml nor class with bean defining annotations)
> {panel}
> {panel:title=Fixed Message}
> 09:52:31,242 WARN [org.jboss.weld.deployer] (MSC service thread 1-5) WFLYWELD0013: Deployment "xxxx" contains CDI annotations but no bean archive was found. (No beans.xml nor class with bean defining annotations)
> {panel}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 2 months
[JBoss JIRA] (WFCORE-3103) Embedded server doesn't close open file handles
by Brian Stansberry (JIRA)
[ https://issues.jboss.org/browse/WFCORE-3103?page=com.atlassian.jira.plugi... ]
Brian Stansberry reassigned WFCORE-3103:
----------------------------------------
Assignee: Ken Wills (was: Brian Stansberry)
[~luck3y] I'm going to pass this one over to you.
https://github.com/wildfly/wildfly-core/compare/master...bstansberry:WFCO... has my experiment on that, but the testsuite does not pass. To get meaningful behavior with it you have to run with David's jboss-modules branch with the MODULES-301 commit in it.
For sure https://github.com/wildfly/wildfly-core/compare/master...bstansberry:WFCO... or something like it has to happen, otherwise we close the boot module loader which is wrongness. But when I make that change things blow up.
> Embedded server doesn't close open file handles
> -----------------------------------------------
>
> Key: WFCORE-3103
> URL: https://issues.jboss.org/browse/WFCORE-3103
> Project: WildFly Core
> Issue Type: Bug
> Components: CLI, Modules
> Reporter: Jan Blizňák
> Assignee: Ken Wills
>
> When embedded server is started programatically (eg. via CLI wrapper) with specified jboss home, JARs from that path are opened via classloader. But these open handles are never released even after embedded server is stopped.
> This causes problem in situation eg. when you want to delete that jboss home. This is exactly one of the scenarios used in EAP installer, you are not allowed to delete open files on Windows - see JBEAP-1404.
> I created a simple project that reproduce the issue with arbitrary EAP/WF distribution https://github.com/jbliznak/embedded-server-filelocking
> Run it with:
> mvn clean test "-Dwildfly.home=C:\dev\jboss-eap-7.1" "-Denforcer.skip" -Dtest=ModulesFileLockingTestCase
> Manual steps to reproduce in Java code:
> * start a CLI wrapper
> * start embed-server from given server path
> * stop embed-server
> * terminate CLI wrapper
> * try to delete given server path
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 2 months
[JBoss JIRA] (DROOLS-1685) Improve performance of rules using "or" in LHS
by Mario Fusco (JIRA)
[ https://issues.jboss.org/browse/DROOLS-1685?page=com.atlassian.jira.plugi... ]
Mario Fusco commented on DROOLS-1685:
-------------------------------------
The rulesets you pasted are not totally equivalent. In the first one you have
{code}
entity.entityTypeId in ( 291262 )
{code}
while in second
{code}
entity.entityTypeId == 291262
{code}
I think this could make a huge difference performance wise because only the second constraint can be indexed. If your problem persists after having fixed this difference please send a complete reproducer so I could further investigate this problem.
> Improve performance of rules using "or" in LHS
> ----------------------------------------------
>
> Key: DROOLS-1685
> URL: https://issues.jboss.org/browse/DROOLS-1685
> Project: Drools
> Issue Type: Enhancement
> Components: core engine, kie server
> Affects Versions: 6.5.0.Final
> Reporter: Russell Morrisey
> Assignee: Mario Fusco
>
> The following two rulesets produce the same output, but their performance differs dramatically.
> My understanding is that the two rulesets should be equivalent to one another. It seems like the 'or' operation must be handled inefficiently by the engine. Is there anything that can be improved the engine's performance in this case?
> Ruleset #1 takes ~3 seconds to execute on my local machine (for a dataset with 3 entities, 1 service ordered each). Ruleset #2 runs in ~200 ms.
> *Ruleset 1*
> {code:java}
> rule "Rule183"
> dialect "mvel"
> when
> $entity : Entity( )
> ( $service : ServiceOrdered( serviceId == "FORM" , entity == $entity , entity.entityTypeId in ( 291262, 291275, 291277 ) ) or $service : ServiceOrdered( serviceId == "DISSO" , entity == $entity , entity.entityTypeId in ( 291262 ) , stateId == 290864 ) )
> $r1 : QuestionDefinition( id == 590 )
> then
> Question fact0 = new Question();
> fact0.setQuestionDefinition( $r1 );
> fact0.setEntity( $entity );
> insert( fact0 );
> end
> {code}
> *Ruleset 2*
> {code:java}
> rule "Rule183"
> dialect "mvel"
> when
> $entity : Entity( )
> $service : ServiceOrdered( serviceId == "FORM" , entity == $entity , entity.entityTypeId in ( 291262, 291275, 291277 ) )
> $r1 : QuestionDefinition( id == 590 )
> then
> Question fact0 = new Question();
> fact0.setQuestionDefinition( $r1 );
> fact0.setEntity( $entity );
> insert( fact0 );
> end
> {code}
> {code}
> rule "Rule183-2"
> dialect "mvel"
> when
> $entity : Entity( )
> $service : ServiceOrdered( serviceId == "DISSO" , entity == $entity , entity.entityTypeId == 291262 , stateId == 290864 )
> $r1 : QuestionDefinition( id == 590 )
> then
> Question fact0 = new Question();
> fact0.setQuestionDefinition( $r1 );
> fact0.setEntity( $entity );
> insert( fact0 );
> end
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 3 months