[Red Hat JIRA] (DROOLS-5973) Java enum values don't match DNM enumerations when input passed as POJO
by Matteo Mortari (Jira)
[ https://issues.redhat.com/browse/DROOLS-5973?page=com.atlassian.jira.plug... ]
Matteo Mortari updated DROOLS-5973:
-----------------------------------
Attachment: screenshot-4.png
> Java enum values don't match DNM enumerations when input passed as POJO
> -----------------------------------------------------------------------
>
> Key: DROOLS-5973
> URL: https://issues.redhat.com/browse/DROOLS-5973
> Project: Drools
> Issue Type: Bug
> Components: dmn engine
> Affects Versions: 7.48.0.Final
> Reporter: Andrew K
> Assignee: Matteo Mortari
> Priority: Minor
> Attachments: screenshot-1.png, screenshot-2.png, screenshot-3.png, screenshot-4.png
>
>
> When passing an input object into the DMN engine as a POJO, enumerations represented in the POJO as Java enums do not correctly match DMN string enumerations.
> This can be worked around by converting the input to a Map using Jackson:
> {code:java}
> new ObjectMapper().convertValue(pojo, Map.class){code}
> but this should not be necessary.
--
This message was sent by Atlassian Jira
(v8.13.1#813001)
5 years, 2 months
[Red Hat JIRA] (DROOLS-5973) Java enum values don't match DNM enumerations when input passed as POJO
by Matteo Mortari (Jira)
[ https://issues.redhat.com/browse/DROOLS-5973?page=com.atlassian.jira.plug... ]
Matteo Mortari updated DROOLS-5973:
-----------------------------------
Attachment: screenshot-3.png
> Java enum values don't match DNM enumerations when input passed as POJO
> -----------------------------------------------------------------------
>
> Key: DROOLS-5973
> URL: https://issues.redhat.com/browse/DROOLS-5973
> Project: Drools
> Issue Type: Bug
> Components: dmn engine
> Affects Versions: 7.48.0.Final
> Reporter: Andrew K
> Assignee: Matteo Mortari
> Priority: Minor
> Attachments: screenshot-1.png, screenshot-2.png, screenshot-3.png
>
>
> When passing an input object into the DMN engine as a POJO, enumerations represented in the POJO as Java enums do not correctly match DMN string enumerations.
> This can be worked around by converting the input to a Map using Jackson:
> {code:java}
> new ObjectMapper().convertValue(pojo, Map.class){code}
> but this should not be necessary.
--
This message was sent by Atlassian Jira
(v8.13.1#813001)
5 years, 2 months
[Red Hat JIRA] (WFLY-10607) Fix intermittent failures in *EJBForwardingTestCase
by Radoslav Husar (Jira)
[ https://issues.redhat.com/browse/WFLY-10607?page=com.atlassian.jira.plugi... ]
Radoslav Husar commented on WFLY-10607:
---------------------------------------
Just pasting here the very clumsy way to run these tests only:
{{./integration-tests.sh clean install -Dts.noSmoke -Dts.clustering -Dtest=org.jboss.as.test.clustering.cluster.ejb.forwarding.*TestCase -Djboss.test.enableIntermittentFailingTests=true -Dsecurity.manager=true -P="-ts.clustering.cluster.ha.profile,-ts.clustering.cluster.ha-infinispan-server.profile,-ts.clustering.byteman.profile,-ts.clustering.single.profile,-ts.surefire.clustering.single.manual"}}
> Fix intermittent failures in *EJBForwardingTestCase
> ---------------------------------------------------
>
> Key: WFLY-10607
> URL: https://issues.redhat.com/browse/WFLY-10607
> Project: WildFly
> Issue Type: Bug
> Components: EJB, Test Suite
> Affects Versions: 16.0.0.Final
> Reporter: Petr Kremensky
> Assignee: Richard Achmatowicz
> Priority: Major
> Attachments: org.jboss.as.test.clustering.cluster.ejb.forwarding.TxRemoteEJBForwardingTestCase-output.txt
>
>
> The tests were ignored by https://github.com/wildfly/wildfly/pull/10563
--
This message was sent by Atlassian Jira
(v8.13.1#813001)
5 years, 2 months
[Red Hat JIRA] (DROOLS-5973) Java enum values don't match DNM enumerations when input passed as POJO
by Matteo Mortari (Jira)
[ https://issues.redhat.com/browse/DROOLS-5973?page=com.atlassian.jira.plug... ]
Matteo Mortari updated DROOLS-5973:
-----------------------------------
Attachment: screenshot-2.png
> Java enum values don't match DNM enumerations when input passed as POJO
> -----------------------------------------------------------------------
>
> Key: DROOLS-5973
> URL: https://issues.redhat.com/browse/DROOLS-5973
> Project: Drools
> Issue Type: Bug
> Components: dmn engine
> Affects Versions: 7.48.0.Final
> Reporter: Andrew K
> Assignee: Matteo Mortari
> Priority: Minor
> Attachments: screenshot-1.png, screenshot-2.png
>
>
> When passing an input object into the DMN engine as a POJO, enumerations represented in the POJO as Java enums do not correctly match DMN string enumerations.
> This can be worked around by converting the input to a Map using Jackson:
> {code:java}
> new ObjectMapper().convertValue(pojo, Map.class){code}
> but this should not be necessary.
--
This message was sent by Atlassian Jira
(v8.13.1#813001)
5 years, 2 months
[Red Hat JIRA] (DROOLS-5973) Java enum values don't match DNM enumerations when input passed as POJO
by Matteo Mortari (Jira)
[ https://issues.redhat.com/browse/DROOLS-5973?page=com.atlassian.jira.plug... ]
Matteo Mortari updated DROOLS-5973:
-----------------------------------
Attachment: screenshot-1.png
> Java enum values don't match DNM enumerations when input passed as POJO
> -----------------------------------------------------------------------
>
> Key: DROOLS-5973
> URL: https://issues.redhat.com/browse/DROOLS-5973
> Project: Drools
> Issue Type: Bug
> Components: dmn engine
> Affects Versions: 7.48.0.Final
> Reporter: Andrew K
> Assignee: Matteo Mortari
> Priority: Minor
> Attachments: screenshot-1.png, screenshot-2.png
>
>
> When passing an input object into the DMN engine as a POJO, enumerations represented in the POJO as Java enums do not correctly match DMN string enumerations.
> This can be worked around by converting the input to a Map using Jackson:
> {code:java}
> new ObjectMapper().convertValue(pojo, Map.class){code}
> but this should not be necessary.
--
This message was sent by Atlassian Jira
(v8.13.1#813001)
5 years, 2 months
[Red Hat JIRA] (DROOLS-6030) Evaluate "KieBase.addPackage" replacement effort from PMML
by Gabriele Cardosi (Jira)
[ https://issues.redhat.com/browse/DROOLS-6030?page=com.atlassian.jira.plug... ]
Gabriele Cardosi updated DROOLS-6030:
-------------------------------------
Sprint: 2021 Week 07-09 (from Feb 15)
> Evaluate "KieBase.addPackage" replacement effort from PMML
> ----------------------------------------------------------
>
> Key: DROOLS-6030
> URL: https://issues.redhat.com/browse/DROOLS-6030
> Project: Drools
> Issue Type: Task
> Reporter: Gabriele Cardosi
> Assignee: Gabriele Cardosi
> Priority: Major
>
> Currently, the method KieBase.addPackage(s) is used inside PMML in two classes
> 1) PMMLLoaderService.loadPMMLRuleMappers
> 2) PMMLRuntimeFactoryInternal.getPMMLRuntime(String, String, KieBase)
> 3) PMMLRuntimeFactoryInternal.createKieBase(KnowledgeBuilderImpl)
> In all those cases the needs is to create a "clean" kiebase that contains only the model-specific packages, to avoid name/session clashing.
> Scope of the current ticket is to evaluate an alternative, since the method itself is going to be deprecated.
--
This message was sent by Atlassian Jira
(v8.13.1#813001)
5 years, 2 months
[Red Hat JIRA] (DROOLS-6030) Evaluate "KieBase.addPackage" replacement effort from PMML
by Gabriele Cardosi (Jira)
[ https://issues.redhat.com/browse/DROOLS-6030?page=com.atlassian.jira.plug... ]
Gabriele Cardosi edited comment on DROOLS-6030 at 2/15/21 10:09 AM:
--------------------------------------------------------------------
[~mario.fusco1]
As per description, the invocation itself is present in two classes, with slightly different reasons:
1) PMMLLoaderService.loadPMMLRuleMappers is called (mainly) starting from Kogito, where the org.drools.model.Model are instantiated from (compiled) classes, a new KnowledgeBuilderImpl is built out of such models, and then the newly built packages are added to the parameter KnowledgeBuilderImpl (see [method|https://github.com/kiegroup/drools/blob/706f219d1877152d885a1acbef...])
2) inside PMMLRuntimeFactoryInternal, a new "clean" KieBase is created out of the provided one, and populated only with packages relevant for the evaluated model (see [here|https://github.com/kiegroup/drools/blob/706f219d1877152d885a1acbef3d...] and [here|https://github.com/kiegroup/drools/blob/706f219d1877152d885a1acbef3d...])
Replace them with the preferred one and do thorough tests could take one or two days.
But the real issue is: what is the preferred one ? As far as I know, the use case by itself has never implemented/requested before, and I have not the required knowledge of drools-core to estimate how much time it could need to create a "nice" implementation.
was (Author: gabriolo):
[~mario.fusco1]
As per description, the invocation itself is present in two classes, with slightly different reasons:
1) PMMLLoaderService.loadPMMLRuleMappers is called (mainly) starting from Kogito, where the org.drools.model.Model are instantiated from (compiled) classes, a new KnowledgeBuilderImpl is built out of such models, and then the newly built packages are added to the parameter KnowledgeBuilderImpl (see [method|https://github.com/kiegroup/drools/blob/706f219d1877152d885a1acbef...])
2) inside PMMLRuntimeFactoryInternal, a new "clean" KieBase is created out of the provided one, and populated only with packages relevant for the evaluated model (see [here|https://github.com/kiegroup/drools/blob/706f219d1877152d885a1acbef3d...] and [here|https://github.com/kiegroup/drools/blob/706f219d1877152d885a1acbef3d...])
2)
: replace it with the preferred one and do thorough tests could take one or two days.
But the real issue is: what is the preferred one ? As far as I know, the use case by itself has never implemented/requested before, and I have not the required knowledge of drools-core to estimate how much time it could need to create a "nice" implementation.
> Evaluate "KieBase.addPackage" replacement effort from PMML
> ----------------------------------------------------------
>
> Key: DROOLS-6030
> URL: https://issues.redhat.com/browse/DROOLS-6030
> Project: Drools
> Issue Type: Task
> Reporter: Gabriele Cardosi
> Assignee: Gabriele Cardosi
> Priority: Major
>
> Currently, the method KieBase.addPackage(s) is used inside PMML in two classes
> 1) PMMLLoaderService.loadPMMLRuleMappers
> 2) PMMLRuntimeFactoryInternal.getPMMLRuntime(String, String, KieBase)
> 3) PMMLRuntimeFactoryInternal.createKieBase(KnowledgeBuilderImpl)
> In all those cases the needs is to create a "clean" kiebase that contains only the model-specific packages, to avoid name/session clashing.
> Scope of the current ticket is to evaluate an alternative, since the method itself is going to be deprecated.
--
This message was sent by Atlassian Jira
(v8.13.1#813001)
5 years, 2 months
[Red Hat JIRA] (DROOLS-6030) Evaluate "KieBase.addPackage" replacement effort from PMML
by Gabriele Cardosi (Jira)
[ https://issues.redhat.com/browse/DROOLS-6030?page=com.atlassian.jira.plug... ]
Gabriele Cardosi commented on DROOLS-6030:
------------------------------------------
[~mario.fusco1]
As per description, the invocation itself is present in two classes, with slightly different reasons:
1) PMMLLoaderService.loadPMMLRuleMappers is called (mainly) starting from Kogito, where the org.drools.model.Model are instantiated from (compiled) classes, a new KnowledgeBuilderImpl is built out of such models, and then the newly built packages are added to the parameter KnowledgeBuilderImpl (see [method|https://github.com/kiegroup/drools/blob/706f219d1877152d885a1acbef...])
2) inside PMMLRuntimeFactoryInternal, a new "clean" KieBase is created out of the provided one, and populated only with packages relevant for the evaluated model (see [here|https://github.com/kiegroup/drools/blob/706f219d1877152d885a1acbef3d...] and [here|https://github.com/kiegroup/drools/blob/706f219d1877152d885a1acbef3d...])
2)
: replace it with the preferred one and do thorough tests could take one or two days.
But the real issue is: what is the preferred one ? As far as I know, the use case by itself has never implemented/requested before, and I have not the required knowledge of drools-core to estimate how much time it could need to create a "nice" implementation.
> Evaluate "KieBase.addPackage" replacement effort from PMML
> ----------------------------------------------------------
>
> Key: DROOLS-6030
> URL: https://issues.redhat.com/browse/DROOLS-6030
> Project: Drools
> Issue Type: Task
> Reporter: Gabriele Cardosi
> Assignee: Gabriele Cardosi
> Priority: Major
>
> Currently, the method KieBase.addPackage(s) is used inside PMML in two classes
> 1) PMMLLoaderService.loadPMMLRuleMappers
> 2) PMMLRuntimeFactoryInternal.getPMMLRuntime(String, String, KieBase)
> 3) PMMLRuntimeFactoryInternal.createKieBase(KnowledgeBuilderImpl)
> In all those cases the needs is to create a "clean" kiebase that contains only the model-specific packages, to avoid name/session clashing.
> Scope of the current ticket is to evaluate an alternative, since the method itself is going to be deprecated.
--
This message was sent by Atlassian Jira
(v8.13.1#813001)
5 years, 2 months