[jboss-jira] [JBoss JIRA] Commented: (JBREM-645) Need to cleanup locatorURI parsing
[ http://jira.jboss.com/jira/browse/JBREM-645?page=comments#action_12362823 ]
Ron Sigal commented on JBREM-645:
---------------------------------
By default, InvokerLocator uses the java.net.URI.URI parsing facilities to analyze the
input locator string. Optionally, if the system property InvokerLocator.LEGACY_PARSING
(actual value "legacyParsing") is set to true, the original parsing algorithm
will be used instead. The difference, as noted above, is that the original algorithm does
not include a "/" character at the beginning of a non-null path component.
Unit test: org.jboss.test.remoting.locator.InvokerLocatorTestCase has been updated to
test both the legacy and the new parsing algorithms. It also tests that
"socket://succubus.starkinternational.com:4446?datatype=invocation" is correctly
parsed.
Waiting for cruisecontrol results.
Need to cleanup locatorURI parsing
----------------------------------
Key: JBREM-645
URL: http://jira.jboss.com/jira/browse/JBREM-645
Project: JBoss Remoting
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: general
Affects Versions: 2.2.0.Alpha3 (Bluto)
Reporter: Scott M Stark
Assigned To: Ron Sigal
Fix For: 2.4.0.Beta1 (Pinto)
Remoting is using its own parsing logic to extract the host and port when it should be
using a URI object, and have a ctor supporting a URI type. This URI which parses fine via
the URI class:
URI x = new
URI("socket://succubus.starkinternational.com:4446?datatype=invocation");
int port = x.getPort();
fails to parse when passed to the InvokerLocator
370232 ERROR [DeploymentWorker] Operation Distribute failed on target
org.jboss.deployment.remoting.StreamingTarget@11e9c82e
java.lang.NumberFormatException: For input string: "4446?datatype=invocation"
at java.lang.NumberFormatException.forInputString(NumberFormatException.java:48)
at java.lang.Integer.parseInt(Integer.java:456)
at java.lang.Integer.parseInt(Integer.java:497)
at org.jboss.remoting.InvokerLocator.<init>(InvokerLocator.java:191)
at org.jboss.deployment.remoting.StreamingTarget.getClient(StreamingTarget.java:254)
at org.jboss.deployment.remoting.StreamingTarget.deploy(StreamingTarget.java:140)
at org.jboss.deployment.spi.DeploymentWorker.run(DeploymentWorker.java:74)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira