[jboss-jira] [JBoss JIRA] (WFLY-13814) Drop messaging subsystem's HTTPUpgradeService's use of SimpleHttpUpgradeHandshake, drop dep on org.jboss.as.remoting
[
https://issues.redhat.com/browse/WFLY-13814?page=com.atlassian.jira.plugi...
]
Brian Stansberry commented on WFLY-13814:
-----------------------------------------
I misread; the messaging subsystem class is invoking the superclass. So there's a bit
more code to copy over.
The existing impl is somewhat buggy though. It invokes the superclass, which then updates
the response with an 'accept header'. But then the override code does more
analysis and may return 'false', i.e. indicate the upgrade should not happen. But
the response already includes the 'accept header'.
Drop messaging subsystem's HTTPUpgradeService's use of
SimpleHttpUpgradeHandshake, drop dep on org.jboss.as.remoting
--------------------------------------------------------------------------------------------------------------------
Key: WFLY-13814
URL: https://issues.redhat.com/browse/WFLY-13814
Project: WildFly
Issue Type: Enhancement
Components: JMS
Reporter: Brian Stansberry
Assignee: Brian Stansberry
Priority: Major
Messaging's HTTPUpgradeService is importing
org.jboss.as.remoting.SimpleHttpUpgradeHandshake but then overrides one of its two
methods. The other method is less than 10 lines of code. So just implement this directly
and drop the org.jboss.as.remoting dependency.
To be fair, SimpleHttpUpgradeHandshake also includes a complex 'FlexBase64' inner
class, but undertow-core provides the same class. HttpUpgradeHandshake itself is from
undertow-core so there's no reason not to use the Undertow class. (The same is true in
SimpleHttpUpgradeHandshake.)
--
This message was sent by Atlassian Jira
(v7.13.8#713008)