[ https://issues.jboss.org/browse/AS7-1301?page=com.atlassian.jira.plugin.s... ] Thomas Diesler edited comment on AS7-1301 at 7/26/11 9:24 AM: -------------------------------------------------------------- How is the client supposed to calculate the system loader paths? Internally I see JDKPaths being used. was (Author: thomas.diesler): How is the client supposed to calculate the system's loader paths? Internally I see JDKPaths being used. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-1301?page=com.atlassian.jira.plugin.s... ] Thomas Diesler edited comment on AS7-1301 at 7/26/11 9:26 AM: -------------------------------------------------------------- How is the client supposed to calculate the system loader paths? Internally I see JDKPaths being used. public static DependencySpec createSystemDependencySpec(final PathFilter importFilter, final PathFilter exportFilter, final Set<String> loaderPaths) { was (Author: thomas.diesler): How is the client supposed to calculate the system loader paths? Internally I see JDKPaths being used. {code} public static DependencySpec createSystemDependencySpec(final PathFilter importFilter, final PathFilter exportFilter, final Set<String> loaderPaths) { {code} -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-1301?page=com.atlassian.jira.plugin.s... ] Thomas Diesler reassigned AS7-1301: ----------------------------------- Assignee: David Lloyd (was: Thomas Diesler) I have a framework update ready in https://github.com/tdiesler/jbosgi-framework/tree/osgi483 It relies on a minor change in modules that allows system paths to be optionally defined https://github.com/jbossas/jboss-modules/pull/5 -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-1301?page=com.atlassian.jira.plugin.s... ] David Lloyd reassigned AS7-1301: -------------------------------- Assignee: Thomas Diesler (was: David Lloyd) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-1301?page=com.atlassian.jira.plugin.s... ] Thomas Diesler edited comment on AS7-1301 at 7/27/11 10:06 AM: --------------------------------------------------------------- The framework supports the notion of configurable system packages that can be loaded from the system bundle. Every bundle must be able load these packages from the system class loader ??The Framework must always delegate any package that starts with java. to the parent class loader.?? In our implementation we define a system dependency for every host bundle. Currently I do it like this {code} // Add a system dependency SystemPackagesPlugin plugin = injectedSystemPackages.getValue(); PathFilter systemPackagesFilter = plugin.getSystemPackageFilter(); PathFilter sysImportFilter = systemPackagesFilter; PathFilter sysExportFilter = PathFilters.acceptAll(); moduleDependencies.add(DependencySpec.createSystemDependencySpec(sysImportFilter, sysExportFilter, null)); {code} Note the 'null' for the system paths. I could define this set explicitly, which would require an update for every jdk version, right? Meanwhile, I think a fallback to JDKPaths.JDK is ok and we can revisit when I look at framework bootstrap performance. was (Author: thomas.diesler): The framework supports the notion of configurable system packages that can be loaded from the system bundle. Every bundle must be able load these packages from the system class loader ??The Framework must always delegate any package that starts with java. to the parent class loader.?? In our implementation we define a system dependency for every host bundle. Currently I do it like this {code} // Add a system dependency SystemPackagesPlugin plugin = injectedSystemPackages.getValue(); PathFilter systemPackagesFilter = plugin.getSystemPackageFilter(); PathFilter sysImportFilter = systemPackagesFilter; PathFilter sysExportFilter = PathFilters.acceptAll(); moduleDependencies.add(DependencySpec.createSystemDependencySpec(sysImportFilter, sysExportFilter, null)); {code} Please note the 'null' for the system paths. I could define this set explicitly, which would require an update for every jdk version, right? Meanwhile, I think a fallback to JDKPaths.JDK is ok and we can revisit when I look at framework bootstrap performance. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-1301?page=com.atlassian.jira.plugin.s... ] Thomas Diesler commented on AS7-1301: ------------------------------------- Thinking about it ... I always have an explicit import filter, so the set of paths does not need to be greater than what the filter accepts. So I could derive the paths from the filter. WDYT? -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-1301?page=com.atlassian.jira.plugin.s... ] David Lloyd commented on AS7-1301: ---------------------------------- Yes, deriving the paths from the filter sounds like a fine idea, as long as the filter doesn't include any of the aforementioned javax or org.omg APIs. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-1301?page=com.atlassian.jira.plugin.s... ] Jason Greene updated AS7-1301: ------------------------------ Fix Version/s: 7.1.0.Beta1 (was: 7.1.0.Alpha1) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-1301?page=com.atlassian.jira.plugin.s... ] Thomas Diesler commented on AS7-1301: ------------------------------------- Updated pull request -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira