[ https://jira.jboss.org/browse/JASSIST-127?page=com.atlassian.jira.plugin.... ] Peter Miklos edited comment on JASSIST-127 at 11/8/10 11:13 AM: ---------------------------------------------------------------- I have experienced with the same in version 3.11.0.GA (actually, it leads Weld to fail injecting beans when tries to proxy a class like that). Did some debugging and found that ClassFile.isDuplicated() might be fixed somewhere here: ... if (desc.equals(newDesc)) { if (notBridgeMethod(minfo)) return true; else { it.remove(); return false; } } else return notBridgeMethod(minfo) && notBridgeMethod(newMethod); When method names are the same and return types differ the control flows to the last else statement and that point returns true. was (Author: pmiklos): I have experienced with the same in version 3.11.0.GA (actually, it leads Weld to fail injecting beans when tries to proxy a class like that). Did some debugging and found that ClassFile.isDuplicated() might be fixed somewhere here: ... if (desc.equals(newDesc)) { if (notBridgeMethod(minfo)) return true; else { it.remove(); return false; } } else return notBridgeMethod(minfo) && notBridgeMethod(newMethod); When method names are the same and return types differ the control flows to the last else statement and that point returns false. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JASSIST-127?page=com.atlassian.jira.plugi... ] Shigeru Chiba resolved JASSIST-127. ----------------------------------- Fix Version/s: 3.16.0-GA Resolution: Done Thanks for the patch, Paul. I slightly modified the patch and then merged it. Could you check this? -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JASSIST-127?page=com.atlassian.jira.plugi... ] Shigeru Chiba commented on JASSIST-127: --------------------------------------- Paul, I understand that submitting your patch to this site means you donated your code to the software (= me) and agreed distributing it under the MPL/LGPL/APL. Is this OK? -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JASSIST-127?page=com.atlassian.jira.plugi... ] Shigeru Chiba commented on JASSIST-127: --------------------------------------- Thanks. Yes, it's too small but some industrial users want to make sure that this kind of legal issue is clear. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JASSIST-127?page=com.atlassian.jira.plugi... ] Brice Dutheil commented on JASSIST-127: --------------------------------------- The proposed solution doesn't work, the JVM raises an AbstractMethodError on the call site. What happen is that the proposed solution discard method with same name / same argument as the return type is not taken into account when generating the key in getMethods. Reverting the actual patch raises DuplicateMemberException because ClassFile.isDuplicated don't see either of these method as bridge. I've created a patch that detect methods with covariant type and mark forwarding methods as bridge in relevant scenarios. Also, I'm not sure of that one but the path also adds a boolean to enable the MethodHandler to intercept bridge methods. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira