[JBoss JIRA] Created: (JBREM-543) fix servlet invoker error handling to be more like that of the http invoker
10:46 p.m.
fix servlet invoker error handling to be more like that of the http invoker
---------------------------------------------------------------------------
Key: JBREM-543
URL: http://jira.jboss.com/jira/browse/JBREM-543
Project: JBoss Remoting
Issue Type: Task
Security Level: Public (Everyone can see)
Affects Versions: 2.0.0.Beta2 (Boon)
Reporter: Tom Elrod
Assigned To: Tom Elrod
Fix For: 2.0.0.CR1 (Boon)
Need to change the servlet invoker so on client side will not throw an exception out of
the Client's invoke() method call, but just return the error (as text in most cases)
and have the response code indicate the error status code (e.g. 500). Although this is
not exactly how the http invoker handles exceptions from the http server invoker, is only
way to reliably get errors from web containers (like Tomcat).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:46 p.m.
New subject: [JBoss JIRA] Commented: (JBREM-543) fix servlet invoker error handling to be more like that of the http invoker
[ http://jira.jboss.com/jira/browse/JBREM-543?page=comments#action_12339635 ]
Tom Elrod commented on JBREM-543:
----------------------------------
Test case: there is no automated test case, but manual tests can be run be following
readme.txt in src/tests/org/jboss/test/remoting/transport/servlet/readme.txt
fix servlet invoker error handling to be more like that of the http
invoker
---------------------------------------------------------------------------
Key: JBREM-543
URL: http://jira.jboss.com/jira/browse/JBREM-543
Project: JBoss Remoting
Issue Type: Task
Security Level: Public(Everyone can see)
Affects Versions: 2.0.0.Beta2 (Boon)
Reporter: Tom Elrod
Assigned To: Tom Elrod
Fix For: 2.0.0.CR1 (Boon)
Need to change the servlet invoker so on client side will not throw an exception out of
the Client's invoke() method call, but just return the error (as text in most cases)
and have the response code indicate the error status code (e.g. 500). Although this is
not exactly how the http invoker handles exceptions from the http server invoker, is only
way to reliably get errors from web containers (like Tomcat).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:49 p.m.
New subject: [JBoss JIRA] Commented: (JBREM-543) fix servlet invoker error handling to be more like that of the http invoker
[ http://jira.jboss.com/jira/browse/JBREM-543?page=comments#action_12339636 ]
Tom Elrod commented on JBREM-543:
----------------------------------
org.jboss.test.remoting.transport.servlet.ServletInvokerTestClient's
makeExceptionInvocation() method shows how to handle this:
protected void makeExceptionInvocation(Client remotingClient, Map metadata) throws
Throwable
{
Object response = remotingClient.invoke(WebInvocationHandler.THROW_EXCEPTION_PARAM,
metadata);
Integer responseCode = (Integer) metadata.get(HTTPMetadataConstants.RESPONSE_CODE);
assertEquals("Metadata value for " + HTTPMetadataConstants.RESPONSE_CODE +
" should be " + ERROR_RESPONSE_CODE +
" and was " + responseCode, ERROR_RESPONSE_CODE,
responseCode);
}
Where response will be the html text returned from the web server (basically the junk you
would see in a browser).
fix servlet invoker error handling to be more like that of the http
invoker
---------------------------------------------------------------------------
Key: JBREM-543
URL: http://jira.jboss.com/jira/browse/JBREM-543
Project: JBoss Remoting
Issue Type: Task
Security Level: Public(Everyone can see)
Affects Versions: 2.0.0.Beta2 (Boon)
Reporter: Tom Elrod
Assigned To: Tom Elrod
Fix For: 2.0.0.CR1 (Boon)
Need to change the servlet invoker so on client side will not throw an exception out of
the Client's invoke() method call, but just return the error (as text in most cases)
and have the response code indicate the error status code (e.g. 500). Although this is
not exactly how the http invoker handles exceptions from the http server invoker, is only
way to reliably get errors from web containers (like Tomcat).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:55 p.m.
New subject: [JBoss JIRA] Resolved: (JBREM-543) fix servlet invoker error handling to be more like that of the http invoker
[ http://jira.jboss.com/jira/browse/JBREM-543?page=all ]
Tom Elrod resolved JBREM-543.
------------------------------
Resolution: Done
fix servlet invoker error handling to be more like that of the http
invoker
---------------------------------------------------------------------------
Key: JBREM-543
URL: http://jira.jboss.com/jira/browse/JBREM-543
Project: JBoss Remoting
Issue Type: Task
Security Level: Public(Everyone can see)
Affects Versions: 2.0.0.Beta2 (Boon)
Reporter: Tom Elrod
Assigned To: Tom Elrod
Fix For: 2.0.0.CR1 (Boon)
Need to change the servlet invoker so on client side will not throw an exception out of
the Client's invoke() method call, but just return the error (as text in most cases)
and have the response code indicate the error status code (e.g. 500). Although this is
not exactly how the http invoker handles exceptions from the http server invoker, is only
way to reliably get errors from web containers (like Tomcat).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:54 a.m.
New subject: [JBoss JIRA] Commented: (JBREM-543) fix servlet invoker error handling to be more like that of the http invoker
[ http://jira.jboss.com/jira/browse/JBREM-543?page=comments#action_12339641 ]
John Mazzitelli commented on JBREM-543:
---------------------------------------
I can't tell by the example what type "response" is - it is of type
java.lang.Exception ?
I just looked at the docs for this a couple of days ago and read that invoke will return
Exception object on error.
Your problem description implies its just a String ("but just return the error (as
text in most cases)").
Hopefully, it is still a java.lang.Exception.
fix servlet invoker error handling to be more like that of the http
invoker
---------------------------------------------------------------------------
Key: JBREM-543
URL: http://jira.jboss.com/jira/browse/JBREM-543
Project: JBoss Remoting
Issue Type: Task
Security Level: Public(Everyone can see)
Affects Versions: 2.0.0.Beta2 (Boon)
Reporter: Tom Elrod
Assigned To: Tom Elrod
Fix For: 2.0.0.CR1 (Boon)
Need to change the servlet invoker so on client side will not throw an exception out of
the Client's invoke() method call, but just return the error (as text in most cases)
and have the response code indicate the error status code (e.g. 500). Although this is
not exactly how the http invoker handles exceptions from the http server invoker, is only
way to reliably get errors from web containers (like Tomcat).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:50 p.m.
New subject: [JBoss JIRA] Commented: (JBREM-543) fix servlet invoker error handling to be more like that of the http invoker
[ http://jira.jboss.com/jira/browse/JBREM-543?page=comments#action_12339644 ]
Tom Elrod commented on JBREM-543:
----------------------------------
The response object type in this case is indeed java.lang.String. I have update the test
case to print it out (See ServletInvokerTestClient or SSLServletInvokerTestClient). The
output I get from JBossAS is:
<html><head><title>Apache Tomcat/5.5.17 - Error
report</title><style><!--H1
{font-family:Tahoma,Arial,sans-serif;color:white;background-color:#525D76;font-size:22px;}
H2
{font-family:Tahoma,Arial,sans-serif;color:white;background-color:#525D76;font-size:16px;}
H3
{font-family:Tahoma,Arial,sans-serif;color:white;background-color:#525D76;font-size:14px;}
BODY {font-family:Tahoma,Arial,sans-serif;color:black;background-color:white;} B
{font-family:Tahoma,Arial,sans-serif;color:white;background-color:#525D76;} P
{font-family:Tahoma,Arial,sans-serif;background:white;color:black;font-size:12px;}A {color
: black;}A.name {color : black;}HR {color : #525D76;}--></style>
</head><body><h1>HTTP Status 500 - Error occurred processing invocation
request. </h1><HR size="1"
noshade="noshade"><p><b>type</b> Status
report</p><p><b>message</b> <u>Error occurred processing
invocation request. </u></p><p><b>description</b>
<u>The server encountered an internal error (Error occurred processing invocation
request. ) that prevented it from fulfilling this request.</u></p><HR
size="1" noshade="noshade"><h3>Apache
Tomcat/5.5.17</h3></body></html>
I agree that would be best for the http/servlet client invoker to thrown an exception as
is done with other transports, but was changed a while back to this format per request
from the web services team. I am re-opening this discussion with them
(http://www.jboss.com/index.html?module=bb&op=viewtopic&p=3958247#...).
fix servlet invoker error handling to be more like that of the http
invoker
---------------------------------------------------------------------------
Key: JBREM-543
URL: http://jira.jboss.com/jira/browse/JBREM-543
Project: JBoss Remoting
Issue Type: Task
Security Level: Public(Everyone can see)
Affects Versions: 2.0.0.Beta2 (Boon)
Reporter: Tom Elrod
Assigned To: Tom Elrod
Fix For: 2.0.0.CR1 (Boon)
Need to change the servlet invoker so on client side will not throw an exception out of
the Client's invoke() method call, but just return the error (as text in most cases)
and have the response code indicate the error status code (e.g. 500). Although this is
not exactly how the http invoker handles exceptions from the http server invoker, is only
way to reliably get errors from web containers (like Tomcat).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:20 p.m.
New subject: [JBoss JIRA] Commented: (JBREM-543) fix servlet invoker error handling to be more like that of the http invoker
[ http://jira.jboss.com/jira/browse/JBREM-543?page=comments#action_12339645 ]
John Mazzitelli commented on JBREM-543:
---------------------------------------
IMHO, this has to be changed back - at least to return an Exception message (if you want,
let the exception's message be that string). Ideally, have it configurable - let me
say whether I want the exception to be thrown, returned as an Exception or returned as a
String.
I just posted a comment to that forum link you provided.
My problem - in my code I don't know (nor do I want to know) what transport I'm
using. If you just return a String, how do I know this was an error that occurred? If I
am forced to look at the HTTP response code, that requires that my Client code know that
I'm using http or servlet transport. My client doesn't know what transport its
using - in fact, my customers can configure it anyway they want - they can use sslsocket,
socket, http, servlet, whatever they put in the config file. (BTW: this is one of the
great features of remoting - you actually don't even have to know how the messages are
getting transported! I just pass an opaque locator URL that I get from a config file and
connect my Client to it. I let remoting do everything for me - I just pass things in and
get things back from invoke.) Forcing me to examine the HTTP response code just to know
if the invocation failed or not breaks that separation.
fix servlet invoker error handling to be more like that of the http
invoker
---------------------------------------------------------------------------
Key: JBREM-543
URL: http://jira.jboss.com/jira/browse/JBREM-543
Project: JBoss Remoting
Issue Type: Task
Security Level: Public(Everyone can see)
Affects Versions: 2.0.0.Beta2 (Boon)
Reporter: Tom Elrod
Assigned To: Tom Elrod
Fix For: 2.0.0.CR1 (Boon)
Need to change the servlet invoker so on client side will not throw an exception out of
the Client's invoke() method call, but just return the error (as text in most cases)
and have the response code indicate the error status code (e.g. 500). Although this is
not exactly how the http invoker handles exceptions from the http server invoker, is only
way to reliably get errors from web containers (like Tomcat).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:11 p.m.
New subject: [JBoss JIRA] Commented: (JBREM-543) fix servlet invoker error handling to be more like that of the http invoker
[ http://jira.jboss.com/jira/browse/JBREM-543?page=comments#action_12339651 ]
John Mazzitelli commented on JBREM-543:
---------------------------------------
let me correct myself, that first sentence should be:
"at least to return an Exception OBJECT"
I would like invoke to return a java.lang.Exception object, not a java.lang.String
fix servlet invoker error handling to be more like that of the http
invoker
---------------------------------------------------------------------------
Key: JBREM-543
URL: http://jira.jboss.com/jira/browse/JBREM-543
Project: JBoss Remoting
Issue Type: Task
Security Level: Public(Everyone can see)
Affects Versions: 2.0.0.Beta2 (Boon)
Reporter: Tom Elrod
Assigned To: Tom Elrod
Fix For: 2.0.0.CR1 (Boon)
Need to change the servlet invoker so on client side will not throw an exception out of
the Client's invoke() method call, but just return the error (as text in most cases)
and have the response code indicate the error status code (e.g. 500). Although this is
not exactly how the http invoker handles exceptions from the http server invoker, is only
way to reliably get errors from web containers (like Tomcat).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:21 p.m.
New subject: [JBoss JIRA] Reopened: (JBREM-543) fix servlet invoker error handling to be more like that of the http invoker
[ http://jira.jboss.com/jira/browse/JBREM-543?page=all ]
Tom Elrod reopened JBREM-543:
------------------------------
fix servlet invoker error handling to be more like that of the http
invoker
---------------------------------------------------------------------------
Key: JBREM-543
URL: http://jira.jboss.com/jira/browse/JBREM-543
Project: JBoss Remoting
Issue Type: Task
Security Level: Public(Everyone can see)
Affects Versions: 2.0.0.Beta2 (Boon)
Reporter: Tom Elrod
Assigned To: Tom Elrod
Fix For: 2.0.0.CR1 (Boon)
Need to change the servlet invoker so on client side will not throw an exception out of
the Client's invoke() method call, but just return the error (as text in most cases)
and have the response code indicate the error status code (e.g. 500). Although this is
not exactly how the http invoker handles exceptions from the http server invoker, is only
way to reliably get errors from web containers (like Tomcat).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:58 p.m.
New subject: [JBoss JIRA] Commented: (JBREM-543) fix servlet invoker error handling to be more like that of the http invoker
[ http://jira.jboss.com/jira/browse/JBREM-543?page=comments#action_12339675 ]
Tom Elrod commented on JBREM-543:
----------------------------------
Have basically rolled back latest changes to allow for throwing of exceptions or be
configured to *not* throw an exception. Details can be found within JBREM-544.
Now servlet and http transports (and their children, https and sslservlet) behave the
same. Only difference in behavior will depend on if is calling on remoting server, where
original exception generated on server side will be thrown on the client or if is not
remoting server, will throw (or return if configured to not thow exception) a
WebServerError, who's message with the error html from the web server.
fix servlet invoker error handling to be more like that of the http
invoker
---------------------------------------------------------------------------
Key: JBREM-543
URL: http://jira.jboss.com/jira/browse/JBREM-543
Project: JBoss Remoting
Issue Type: Task
Security Level: Public(Everyone can see)
Affects Versions: 2.0.0.Beta2 (Boon)
Reporter: Tom Elrod
Assigned To: Tom Elrod
Fix For: 2.0.0.CR1 (Boon)
Need to change the servlet invoker so on client side will not throw an exception out of
the Client's invoke() method call, but just return the error (as text in most cases)
and have the response code indicate the error status code (e.g. 500). Although this is
not exactly how the http invoker handles exceptions from the http server invoker, is only
way to reliably get errors from web containers (like Tomcat).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:58 p.m.
New subject: [JBoss JIRA] Resolved: (JBREM-543) fix servlet invoker error handling to be more like that of the http invoker
[ http://jira.jboss.com/jira/browse/JBREM-543?page=all ]
Tom Elrod resolved JBREM-543.
------------------------------
Resolution: Done
fix servlet invoker error handling to be more like that of the http
invoker
---------------------------------------------------------------------------
Key: JBREM-543
URL: http://jira.jboss.com/jira/browse/JBREM-543
Project: JBoss Remoting
Issue Type: Task
Security Level: Public(Everyone can see)
Affects Versions: 2.0.0.Beta2 (Boon)
Reporter: Tom Elrod
Assigned To: Tom Elrod
Fix For: 2.0.0.CR1 (Boon)
Need to change the servlet invoker so on client side will not throw an exception out of
the Client's invoke() method call, but just return the error (as text in most cases)
and have the response code indicate the error status code (e.g. 500). Although this is
not exactly how the http invoker handles exceptions from the http server invoker, is only
way to reliably get errors from web containers (like Tomcat).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:31 a.m.
New subject: [JBoss JIRA] Closed: (JBREM-543) fix servlet invoker error handling to be more like that of the http invoker
[ http://jira.jboss.com/jira/browse/JBREM-543?page=all ]
David Lloyd closed JBREM-543.
-----------------------------
fix servlet invoker error handling to be more like that of the http
invoker
---------------------------------------------------------------------------
Key: JBREM-543
URL: http://jira.jboss.com/jira/browse/JBREM-543
Project: JBoss Remoting
Issue Type: Task
Security Level: Public(Everyone can see)
Affects Versions: 2.0.0.Beta2 (Boon)
Reporter: Tom Elrod
Assigned To: Tom Elrod
Fix For: 2.0.0.CR1 (Boon)
Need to change the servlet invoker so on client side will not throw an exception out of
the Client's invoke() method call, but just return the error (as text in most cases)
and have the response code indicate the error status code (e.g. 500). Although this is
not exactly how the http invoker handles exceptions from the http server invoker, is only
way to reliably get errors from web containers (like Tomcat).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6580
days inactive
7018
days old
11 comments
3 participants
participants (3)
-
David Lloyd (JIRA) -
John Mazzitelli (JIRA) -
Tom Elrod (JIRA)