[jboss-user] [JBoss AOP] New message: "withincode from JUnit test not working"

User development, A new message was posted in the thread "withincode from JUnit test not working": http://community.jboss.org/message/521123#521123 Author : Alan Nisbet Profile : http://community.jboss.org/people/nizzy Message: -------------------------------------------------------------- Hi Guys,   I have been working on this issue off and on for a while now. Here are my findings, hopefully someone will be able to help me!   Environment ------------------ Standalone Hibernate 3.2.4.GA Standalone JBoss AOP 2.0.1.GA Junit 4.4 Log4j Running via Eclipse 3.3.2   I can successfully do everything I need to use AOP for the purposes of JUnit testing, except using the withincode expression. It will work when I try it from a POJO (non-JUnit class), however nothing I have done so far can get it to intercept a call from within a JUnit test.   I have been using loadtime weaving which made any debugging extremely difficult and so I have updated my project to use compile time weaving, I found this easier to work with.   Initially I suspected the issue may be classpath related, i.e. thought if JUnit archives not on loatime classpath then would the instrumentation of the JUnit class fail, still not sure if this is accurate.   However all I have been able to do this far is repeat the results for both Compile/Load Time Weaving. That is I can intercept call to constructor of class and replace with mock class, etc, however I cannot get withincode to expression to work in conjunction with call expression.   jboss-aop.xml   <?xml version="1.0" encoding="UTF-8"?> <aop>      <bind pointcut="execution(public $typedef{persistenceHelperTypeDef}->new(java.lang.String))">        <interceptor class="com.ecebs.unittest.aop.interceptor.GenericInterceptor">            <attribute name="mockObjectName">MockPersistenceHelper</attribute>        </interceptor>     </bind>     <typedef name="persistenceHelperTypeDef"             expr="class($instanceof{com.ecebs.unittest.aop.IPersistenceHelper})                       AND !class(com.ecebs.unittest.aop.mock.*)" />                     <aspect class="com.ecebs.unittest.aop.aspect.ExceptionInjector" scope="PER_CLASS" />         <bind pointcut="call(public void com.ecebs.unittest.aop.ExampleManagerBean->createObject(..))                              AND withincode(public void com.ecebs.unittest.aop.ExampleManagerBeanTest->testCreateObject_MultefileException())">                                        <advice name="throwMultefileException" aspect="com.ecebs.unittest.aop.aspect.ExceptionInjector" />     </bind>                         </aop>   Output, including verbose aopc info As can be seen from the jboss-aop.xml I'm trying to intercept the call to the ExampleManagerBean->createObject(..) method when called from within the ExamplemanagerBeanTest. I assume that when the aopc output states that a class has been compiled it mean that aop has recognized that instrumentation was required. So from the output I can see that;   Have been instrumented, is this assumption correct?   I use the following ant targets        <target name="aop" depends="compile">           <property name="classes.dir" value="aopclasses" />                      <mkdir dir="${classes.dir}" />                    <!-- copy the classes to a aopclasses directory-->         <copy todir="${classes.dir}">               <fileset dir="build" includes="**/*.class"/>            </copy>                      <!-- copy the jboss-aop.xml to aopclasses directory so can be located at runtime -->         <copy todir="${classes.dir}">               <fileset dir="test" includes="META-INF/*.*"/>            </copy>                 <!-- setup the ant task and the required classpaths -->         <taskdef name="aopc"               classname="org.jboss.aop.ant.AopC"               classpathref="project.class.path"/>                       <path id="jboss.aop.classpath">             <pathelement path="${jboss-aop-2.0.1.GA.dir}/jboss-aop-single.jar"/>         </path>                    <path id="aop.classpath">              <pathelement path="${classes.dir}"/>              <fileset dir="${log4j.dir}" includes="*.jar"/>              <fileset dir="${JUnit4.dir}" includes="*.jar"/>         </path>                         <echo message="Running AOPC target to instrument classes" />                    <!-- instrument the classes with the first call to aopc -->         <aopc compilerclasspathref="jboss.aop.classpath" report="false" verbose="true">                          <!-- define aop classpath - cp for dependant classes in src -->              <classpath refid="aop.classpath"/>                            <!-- define location of classes to be instrumented -->             <src path="${classes.dir}"/>             <include name="**/*.class"/>              <aoppath path="test/META-INF/jboss-aop.xml"/>                       </aopc>       </target>            <path id="test.class.path">           <fileset dir="${jboss-aop-2.0.1.GA.dir}" includes="jboss-aop-single.jar" />           <fileset dir="${log4j.dir}" includes="*.jar" />           <fileset dir="${JUnit4.dir}" includes="*.jar"/>           <fileset dir="${hibernate.dir}" includes="*.jar"/>      </path>            <target name="do-test-junit" depends="aopclean, aop">           <mkdir dir="reports/junit/.xml" />           <junit fork="no" printsummary="yes" haltonfailure="no" errorproperty="test.junit.failed">                <classpath>                     <path path="${classes.dir}" />                     <path refid="test.class.path" />                </classpath>                <formatter type="xml" />                <batchtest todir="reports/junit/.xml">                     <fileset dir="${classes.dir}">                          <include name="**/ExampleManagerBeanTest.class" />                     </fileset>                </batchtest>           </junit>                      <junitreport todir="reports/junit">                <fileset dir="reports/junit/.xml">                     <include name="*.xml" />                </fileset>                <report format="frames" todir="reports/junit" />           </junitreport>      </target>                 <target name="aopclean">           <echo message="cleaning build, aopclasses directory"/>           <delete dir="build"/>           <delete dir="aopclasses"/>      </target>   Please can someone have a look at this issue. Let me know anything I can do that will assist any investigation, i.e. inclusion of code, etc.   It is our intention to use AOP as a tool to improve our unit-testing and so I would really like to be able to solve this issue. I'm at the point I don't have too much more time to spend on it. -------------------------------------------------------------- To reply to this message visit the message page: http://community.jboss.org/message/521123#521123