[JBoss JIRA] (JBTM-1462) Create a script to rebase 5_branch and 4_branch against AS7 master
by Paul Robinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-1462?focusedWorklogId=12428695&page=... ]
Paul Robinson logged work on JBTM-1462:
---------------------------------------
Author: Paul Robinson
Created on: 11/Feb/13 5:36 AM
Start Date: 11/Feb/13 5:36 AM
Worklog Time Spent: 1 hour, 30 minutes
Issue Time Tracking
-------------------
Remaining Estimate: 0 minutes (was: 1 hour, 30 minutes)
Time Spent: 2 hours (was: 30 minutes)
Worklog Id: (was: 12428695)
> Create a script to rebase 5_branch and 4_branch against AS7 master
> ------------------------------------------------------------------
>
> Key: JBTM-1462
> URL: https://issues.jboss.org/browse/JBTM-1462
> Project: JBoss Transaction Manager
> Issue Type: Task
> Security Level: Public(Everyone can see)
> Components: Build System
> Reporter: Paul Robinson
> Assignee: Paul Robinson
> Fix For: 5.0.0.M2
>
> Original Estimate: 2 hours
> Time Spent: 2 hours
> Remaining Estimate: 0 minutes
>
> Rebasing against AS7 master needs to be done regularly, especially when you are making a change that is dependent on a new commit from upstream.
> Doing the rebase is dangerous as it needs a -f. By scripting this, we can hopefully make the operation safer. This is providing the script is reviewed carefully.
> We may also want the script to take a backup of 5_branch prior to the forced update, so that any error can be easily reverted.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 3 months
[JBoss JIRA] (JBTM-1464) Some performance tests are missing the timing code.
by Tom Jenkinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-1464?page=com.atlassian.jira.plugin.... ]
Tom Jenkinson updated JBTM-1464:
--------------------------------
Assignee: Michael Musgrove (was: Tom Jenkinson)
> Some performance tests are missing the timing code.
> ---------------------------------------------------
>
> Key: JBTM-1464
> URL: https://issues.jboss.org/browse/JBTM-1464
> Project: JBoss Transaction Manager
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: Testing, Transaction Core
> Affects Versions: 4.17.3
> Reporter: Mark Little
> Assignee: Michael Musgrove
> Priority: Trivial
>
> The TXOJ performance tests are supposed to get the start time before running and then the end time after completion, printing out the difference. It seems that in several of them, the end time is no longer obtained and nothing is printed out either, i.e., no elapsed time is given. This makes these tests pretty useless as performance tests. Rather than remove the tests, the elapsed time check should be put back.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 3 months
[JBoss JIRA] (JBTM-1465) Performance tests using JDBCStore
by Tom Jenkinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-1465?page=com.atlassian.jira.plugin.... ]
Tom Jenkinson commented on JBTM-1465:
-------------------------------------
It should just be the ArjunaCore/arjuna tests and was added during testing and not reset. txoj should not be affected by this.
I will reset the config and make sure the tests still work with the file system store.
If you need to reset it urgently the file is here: ./ArjunaCore/arjuna/src/test/resources/jbossts-properties.xml
> Performance tests using JDBCStore
> ---------------------------------
>
> Key: JBTM-1465
> URL: https://issues.jboss.org/browse/JBTM-1465
> Project: JBoss Transaction Manager
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: Performance Testing, Transaction Core
> Affects Versions: 4.17.3
> Reporter: Mark Little
> Assignee: Michael Musgrove
>
> Some of the core and txoj performance tests appear to be running against the JDBC object store rather than the default file store. It's possible that this change has been put in place to test the updated JDBC object store, but it should not be the default. It's also possible that it is simply a bug, or inheriting some configuration update from earlier tests. The performance tests should be returned to work against the default file implementation and if necessary new jdbc specific tests added.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 3 months
[JBoss JIRA] (JBTM-1465) Performance tests using JDBCStore
by Mark Little (JIRA)
Mark Little created JBTM-1465:
---------------------------------
Summary: Performance tests using JDBCStore
Key: JBTM-1465
URL: https://issues.jboss.org/browse/JBTM-1465
Project: JBoss Transaction Manager
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: Performance Testing, Transaction Core
Affects Versions: 4.17.3
Reporter: Mark Little
Assignee: Michael Musgrove
Some of the core and txoj performance tests appear to be running against the JDBC object store rather than the default file store. It's possible that this change has been put in place to test the updated JDBC object store, but it should not be the default. It's also possible that it is simply a bug, or inheriting some configuration update from earlier tests. The performance tests should be returned to work against the default file implementation and if necessary new jdbc specific tests added.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 3 months
[JBoss JIRA] (JBTM-1464) Some performance tests are missing the timing code.
by Mark Little (JIRA)
Mark Little created JBTM-1464:
---------------------------------
Summary: Some performance tests are missing the timing code.
Key: JBTM-1464
URL: https://issues.jboss.org/browse/JBTM-1464
Project: JBoss Transaction Manager
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: Testing, Transaction Core
Affects Versions: 4.17.3
Reporter: Mark Little
Assignee: Tom Jenkinson
Priority: Trivial
The TXOJ performance tests are supposed to get the start time before running and then the end time after completion, printing out the difference. It seems that in several of them, the end time is no longer obtained and nothing is printed out either, i.e., no elapsed time is given. This makes these tests pretty useless as performance tests. Rather than remove the tests, the elapsed time check should be put back.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 3 months
[JBoss JIRA] (JBTM-1462) Create a script to rebase 5_branch and 4_branch against AS7 master
by Paul Robinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-1462?page=com.atlassian.jira.plugin.... ]
Paul Robinson updated JBTM-1462:
--------------------------------
Summary: Create a script to rebase 5_branch and 4_branch against AS7 master (was: Create a script to rebase 5_branch against AS7 master)
> Create a script to rebase 5_branch and 4_branch against AS7 master
> ------------------------------------------------------------------
>
> Key: JBTM-1462
> URL: https://issues.jboss.org/browse/JBTM-1462
> Project: JBoss Transaction Manager
> Issue Type: Task
> Security Level: Public(Everyone can see)
> Components: Build System
> Reporter: Paul Robinson
> Assignee: Paul Robinson
> Fix For: 5.0.0.M2
>
> Original Estimate: 2 hours
> Time Spent: 30 minutes
> Remaining Estimate: 1 hour, 30 minutes
>
> Rebasing against AS7 master needs to be done regularly, especially when you are making a change that is dependent on a new commit from upstream.
> Doing the rebase is dangerous as it needs a -f. By scripting this, we can hopefully make the operation safer. This is providing the script is reviewed carefully.
> We may also want the script to take a backup of 5_branch prior to the forced update, so that any error can be easily reverted.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 3 months
[JBoss JIRA] (JBTM-1463) Allow pull requests to test pull requests for the jbosstm fork of jboss-as
by Tom Jenkinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-1463?page=com.atlassian.jira.plugin.... ]
Tom Jenkinson commented on JBTM-1463:
-------------------------------------
you are right in your concern and that is what I am trying to address but ineloquently
I was thinking more about changes to narayana that need a change to jbosstm somehow being able to test both pulls at once.
Maybe we could somehow put convention when you raise a pull request for jbosstm that you can put a comment to say something like:
"requires: https://github.com/jbosstm/jboss-as/pull/217"
We can then somehow use that info in the narayana.sh to pull in that branch rather than 5_BRANCH, what do you think? I know you did some work with using rest to talk to git hub to comment on pulls, could it possibly download the comment for the pull in order to grep it for that info?
> Allow pull requests to test pull requests for the jbosstm fork of jboss-as
> --------------------------------------------------------------------------
>
> Key: JBTM-1463
> URL: https://issues.jboss.org/browse/JBTM-1463
> Project: JBoss Transaction Manager
> Issue Type: Feature Request
> Security Level: Public(Everyone can see)
> Components: Build System
> Reporter: Tom Jenkinson
> Assignee: Paul Robinson
> Fix For: 5.0.0.Final
>
>
> to allow changes to our repo and to pull in changes we need to AS7 but not require those changes to be pushed to 5_BRANCH until they are tested
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 3 months
[JBoss JIRA] (JBTM-1463) Allow pull requests to test pull requests for the jbosstm fork of jboss-as
by Paul Robinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-1463?page=com.atlassian.jira.plugin.... ]
Paul Robinson commented on JBTM-1463:
-------------------------------------
The problem with this is that changes to 5_BRANCH (in my experience, maybe not others') usually need a change to narayana. So you would end up testing two pull requests and both will fail.
Having said that, this is still handy. But I don't think it will allow pull requests to always be used.
> Allow pull requests to test pull requests for the jbosstm fork of jboss-as
> --------------------------------------------------------------------------
>
> Key: JBTM-1463
> URL: https://issues.jboss.org/browse/JBTM-1463
> Project: JBoss Transaction Manager
> Issue Type: Feature Request
> Security Level: Public(Everyone can see)
> Components: Build System
> Reporter: Tom Jenkinson
> Assignee: Paul Robinson
> Fix For: 5.0.0.Final
>
>
> to allow changes to our repo and to pull in changes we need to AS7 but not require those changes to be pushed to 5_BRANCH until they are tested
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 3 months