[ http://jira.jboss.com/jira/browse/JBTM-369?page=all ] Mark Little updated JBTM-369: ----------------------------- Component/s: Configuration -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBTM-369?page=com.atlassian.jira.plugi... ] Dmitri Voronov updated JBTM-369: -------------------------------- Attachment: config-string-replace.jar Here is a solution suggestion -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBTM-369?page=com.atlassian.jira.plugi... ] Dmitri Voronov commented on JBTM-369: ------------------------------------- You are right, the easiest way is to define the system properties in the command line We just used to use this nice feature provided by JBoss and then apply the system properties within the xml based configurations of (almost) all JBoss components like -service.xml, web.xml and -ds.xml. It is also a possibility to define default values (others as those that are hard coded) for the configuration properties e.g.: <property name="com.arjuna.ats.arjuna.xa.nodeIdentifier" value="${my.unique.name:1111}"/> In this case if the deployed application set a specific value my.unique.name then com.arjuna.ats.arjuna.xa.nodeIdentifier is replaced by my.unique.name. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBTM-369?page=com.atlassian.jira.plugi... ] Jonathan Halliday commented on JBTM-369: ---------------------------------------- Hi Sacha Please clearly define what you are trying to achieve. So far nobody has given me a convincing, specific real world use case for this feature. As far as I can tell the existing ability to override values from the config file by specifying system properties is equivalent to value substitution, except for cases where you may want to use the same value for multiple parameters. The only such case I can think of is the IP address, for which we have a separate solution anyhow. With the exceptions of the port bindings (which will be done via SBM), recovery (which will be done via the new tx integration API) and multiple 1PC (which is an horrifically bad idea anyhow), users should not need to change values in the tx properties file. I believe this feature will benefit only a small proportion of users. I agree it's better to have consistent behaviour for the properties files, it makes for a better user experience. But that's secondary to having a product that works. Because of these factors, I consider this issue a low priority. It will get done as and when we have time, but not until e.g. crash recovery and JTS integration are finished. That's why it's still not scheduled against any particular release. Perhaps I'm missing something though. If you feel it's worth taking time out from managing the division to comment on the issue, you must feel it's important. Can you say why? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBTM-369?page=com.atlassian.jira.plugi... ] Jonathan Halliday reassigned JBTM-369: -------------------------------------- Assignee: Jonathan Halliday -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBTM-369?page=com.atlassian.jira.plugi... ] Jonathan Halliday commented on JBTM-369: ---------------------------------------- look to me like it's going to be easier to do the substitution in XMLFilePlugin rather than PropertyManagerImpl, as it needs to apply only to properties read from the config file. Cloning org.jboss.util.StringPropertyReplacer into the com.arjuna.common package may be better than having JBossTS depending on yet another .jar file for just one class. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBTM-369?page=com.atlassian.jira.plugi... ] Work on JBTM-369 stopped by Jonathan Halliday. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira