7:27 a.m.
Hi dear drools team,
I've got a strange problem and hope someone can help me. I'm using drools
5.5.0.
I have some rules to validate user input. These will set the valid flag on a
fact to false and insert a Message fact into working memory that will
contain a message and a reference to the causing fact.
I also have a rule to retract Messages for facts which are not invalid
anymore.
I observe a NullPointerException originating at
DefaultAgenda.createActivation() when I perform following steps:
Insert a valid FirstName and call session.fireAllRules().
Change the FirstName to become invalid, call session.update() on it and call
session.fireAllRules().
The rule for retracting messages is the cause for the problem.
My question is, how can I fix it? Or is there a better way to manage error
messages?
Thank you
--
View this message in context:
http://drools.46999.n3.nabble.com/NullPointerException-when-updating-a-fa...
Sent from the Drools: User forum mailing list archive at Nabble.com.
8:10 a.m.
I have several excellent reasons to doubt that what you have posted is
exactly what you are executing. Please post code that you have
verified to reproduce the issue.
-W
On 29/07/2013, schenka7 <eugen.berenstein(a)gmail.com> wrote:
Hi dear drools team,
I've got a strange problem and hope someone can help me. I'm using drools
5.5.0.
I have some rules to validate user input. These will set the valid flag on
a
fact to false and insert a Message fact into working memory that will
contain a message and a reference to the causing fact.
I also have a rule to retract Messages for facts which are not invalid
anymore.
I observe a NullPointerException originating at
DefaultAgenda.createActivation() when I perform following steps:
Insert a valid FirstName and call session.fireAllRules().
Change the FirstName to become invalid, call session.update() on it and
call
session.fireAllRules().
The rule for retracting messages is the cause for the problem.
My question is, how can I fix it? Or is there a better way to manage error
messages?
Thank you
--
View this message in context:
http://drools.46999.n3.nabble.com/NullPointerException-when-updating-a-fa...
Sent from the Drools: User forum mailing list archive at Nabble.com.
_______________________________________________
rules-users mailing list
rules-users(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-users
2:43 a.m.
I have appended the code that leads to the exception.
I have also noticed that the exception doesn't arise when using the concrete
FirstName type in the retracting rule. I have been using the generic base
class Value because I didn't want to write the same rule for all types
extending from it.
Main.java <http://drools.46999.n3.nabble.com/file/n4025204/Main.java>
validation.drl
<http://drools.46999.n3.nabble.com/file/n4025204/validation.drl>
--
View this message in context:
http://drools.46999.n3.nabble.com/NullPointerException-when-updating-a-fa...
Sent from the Drools: User forum mailing list archive at Nabble.com.
3:50 a.m.
The fact that all of your classes were static was ringing alarm bells, so I tested it
without that.
It works perfectly well if you remove 'static' from everything.
Steve
On 30 Jul 2013, at 08:43, schenka7 <eugen.berenstein(a)gmail.com> wrote:
I have appended the code that leads to the exception.
I have also noticed that the exception doesn't arise when using the concrete
FirstName type in the retracting rule. I have been using the generic base
class Value because I didn't want to write the same rule for all types
extending from it.
Main.java <http://drools.46999.n3.nabble.com/file/n4025204/Main.java>
validation.drl
<http://drools.46999.n3.nabble.com/file/n4025204/validation.drl>
--
View this message in context:
http://drools.46999.n3.nabble.com/NullPointerException-when-updating-a-fa...
Sent from the Drools: User forum mailing list archive at Nabble.com.
_______________________________________________
rules-users mailing list
rules-users(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-users
4:31 a.m.
Hi Steve,
I've removed the classes from Main and put them each in its own file
(FirstName.class, Value.class, ...). This is how I intended it to be in the
first place. And it DOESN'T WORK!
--
View this message in context:
http://drools.46999.n3.nabble.com/NullPointerException-when-updating-a-fa...
Sent from the Drools: User forum mailing list archive at Nabble.com.
5:07 a.m.
It may be worth looking at what exception is being thrown now. You need to ensure that
none of those classes have static flags on them (or the Java won't compile), and the
Message.message method needs to become a constructor instead of some kind of static
factory, so that the RHS of your rule inserts a "new Message(...)". That's
all I needed to do to get it working.
On 30 Jul 2013, at 10:31, schenka7 <eugen.berenstein(a)gmail.com> wrote:
Hi Steve,
I've removed the classes from Main and put them each in its own file
(FirstName.class, Value.class, ...). This is how I intended it to be in the
first place. And it DOESN'T WORK!
--
View this message in context:
http://drools.46999.n3.nabble.com/NullPointerException-when-updating-a-fa...
Sent from the Drools: User forum mailing list archive at Nabble.com.
_______________________________________________
rules-users mailing list
rules-users(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-users
5:40 a.m.
Hi Steven, thanks for your effort, but it still doesn't work.
I have created a constructor for the Message class and removed the factory
as you suggested.
Stephen Masters wrote
You need to ensure that none of those classes have static flags on
them
(or the Java won't compile)
What du you mean by that? If my classes are not inner classes I cant add the
static flag to them anyway.
Is it a requirement for facts to be inner classes?
The stack trace of the exception is as follows:
--
View this message in context:
http://drools.46999.n3.nabble.com/NullPointerException-when-updating-a-fa...
Sent from the Drools: User forum mailing list archive at Nabble.com.
8:46 a.m.
If you wish to see it working, you can grab my maven test harness with your code in here:
git clone -b 2013-07-30-validate-first-name
git@github.com:gratiartis/scattercode-drools-scenarios.git
Just run the test in src/test/java/demos/validate/ValidateTest.java
However, I now know why yours is failing. The project above uses Drools 5.4.0. I'm
guessing that you're using 5.5.0.Final, because if I switch version in my pom.xml,
then I get a NullPointerException. I suspect that you have hit upon one of the many bugs
in 5.5.0.Final.
Steve
On 30 Jul 2013, at 09:50, Stephen Masters <stephen.masters(a)me.com> wrote:
The fact that all of your classes were static was ringing alarm
bells, so I tested it without that.
It works perfectly well if you remove 'static' from everything.
Steve
On 30 Jul 2013, at 08:43, schenka7 <eugen.berenstein(a)gmail.com> wrote:
> I have appended the code that leads to the exception.
>
> I have also noticed that the exception doesn't arise when using the concrete
> FirstName type in the retracting rule. I have been using the generic base
> class Value because I didn't want to write the same rule for all types
> extending from it.
>
> Main.java <http://drools.46999.n3.nabble.com/file/n4025204/Main.java>
> validation.drl
> <http://drools.46999.n3.nabble.com/file/n4025204/validation.drl>
>
>
>
> --
> View this message in context:
http://drools.46999.n3.nabble.com/NullPointerException-when-updating-a-fa...
> Sent from the Drools: User forum mailing list archive at Nabble.com.
> _______________________________________________
> rules-users mailing list
> rules-users(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/rules-users
_______________________________________________
rules-users mailing list
rules-users(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-users
9:10 a.m.
This is a regression that happened on the way from 5.3.0 to 5.4.0.
Apparently it is the extension of the generic class
public class FirstName extends Value<String> { }
that causes the NPE (in 5.5.0) and an unsupported operation exception
in 5.4.0. 5.2.0 and 5.3.0 handle this correctly, 5.1.1 seems to have a
restriction (can't regex-match an Object) but at least it doesn't
crash.
There is indeed a sad decline in quality on the path leading to 5.5.0...
-W
On 30/07/2013, Stephen Masters <stephen.masters(a)me.com> wrote:
If you wish to see it working, you can grab my maven test harness
with your
code in here:
git clone -b 2013-07-30-validate-first-name
git@github.com:gratiartis/scattercode-drools-scenarios.git
Just run the test in src/test/java/demos/validate/ValidateTest.java
However, I now know why yours is failing. The project above uses Drools
5.4.0. I'm guessing that you're using 5.5.0.Final, because if I switch
version in my pom.xml, then I get a NullPointerException. I suspect that you
have hit upon one of the many bugs in 5.5.0.Final.
Steve
On 30 Jul 2013, at 09:50, Stephen Masters <stephen.masters(a)me.com> wrote:
> The fact that all of your classes were static was ringing alarm bells, so
> I tested it without that.
>
> It works perfectly well if you remove 'static' from everything.
>
> Steve
>
>
> On 30 Jul 2013, at 08:43, schenka7 <eugen.berenstein(a)gmail.com> wrote:
>
>> I have appended the code that leads to the exception.
>>
>> I have also noticed that the exception doesn't arise when using the
>> concrete
>> FirstName type in the retracting rule. I have been using the generic
>> base
>> class Value because I didn't want to write the same rule for all types
>> extending from it.
>>
>> Main.java <http://drools.46999.n3.nabble.com/file/n4025204/Main.java>
>> validation.drl
>> <http://drools.46999.n3.nabble.com/file/n4025204/validation.drl>
>>
>>
>>
>> --
>> View this message in context:
>>
http://drools.46999.n3.nabble.com/NullPointerException-when-updating-a-fa...
>> Sent from the Drools: User forum mailing list archive at Nabble.com.
>> _______________________________________________
>> rules-users mailing list
>> rules-users(a)lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/rules-users
>
>
> _______________________________________________
> rules-users mailing list
> rules-users(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/rules-users
_______________________________________________
rules-users mailing list
rules-users(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-users
9:18 a.m.
Thank you Steve, you are right. It was a bug in the 5.5.0.Final.
After I switched to 5.4.0.Final it started to work.
I was suspecting that the newer version is the one with the most bug fixes.
Apparently I was wrong.
Which version of Drools would you recommend?
--
View this message in context:
http://drools.46999.n3.nabble.com/NullPointerException-when-updating-a-fa...
Sent from the Drools: User forum mailing list archive at Nabble.com.
10:06 a.m.
So far I have stuck with 5.3.0. It's not perfect, but I have found it pretty good and
reliable.
I think that 5.4.0 was a reasonable improvement, but I haven't used it in anger. For
me, there wasn't enough improvement in it from 5.3 to merit spending time on an
upgrade, so I was waiting for 5.5.0. Maybe others could chime in on that one.
I did spend time upgrading my 5.3 project to 5.5.0, because it looked so promising. But I
encountered several critical bugs which meant that large chunks of Guvnor functionality
just didn't work. I fell back to 5.3.0 again.
I'm really hoping to see 5.5.1 before too long, but I think that it has been "a
couple of weeks away" for the past 6 months, so I'm not holding my breath. :)
Given the extent of change in 6, I wouldn't recommend going anywhere near it unless
you're just tinkering with it in your own time to see where things are going. I'm
doing that myself at the moment, but it's hard work given the lack of documentation or
books. I suspect that we'll be hit by a big wave of books on it before long!
So I guess that if I was starting a new project for a client, I would probably go with
5.4.0.Final.
Steve
On 30 Jul 2013, at 15:18, schenka7 <eugen.berenstein(a)gmail.com> wrote:
Thank you Steve, you are right. It was a bug in the 5.5.0.Final.
After I switched to 5.4.0.Final it started to work.
I was suspecting that the newer version is the one with the most bug fixes.
Apparently I was wrong.
Which version of Drools would you recommend?
--
View this message in context:
http://drools.46999.n3.nabble.com/NullPointerException-when-updating-a-fa...
Sent from the Drools: User forum mailing list archive at Nabble.com.
_______________________________________________
rules-users mailing list
rules-users(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-users
11:53 a.m.
I confirm the UnsupportedOperationException in 5.4.0. It was thrown when I
added a second rule to the rule base. 5.3.0 did work correctly.
Thank you for the listing.
--
View this message in context:
http://drools.46999.n3.nabble.com/NullPointerException-when-updating-a-fa...
Sent from the Drools: User forum mailing list archive at Nabble.com.
2:36 a.m.
5.6 already solves the NPE with this particular ruleset.
It is ready to be released, one last issue pending.
It will likely be the last of the 5.x series.. anyone willing to give it
a try
is more than welcome
Davide
On 07/30/2013 08:06 AM, Stephen Masters wrote:
So far I have stuck with 5.3.0. It's not perfect, but I have
found it pretty good and reliable.
I think that 5.4.0 was a reasonable improvement, but I haven't used it in anger. For
me, there wasn't enough improvement in it from 5.3 to merit spending time on an
upgrade, so I was waiting for 5.5.0. Maybe others could chime in on that one.
I did spend time upgrading my 5.3 project to 5.5.0, because it looked so promising. But I
encountered several critical bugs which meant that large chunks of Guvnor functionality
just didn't work. I fell back to 5.3.0 again.
I'm really hoping to see 5.5.1 before too long, but I think that it has been "a
couple of weeks away" for the past 6 months, so I'm not holding my breath. :)
Given the extent of change in 6, I wouldn't recommend going anywhere near it unless
you're just tinkering with it in your own time to see where things are going. I'm
doing that myself at the moment, but it's hard work given the lack of documentation or
books. I suspect that we'll be hit by a big wave of books on it before long!
So I guess that if I was starting a new project for a client, I would probably go with
5.4.0.Final.
Steve
On 30 Jul 2013, at 15:18, schenka7 <eugen.berenstein(a)gmail.com> wrote:
> Thank you Steve, you are right. It was a bug in the 5.5.0.Final.
> After I switched to 5.4.0.Final it started to work.
>
> I was suspecting that the newer version is the one with the most bug fixes.
> Apparently I was wrong.
> Which version of Drools would you recommend?
>
>
>
> --
> View this message in context:
http://drools.46999.n3.nabble.com/NullPointerException-when-updating-a-fa...
> Sent from the Drools: User forum mailing list archive at Nabble.com.
> _______________________________________________
> rules-users mailing list
> rules-users(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/rules-users
_______________________________________________
rules-users mailing list
rules-users(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-users
2:53 a.m.
Ids there any 5.6.0-x with x != Final to be downloaded?
-W
On 31/07/2013, Davide Sottara <dsotty(a)gmail.com> wrote:
5.6 already solves the NPE with this particular ruleset.
It is ready to be released, one last issue pending.
It will likely be the last of the 5.x series.. anyone willing to give it
a try
is more than welcome
Davide
On 07/30/2013 08:06 AM, Stephen Masters wrote:
> So far I have stuck with 5.3.0. It's not perfect, but I have found it
> pretty good and reliable.
>
> I think that 5.4.0 was a reasonable improvement, but I haven't used it in
> anger. For me, there wasn't enough improvement in it from 5.3 to merit
> spending time on an upgrade, so I was waiting for 5.5.0. Maybe others
> could chime in on that one.
>
> I did spend time upgrading my 5.3 project to 5.5.0, because it looked so
> promising. But I encountered several critical bugs which meant that large
> chunks of Guvnor functionality just didn't work. I fell back to 5.3.0
> again.
>
> I'm really hoping to see 5.5.1 before too long, but I think that it has
> been "a couple of weeks away" for the past 6 months, so I'm not holding
my
> breath. :)
>
> Given the extent of change in 6, I wouldn't recommend going anywhere near
> it unless you're just tinkering with it in your own time to see where
> things are going. I'm doing that myself at the moment, but it's hard work
> given the lack of documentation or books. I suspect that we'll be hit by a
> big wave of books on it before long!
>
> So I guess that if I was starting a new project for a client, I would
> probably go with 5.4.0.Final.
>
> Steve
>
>
> On 30 Jul 2013, at 15:18, schenka7 <eugen.berenstein(a)gmail.com> wrote:
>
>> Thank you Steve, you are right. It was a bug in the 5.5.0.Final.
>> After I switched to 5.4.0.Final it started to work.
>>
>> I was suspecting that the newer version is the one with the most bug
>> fixes.
>> Apparently I was wrong.
>> Which version of Drools would you recommend?
>>
>>
>>
>> --
>> View this message in context:
>>
http://drools.46999.n3.nabble.com/NullPointerException-when-updating-a-fa...
>> Sent from the Drools: User forum mailing list archive at Nabble.com.
>> _______________________________________________
>> rules-users mailing list
>> rules-users(a)lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/rules-users
>
> _______________________________________________
> rules-users mailing list
> rules-users(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/rules-users
>
_______________________________________________
rules-users mailing list
rules-users(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-users
3 a.m.
Seems they forgot to put 5.6 on CI.. I've asked a few times, with little
success :(
I'll try again.
Otherwise, one would have to download the source code and build it locally
On 07/31/2013 12:53 AM, Wolfgang Laun wrote:
Ids there any 5.6.0-x with x != Final to be downloaded?
-W
On 31/07/2013, Davide Sottara <dsotty(a)gmail.com> wrote:
> 5.6 already solves the NPE with this particular ruleset.
> It is ready to be released, one last issue pending.
> It will likely be the last of the 5.x series.. anyone willing to give it
> a try
> is more than welcome
> Davide
>
>
> On 07/30/2013 08:06 AM, Stephen Masters wrote:
>> So far I have stuck with 5.3.0. It's not perfect, but I have found it
>> pretty good and reliable.
>>
>> I think that 5.4.0 was a reasonable improvement, but I haven't used it in
>> anger. For me, there wasn't enough improvement in it from 5.3 to merit
>> spending time on an upgrade, so I was waiting for 5.5.0. Maybe others
>> could chime in on that one.
>>
>> I did spend time upgrading my 5.3 project to 5.5.0, because it looked so
>> promising. But I encountered several critical bugs which meant that large
>> chunks of Guvnor functionality just didn't work. I fell back to 5.3.0
>> again.
>>
>> I'm really hoping to see 5.5.1 before too long, but I think that it has
>> been "a couple of weeks away" for the past 6 months, so I'm not
holding my
>> breath. :)
>>
>> Given the extent of change in 6, I wouldn't recommend going anywhere near
>> it unless you're just tinkering with it in your own time to see where
>> things are going. I'm doing that myself at the moment, but it's hard
work
>> given the lack of documentation or books. I suspect that we'll be hit by a
>> big wave of books on it before long!
>>
>> So I guess that if I was starting a new project for a client, I would
>> probably go with 5.4.0.Final.
>>
>> Steve
>>
>>
>> On 30 Jul 2013, at 15:18, schenka7 <eugen.berenstein(a)gmail.com> wrote:
>>
>>> Thank you Steve, you are right. It was a bug in the 5.5.0.Final.
>>> After I switched to 5.4.0.Final it started to work.
>>>
>>> I was suspecting that the newer version is the one with the most bug
>>> fixes.
>>> Apparently I was wrong.
>>> Which version of Drools would you recommend?
>>>
>>>
>>>
>>> --
>>> View this message in context:
>>>
http://drools.46999.n3.nabble.com/NullPointerException-when-updating-a-fa...
>>> Sent from the Drools: User forum mailing list archive at Nabble.com.
>>> _______________________________________________
>>> rules-users mailing list
>>> rules-users(a)lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/rules-users
>> _______________________________________________
>> rules-users mailing list
>> rules-users(a)lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/rules-users
>>
> _______________________________________________
> rules-users mailing list
> rules-users(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/rules-users
>
_______________________________________________
rules-users mailing list
rules-users(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-users
3937
days inactive
3939
days old
14 comments
4 participants
participants (4)
-
Davide Sottara -
schenka7 -
Stephen Masters -
Wolfgang Laun