[Regression] 3.1.0.Beta4 eats exceptions in IdentityImpl + returns RESPONSE_LOGIN_FAILED
instead of RESPONSE_LOGIN_EXCEPTION
----------------------------------------------------------------------------------------------------------------------------
Key: SEAMSECURITY-121
URL:
https://issues.jboss.org/browse/SEAMSECURITY-121
Project: Seam Security
Issue Type: Bug
Affects Versions: 3.1.0.Beta4
Reporter: Geoffrey De Smet
Priority: Critical
Fix For: 3.1.0.Beta5
org.jboss.seam.security.IdentityImpl#authenticate line 237 eats exceptions:
{code}
} catch (Exception ex) {
authenticating = false;
if (ex instanceof AuthenticationException) throw (AuthenticationException)
ex;
return false;
}
{code}
As a result, my @PostConstruct weld exception isn't show in the log between these 2
lines:
{code}
INFO 26-10 12:05:00,849 (DemoAuthenticator.java:authenticate:65) Demo login for user
(admin) succeeded.
INFO 26-10 12:39:19,825 (SecurityServiceImpl.java:login:70) Logging in user [admin]
{code}
Extra bug:
{code}
public String login() {
try {
...
boolean success = authenticate();
...
return RESPONSE_LOGIN_FAILED;
} catch (Exception ex) { // Doesn't happen any more because authenticate() eat
the exception
...
return RESPONSE_LOGIN_EXCEPTION;
}
}
{code}
Regression since Beta3 in Beta4.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see:
http://www.atlassian.com/software/jira