[jbossseam-issues] [JBoss JIRA] Resolved: (JBSEAM-3747) Boolean tests during Initialization consistent with JDK

Boolean tests during Initialization consistent with JDK ------------------------------------------------------- Key: JBSEAM-3747 URL: https://jira.jboss.org/jira/browse/JBSEAM-3747 Project: Seam Issue Type: Patch Components: Core Affects Versions: 2.1.1.CR1 Reporter: Anthony Whitford Assignee: Shane Bryzak Priority: Minor Fix For: 2.1.1.CR2 Attachments: JBSEAM-3747.patch I noticed code like: boolean autoCreate = "true".equals(factory.attributeValue("auto-create")); Java already has some boolean semantics that I would expect to be leveraged for consistency. The line could be replaced with: boolean autoCreate = Boolean.parseBoolean(factory.attributeValue("auto-create")); There is a subtle difference in that parseBoolean will do a case insensitive comparison, but at least this is consistent with core Java. See: http://java.sun.com/javase/6/docs/api/java/lang/Boolean.html#parseBoolean... and: http://java.sun.com/javase/6/docs/api/java/lang/Boolean.html#valueOf(java... The above change also removes "magic values" repeated ("true"). Very minor issue, but also easy to fix.