[ http://jira.jboss.com/jira/browse/JBSEAM-2542?page=all ] Mark Schmatz updated JBSEAM-2542: --------------------------------- Description: Seam-gen generates the following code in the menu.xhtml page: <s:link view="/home.xhtml" action="#{identity.logout}" value="Logout" rendered="#{identity.loggedIn}"/> We have here both, the 'view' and the 'action' attributes at the same time. Is this well-defined? I would propose to discard the 'view' attribute and replace the EL in the 'action' attribute with: #{authenticator.logout} Additionally, in the Authenticator class the logout method should be provided (automatically generated by Seam-gen) which invokes 'identity.logout(). In the pages.xml a respective navigation to the "/home.xhtml" page should be performed. The advantage - besides having a proper s:link - is that one can do additional stuff in the logout method before and/or after logging out. was: Seam-gen generates the following code in the menu.xhtml page: <s:link view="/home.xhtml" action="#{identity.logout}" value="Logout" rendered="#{identity.loggedIn}"/> We have here both, the 'view' and the 'action' attribute at the same time. Is this well-defined? I would propose to discard the 'view' attribute and replace the EL in the 'action' attribute with: #{authenticator.logout} Additionally, in the Authenticator class the logout method should be provided (automatically generated by Seam-gen) which invokes 'identity.logout(). In the pages.xml a respective navigation to the "/home.xhtml" page should be performed. The advantage - besides having a proper s:link - is that one can do additional stuff in the logout method before and/or after logging out. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBSEAM-2542?page=all ] Mark Schmatz updated JBSEAM-2542: --------------------------------- Component/s: Tools -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBSEAM-2542?page=comments#action_12397103 ] Pete Muir commented on JBSEAM-2542: ----------------------------------- 1) The semantics are well defined, but not documented. We should fix this. 2) -1. seam-gen is a simple structure for you to extend. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBSEAM-2542?page=all ] Pete Muir updated JBSEAM-2542: ------------------------------ Summary: Document semantics of s:link with view and action (was: Seam-gen generates false s:link in menu.xhtml (the logout link)) Issue Type: Task (was: Bug) Component/s: Documentation (was: Tools) Fix Version/s: 2.0.1.GA Priority: Optional (was: Major) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBSEAM-2542?page=all ] Pete Muir resolved JBSEAM-2542. ------------------------------- Fix Version/s: 2.1.0.GA Resolution: Done -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira