[ http://jira.jboss.com/jira/browse/JBSEAM-1911?page=all ] Wolfgang Schwendt updated JBSEAM-1911: -------------------------------------- Attachment: UISeamCommandBase.java modified org.jboss.seam.ui.component.UISeamCommandBase based on CVS Rev 1.8 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBSEAM-1911?page=comments#action_12376022 ] Wolfgang Schwendt commented on JBSEAM-1911: ------------------------------------------- The patch reveals another problem which was not noticed before: In order to determine which row is selected org.jboss.seam.ui.component.UISelection.getValue() looks up the DataModel via Contexts.lookupInStatefulContexts(getDataModel()), where getDataModel() yields the name of the DataModel. (The dataModel property of UISelection is set by UISeamCommandBase.getSelection() ). The problem occurs when the ValueExpression for the value property of the DataTable control is an EL path expression with 2 or more parts, e.g. something like #{baseObject.dataModel}. Then UISeamCommandBase.getSelection() simply takes "baseObject.dataModel" as the name of the DataModel. Consequently the DataModel is not found by the Context lookup in UISelection.getValue(), because to successfully lookup the DataModel, UISelection.getValue() would actually have to evaluate the ValueExpression for the value property of the DataTable control. And because the DataModel is not found by UISelection.getValue(), the URL generated by an <s:link> or <s:button> shows a request parameter "dataModelSelection" with an empty value (dataModelSelection=) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBSEAM-1911?page=all ] Wolfgang Schwendt closed JBSEAM-1911. ------------------------------------- Resolution: Deferred Please ignore this Trinidad integration issue for now, even though a good integration with the leading JSF component suites and thus also the Trinidad components remains of course desirable. Although my submitted patch leads to the inclusion of the "dataModelSelection" request parameter to URLs generated by the <s:button> or <s:link> control when these controls are embedded into a Trinidad <tr:table>, it reveals other complicated problems in combination with the org.jboss.seam.trinidad.SeamCollectionModel, org.jboss.seam.trinidad.TrinidadDataModels and EntityQueries of the Seam CRUD framework. After analyzing the code of org.jboss.seam.trinidad.SeamCollectionModel, UISeamCommandBase, org.jboss.seam.ui.component.html.HtmlSelection etc., I reached the conclusion that from an app design standpoint, it's probably not the best solution anyway to use an s:button or s:link (and thus a non-faces rather than a faces request!) for submission of the dataModelSelection. What's more, in many (or even most?) cases when an <s:link> or <s:button> is embedded into a DataTable, the addition of the "dataModelSelection" request parameter is actually not needed. Seam renders the dataModelSelection request parameter by default; there is unfortunately no way to specify that the addition of this request parameter should be omitted in order to produce cleaner request URLs. In fact, it would make sense and be highly desirable not to add the dataModelSelection request parameter by default, and if the framework user wants a data model propagation for a specific instance of an s:link or s:button control, he would explicitly have to specify that. For example, we could introduce an attribute to a the <s:link> element such as <s:link name="..." value="..." dataModelSelectionPropagation="true"/> to specify that the generated request URL should contain a request parameter for the data model selection propagation, otherwise no request parameter for the data model selection would be rendered. I'll therefore close this case for now, given that it could be easily reopened. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira