August 2007 - seam-issues - Jboss List Archives

[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-1752) Imbalanced calls to MailFacesContextImpl.start(), MailFacesContextImpl.stop() possible

by Michal Ruzicka (JIRA)

Imbalanced calls to MailFacesContextImpl.start(), MailFacesContextImpl.stop() possible -------------------------------------------------------------------------------------- Key: JBSEAM-1752 URL: http://jira.jboss.com/jira/browse/JBSEAM-1752 Project: JBoss Seam Issue Type: Bug Components: Mail Affects Versions: 2.0.0.BETA1 Environment: Windows XP; JBoss 4.2.1.GA Reporter: Michal Ruzicka Assigned To: Pete Muir MailFacesContextImpl.stop() is NOT called if there is an exception thrown during execution of UIMessage.encodeChildren() (this may happen for example if an invalid e-mail address is passed to the <m:to> tag). This leaves the MailFacesContextImpl as the current FacesContext with all sorts of negative consequences on rendering of the view that was being rendered before the rendering of the <m:message> started. The included patch solved the problem for me. WARNING: The patch was created without any in-depth knowledge of Seam functioning so please review CAREFULLY. diff -Naur jboss-seam-2.0.0.BETA1.orig/src/mail/org/jboss/seam/mail/ui/UIMessage.java jboss-seam-2.0.0.BETA1/src/mail/org/jboss/seam/mail/ui/UIMessage.java --- jboss-seam-2.0.0.BETA1.orig/src/mail/org/jboss/seam/mail/ui/UIMessage.java 2007-06-27 08:37:14.000000000 +0200 +++ jboss-seam-2.0.0.BETA1/src/mail/org/jboss/seam/mail/ui/UIMessage.java 2007-08-01 22:20:08.000000000 +0200 @@ -84,8 +84,6 @@ @Override public void encodeBegin(FacesContext context) throws IOException { - MailFacesContextImpl.start(getUrlBase() - + context.getExternalContext().getRequestContextPath()); mimeMessage = null; try { @@ -137,10 +135,6 @@ { throw new FacesException(e.getMessage(), e); } - finally - { - MailFacesContextImpl.stop(); - } } @Override @@ -152,7 +146,15 @@ @Override public void encodeChildren(FacesContext context) throws IOException { - JSF.renderChildren(FacesContext.getCurrentInstance(), this); + MailFacesContextImpl.start(getUrlBase() + + context.getExternalContext().getRequestContextPath()); + try { + JSF.renderChildren(FacesContext.getCurrentInstance(), this); + } + finally + { + MailFacesContextImpl.stop(); + } } public String getImportance() -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

18 years, 8 months

2
3
0 / 0

[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-1725) <s:convertEntity> doesn't work when using binding instead of value

by Dan Hinojosa (JIRA)

<s:convertEntity> doesn't work when using binding instead of value ------------------------------------------------------------------ Key: JBSEAM-1725 URL: http://jira.jboss.com/jira/browse/JBSEAM-1725 Project: JBoss Seam Issue Type: Bug Components: JSF Affects Versions: 2.0.0.BETA1 Environment: XP, Jboss 4.2.0, Seam 2.0.0Beta1, Java 6u2 Reporter: Dan Hinojosa If I have some tags like this... <h:selectOneMenu id="employeeMenu" binding="#{departmentmanager.employee}"> <s:selectItems var="employee" value="#{department.employees}" label="#{employee.name}" /> <a4j:support event="onchange"/> <s:convertEntity /> </h:selectOneMenu> the <s:convertEntity /> doesn't work when trying to bind the object, it works fine if I have <h:selectOneMenu id="employeeMenu" value="#{departmentmanager.employee}"> but not... <h:selectOneMenu id="employeeMenu" binding="#{departmentmanager.employee}"> -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

18 years, 8 months

2
6
0 / 0

[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-1705) update i18n docs

by Gavin King (JIRA)

update i18n docs ---------------- Key: JBSEAM-1705 URL: http://jira.jboss.com/jira/browse/JBSEAM-1705 Project: JBoss Seam Issue Type: Task Components: Documentation Affects Versions: 2.0.0.CR1 Reporter: Gavin King Priority: Minor Fix For: 2.0.0.CR1 Document the redesigned approach to resource bundle stuff. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

18 years, 8 months

2
2
0 / 0

[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-1719) UrlBuilder doesnt construct a correct url when the base url already has request params in place.

by Chris Rudd (JIRA)

UrlBuilder doesnt construct a correct url when the base url already has request params in place. ------------------------------------------------------------------------------------------------ Key: JBSEAM-1719 URL: http://jira.jboss.com/jira/browse/JBSEAM-1719 Project: JBoss Seam Issue Type: Bug Components: Core Affects Versions: 2.0.0.BETA1 Reporter: Chris Rudd Given the following test case : @Test public void testBaseUrlAlreadyHasParams() { UrlBuilder url = new UrlBuilder("/someurl?arg1=a", ""); url.addParameter("foo", "bar"); String encodedUrl = url.getEncodedUrl(); Assert.assertEqual( encodedUrl, "/someurl?arg1=a&foo=bar" ); } The following patch fixes the issue. UrlBuilder.java line 62 protected String getParametersAsString() { String params = ""; for (String key : parameters.keySet()) { params += "&" + key + "=" + parameters.get(key); } - if (!"".equals(params)) + // repace the first "&" with a "?" if there are parameters and the url doesnt already contain a "?" + if (!".equals(params) && (url!=null && !url.contains("?")) { params = "?" + params.substring(1); } return params; } NOTE: This condition occurs when using <s:link/> in a portlet, as the portlet returns a url with parameters already added to the url. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

18 years, 8 months

2
4
0 / 0

[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-1702) <s:entityConverter> gives NPE

by Dan Hinojosa (JIRA)

<s:entityConverter> gives NPE ----------------------------- Key: JBSEAM-1702 URL: http://jira.jboss.com/jira/browse/JBSEAM-1702 Project: JBoss Seam Issue Type: Bug Components: Framework Affects Versions: 2.0.0.BETA1 Environment: XP, Cygwin, 4.2 Jboss, mysql 5.0 + driver Reporter: Dan Hinojosa Using <s:entityConverter> on my app I get a NPE: javax.servlet.ServletException javax.faces.webapp.FacesServlet.service(FacesServlet.java:256) org.ajax4jsf.framework.ajax.xmlfilter.BaseXMLFilter.doXmlFilter(BaseXMLFilter.java:127) org.ajax4jsf.framework.ajax.xmlfilter.BaseFilter.doFilter(BaseFilter.java:277) org.jboss.web.tomcat.filters.ReplyHeaderFilter.doFilter(ReplyHeaderFilter.java:96) ROOT CAUSE: java.lang.NullPointerException org.jboss.seam.ui.converter.EntityConverter.getAsString(EntityConverter.java:69) org.jboss.seam.ui.converter.PrioritizableConverter.getAsString(PrioritizableConverter.java:67) org.jboss.seam.ui.converter.ConverterChain.getAsString(ConverterChain.java:123) com.sun.faces.renderkit.html_basic.HtmlBasicRenderer.getFormattedValue(HtmlBasicRenderer.java:469) com.sun.faces.renderkit.html_basic.MenuRenderer.renderOption(MenuRenderer.java:502) com.sun.faces.renderkit.html_basic.MenuRenderer.renderOptions(MenuRenderer.java:757) com.sun.faces.renderkit.html_basic.MenuRenderer.renderSelect(MenuRenderer.java:811) com.sun.faces.renderkit.html_basic.MenuRenderer.encodeEnd(MenuRenderer.java:335) javax.faces.component.UIComponentBase.encodeEnd(UIComponentBase.java:833) org.ajax4jsf.framework.renderer.RendererBase.renderChild(RendererBase.java:286) org.ajax4jsf.framework.renderer.RendererBase.renderChildren(RendererBase.java:262) org.ajax4jsf.framework.renderer.AjaxContainerRenderer.encodeChildren(AjaxContainerRenderer.java:100 ) javax.faces.component.UIComponentBase.encodeChildren(UIComponentBase.java:809) org.ajax4jsf.ajax.UIAjaxRegion.encodeChildren(UIAjaxRegion.java:117) javax.faces.component.UIComponent.encodeAll(UIComponent.java:886) javax.faces.render.Renderer.encodeChildren(Renderer.java:137) javax.faces.component.UIComponentBase.encodeChildren(UIComponentBase.java:809) javax.faces.component.UIComponent.encodeAll(UIComponent.java:886) javax.faces.component.UIComponent.encodeAll(UIComponent.java:892) com.sun.faces.application.ViewHandlerImpl.doRenderView(ViewHandlerImpl.java:244) com.sun.faces.application.ViewHandlerImpl.renderView(ViewHandlerImpl.java:175) org.ajax4jsf.framework.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:108) org.ajax4jsf.framework.ajax.AjaxViewHandler.renderView(AjaxViewHandler.java:233) org.jboss.seam.jsf.SeamViewHandler.renderView(SeamViewHandler.java:87) org.ajax4jsf.framework.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:108) org.ajax4jsf.framework.ajax.AjaxViewHandler.renderView(AjaxViewHandler.java:233) com.sun.faces.lifecycle.RenderResponsePhase.execute(RenderResponsePhase.java:106) com.sun.faces.lifecycle.LifecycleImpl.phase(LifecycleImpl.java:251) com.sun.faces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:144) javax.faces.webapp.FacesServlet.service(FacesServlet.java:245) org.ajax4jsf.framework.ajax.xmlfilter.BaseXMLFilter.doXmlFilter(BaseXMLFilter.java:127) org.ajax4jsf.framework.ajax.xmlfilter.BaseFilter.doFilter(BaseFilter.java:277) org.jboss.web.tomcat.filters.ReplyHeaderFilter.doFilter(ReplyHeaderFilter.java:96) I think I tracked it down to EntityConverter.java. The create() never gets invoked private ValueExpression<EntityManager> entityManager; private EntityConverterStore entityIdentifierStore; @Create public void create() { entityIdentifierStore = EntityConverterStore.instance(); } -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

18 years, 8 months

2
7
0 / 0

[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-1697) Documentation build is broken

by Christian Bauer (JIRA)

Documentation build is broken ----------------------------- Key: JBSEAM-1697 URL: http://jira.jboss.com/jira/browse/JBSEAM-1697 Project: JBoss Seam Issue Type: Bug Components: Documentation Reporter: Christian Bauer Priority: Blocker ant refdoc builds all the artifacts, though in the wrong directory: doc/reference/build/build/ The last step in ant refdoc however deletes everything: lang.htmlmisc: [copy] Copying 40 files to /Users/turin/work/remote/jboss/public/jboss-seam/doc/reference/build/build/en/shared/images [copy] Copying 1 file to /Users/turin/work/remote/jboss/public/jboss-seam/doc/reference/build/build/en/shared/css [copy] Copying 76 files to /Users/turin/work/remote/jboss/public/jboss-seam-20070719.1036/doc/reference [delete] Deleting directory /Users/turin/work/remote/jboss/public/jboss-seam/doc/reference/build I don't want to bookmark the stuff in the random number distribution directory (which I think is a horrible idea anyway). I want to be able to call 'ant refdoc' and then open my bookmark. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

18 years, 8 months

2
3
0 / 0

[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-1686) s:button image does not copy image URL to output

by henrik lindberg (JIRA)

s:button image does not copy image URL to output ------------------------------------------------ Key: JBSEAM-1686 URL: http://jira.jboss.com/jira/browse/JBSEAM-1686 Project: JBoss Seam Issue Type: Bug Affects Versions: 2.0.0.GA Environment: Same 2.0.0.GA, JBoss 4.2.1.GA Reporter: henrik lindberg Priority: Critical An s:button with attribute image= does not output the image src URL to the result. The type is set to "image" but the src URL is lost. Think that something like if (button.getImage() != null) { writer.writeAttribute(HTML.SRC_ATTR, button.getImage(), HTML.SRC_ATTR); } is required in Button RendererBase.java -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

18 years, 8 months

2
5
0 / 0

[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-1638) Seam 2.0.0.BETA1 EL (& Ajax4JSF) problem

by Kenneth Christensen (JIRA)

Seam 2.0.0.BETA1 EL (& Ajax4JSF) problem ---------------------------------------- Key: JBSEAM-1638 URL: http://jira.jboss.com/jira/browse/JBSEAM-1638 Project: JBoss Seam Issue Type: Bug Components: EL Affects Versions: 2.0.0.BETA1 Environment: Mac OS X 10.4.10 --- java version "1.5.0_07" Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_07-164) Java HotSpot(TM) Client VM (build 1.5.0_07-87, mixed mode, sharing) --- JBoss AS 4.2.0.GA JBoss Seam 2.0.0.BETA1 JBoss Ajax4JSF 1.1.1 Facelest 1.1.11 Reporter: Kenneth Christensen Please read: http://www.jboss.com/index.html?module=bb&op=viewtopic&t=113031 (look after 'msystems') and look at the example - see attached file. bug/src/action/com/mediatorsystems/bug/Bug.java bug/src/action/com/mediatorsystems/bug/Data.java bug/view/bug.xhtml http://localhost:8080/bug/bug.seam -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

18 years, 8 months

2
5
0 / 0

[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-1617) DVD Store Tomcat deployment is broken

by Gavin King (JIRA)

DVD Store Tomcat deployment is broken ------------------------------------- Key: JBSEAM-1617 URL: http://jira.jboss.com/jira/browse/JBSEAM-1617 Project: JBoss Seam Issue Type: Bug Components: Examples Affects Versions: 2.0.0.CR1 Reporter: Gavin King Assigned To: Pete Muir Fix For: 2.0.0.CR1 I assume that this is due to the new build, though I don't know that for sure. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

18 years, 8 months

2
3
0 / 0

[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-1595) EnumConverter NPE when missing value

by Magnus Sandberg (JIRA)

EnumConverter NPE when missing value ------------------------------------ Key: JBSEAM-1595 URL: http://jira.jboss.com/jira/browse/JBSEAM-1595 Project: JBoss Seam Issue Type: Bug Components: Framework Affects Versions: 2.0.0.BETA1 Reporter: Magnus Sandberg If the Component using the EnumConverter is missing an value-expr the 'expr' below will be null and and NPE will be thrown at line 17. expr should be checked for <null> before any call to getType(). -- (15) ValueExpression expr = comp.getValueExpression("value"); (16) (17) Class enumType = expr.getType(context.getELContext()); -- -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

18 years, 8 months

2
3
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

seam-issues August 2007