April 2008 - seam-issues - Jboss List Archives

[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-2619) Appended conversation id in UILoadStyle prevents caching of dynamically included CSS

by Christian Bauer (JIRA)

Appended conversation id in UILoadStyle prevents caching of dynamically included CSS ------------------------------------------------------------------------------------ Key: JBSEAM-2619 URL: http://jira.jboss.com/jira/browse/JBSEAM-2619 Project: JBoss Seam Issue Type: Bug Components: JSF Integration Affects Versions: 2.1.0.A1 Reporter: Christian Bauer Priority: Minor The UILoadStyle component adds <link>s to custom CSS files to a page header, served by the resource servlet: <link rel='stylesheet' type='text/css' href='/wiki/seam/resource/style/themes/inrelationto/css/faqBrowser.css?cid=20' /> The appended conversation id prevents caching in browsers of this resource, it is set here: public abstract class UILoadStyle extends HtmlLoadStyle { @Override public Object getSrc() { UIConversationId uiConversationId = UIConversationId.newInstance(); uiConversationId.setViewId(Pages.getViewId(getFacesContext())); try { UrlBuilder urlBuilder = new UrlBuilder(StyleResource.WEB_RESOURCE_PATH + super.getSrc(), null, FacesContext.getCurrentInstance().getResponseWriter().getCharacterEncoding()); urlBuilder.addParameter(uiConversationId); I can see that we might want to stay inside the conversation sometimes, especially because the whole point of serving CSS through the resources infrastructure is to parse EL in these CSS files. So the best action would probably be an option on the UILoadStyle component that disables conversation propagation. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

17 years, 8 months

2
4
0 / 0

[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-2549) s:decorate + a4jsf tidy filter causes silent a4jsf failures

by Stuart Robertson (JIRA)

s:decorate + a4jsf tidy filter causes silent a4jsf failures ----------------------------------------------------------- Key: JBSEAM-2549 URL: http://jira.jboss.com/jira/browse/JBSEAM-2549 Project: JBoss Seam Issue Type: Bug Components: JSF Controls Environment: Seam 2.0.1CR, Richfaces 3.1.4CR4, Jboss 4.2.x Reporter: Stuart Robertson In short, the tidy filter can cause ajax behaviors to silently fail in a manner that is nearly impossible to troubleshoot. This occurs if the tidy filter silently removes markup that it determines isn't valid html, meaning that the browser client receives less markup than the component tree actually renders. Here's how I ran into this, and how you can reproduce. First, create a s:decorate-suitable file that renders an input control as a series of columns: <ui:composition xmlns="http://www.w3.org/1999/xhtml" xmlns:ui="http://java.sun.com/jsf/facelets" xmlns:h="http://java.sun.com/jsf/html" xmlns:f="http://java.sun.com/jsf/core" xmlns:s="http://jboss.com/products/seam/taglib"> <td class="name #{invalid?'errors':''}"> <s:label styleClass="label"><ui:insert name="label"/></s:label> <s:span styleClass="required" rendered="#{required}">*</s:span> </td> <td class="value #{invalid?'errors':''}"> <s:validateAll> <ui:insert/> </s:validateAll> </td> <td class="errorcolumn"> <s:message styleClass="error errors"/> </td> </ui:composition> Now include this in a table which is referenced in a reRender attribute. Expected behavior would be that the above would come back in the output, and be inserted into the dom client-side. In fact, the above doesn't get included in the ajax response at all. Why? Here's what the default configuration of the a4jsf filter does: 02:56:34,824 DEBUG [SeamPhaseListener] committing transaction after phase: RENDER_RESPONSE 6 02:56:34,837 DEBUG [BaseXMLFilter] Process response to well-formed XML for AJAX XMLHttpRequest parser 02:56:34,837 DEBUG [ConfigurableXMLFilter] default tidy parser properties loaded 02:56:34,838 DEBUG [TidyParser] Print output as XML 02:56:34,844 DEBUG [TidyParser] Message for HTML parsing : missing <!DOCTYPE> declaration 02:56:34,844 DEBUG [TidyParser] Message for HTML parsing : inserting missing 'title' element 02:56:34,845 DEBUG [TidyParser] Message for HTML parsing : missing <tbody> 02:56:34,850 DEBUG [TidyParser] Message for HTML parsing : missing <tbody> 02:56:34,850 DEBUG [TidyParser] Message for HTML parsing : <div> isn't allowed in <tr> elements 02:56:34,850 DEBUG [TidyParser] Message for HTML parsing : missing </div> before <td> ... and so on. TidyParser happily trims out invalid html. Which is fine I guess, but nothing makes it clear that this is what is happening. Suddenly the richfaces ajax magic stops working... Absolutely maddening (this kept me busy for about a day, I'm embarrassed to say). A few suggestions. One is to think of how Seam/Ajax4Jsf can communicate to a developer when a destructive parser is responsible for removing markup from a rendered view. One suggestion would be to add something to the xml response, a flag or something, indicating that tidy removed content. Another would be to write out a message to INFO when the TidyParser removed markup. I'm not sure I understand why TIDY is enabled by default (as in this is how seamgen-produced projects are setup). This same markup is presented to the browser directly when not sent via an ajax update, and given that most seam projects are using facelets, the markup is at the very least well formed. I can see how TIDY may be useful at a certain point in development, but to have it on by default, where it can silently break ajax functionality and also eat up resources in production... hmm. Another issue this highlights is that s:decorate seems to be needlessly limited. Why must it wrap content in a div? DecorateRenderBase renders a div in all cases, which is a shame. It means we can't decorate input controls as I attempted above without causing Tidy to (correctly?) point out that divs can't come between a <tr> and it's <td>. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

17 years, 8 months

3
5
0 / 0

[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-2537) Document pluggable deployment handler

by Pete Muir (JIRA)

Document pluggable deployment handler ------------------------------------- Key: JBSEAM-2537 URL: http://jira.jboss.com/jira/browse/JBSEAM-2537 Project: JBoss Seam Issue Type: Task Components: Core Reporter: Pete Muir Assigned To: Pete Muir Priority: Minor Fix For: 2.0.1.GA -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

17 years, 8 months

2
4
0 / 0

[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-2540) no-conversation-view-id not working in pageflow definition

by Bernard Labno (JIRA)

no-conversation-view-id not working in pageflow definition ---------------------------------------------------------- Key: JBSEAM-2540 URL: http://jira.jboss.com/jira/browse/JBSEAM-2540 Project: JBoss Seam Issue Type: Bug Components: BPM Affects Versions: 2.0.1.CR1 Environment: Linux Reporter: Bernard Labno Priority: Minor Putting no-conversation-view-id only in pageflow definition file does not redirect if there is no conversation. Redirection takes place only if both "conversation-required" and "no-conversation-view-id" attributes are provided in pages.xml Shouldn't it be possible to place no-conversation-view-id only in pageflow file and live pages.xml empty ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

17 years, 8 months

2
3
0 / 0

[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-2431) Finish of StyleResource

by Pete Muir (JIRA)

Finish of StyleResource ----------------------- Key: JBSEAM-2431 URL: http://jira.jboss.com/jira/browse/JBSEAM-2431 Project: JBoss Seam Issue Type: Feature Request Components: JSF Affects Versions: 2.0.1.CR1 Reporter: Pete Muir Assigned To: Pete Muir Priority: Minor Fix For: 2.0.x Split out the id prefixing stuff and merge back into wiki. Document the style resource stuff. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

17 years, 8 months

2
5
0 / 0

[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-2250) Listing returns no records found if current page number is higher than expected results

by Terry (JIRA)

Listing returns no records found if current page number is higher than expected results --------------------------------------------------------------------------------------- Key: JBSEAM-2250 URL: http://jira.jboss.com/jira/browse/JBSEAM-2250 Project: JBoss Seam Issue Type: Bug Components: Core Affects Versions: 1.2.1.GA Environment: Win XP, JDK 6, JBoss AS 4.2.2. Reporter: Terry Priority: Minor When browsing search results based on EntityQuery, and current results page number is higher than results based on further search criteria entered. Then seam returns no records found. See Forum issue for further details. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

17 years, 8 months

2
3
0 / 0

[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-2128) annotations on components installed by default can't be overriden

by Matt Drees (JIRA)

annotations on components installed by default can't be overriden ----------------------------------------------------------------- Key: JBSEAM-2128 URL: http://jira.jboss.com/jira/browse/JBSEAM-2128 Project: JBoss Seam Issue Type: Bug Affects Versions: 2.0.0.CR2 Reporter: Matt Drees Priority: Minor This may actually be intended; I can't tell for sure. Certain annotation shouldn't be overrideable, like @Install or @Name. But it seems to me some should ( like @Scope or @JndiName). I'll attach a test case with more comments inline. It'd be helpful if a seam dev could look it over and say "Yes, it's behaving correctly", or "Something's broken". -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

17 years, 8 months

2
5
0 / 0

[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-1690) Errors wrapped by ServletExceptions are not logged by ExceptionFilter

by Matt Drees (JIRA)

Errors wrapped by ServletExceptions are not logged by ExceptionFilter --------------------------------------------------------------------- Key: JBSEAM-1690 URL: http://jira.jboss.com/jira/browse/JBSEAM-1690 Project: JBoss Seam Issue Type: Bug Affects Versions: 2.0.0.BETA1 Reporter: Matt Drees Priority: Minor Errors (in particular, OutOfMemoryErrors), are not logged when they're wrapped by a servletException. ExceptionFilter.java (line 66) has this: log.error( "exception root cause", EJB.getCause(e) ); But EJB.getCause(e) returns null if e is a ServletException whose rootCause is not an Exception (like an OutOfMemoryError). -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

17 years, 8 months

2
5
0 / 0

[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-905) Using the debug page without exceptions

by Christian Bauer (JIRA)

Using the debug page without exceptions --------------------------------------- Key: JBSEAM-905 URL: http://jira.jboss.com/jira/browse/JBSEAM-905 Project: JBoss Seam Issue Type: Feature Request Components: JSF Reporter: Christian Bauer Priority: Minor I'd like to call /debug.seam manually to look into my conversations. I usually don't enable it because I don't like being redirected to it from an exception. Why? It hides the URL that caused the exception and it fills my log with hundreds of lines after the exception stacktrace. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

17 years, 8 months

3
5
0 / 0

[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-2590) EntityQuery components hold the whole untruncated resultset if maxResults property is set and the underlying dialect does not support limits

by vargadan (JIRA)

EntityQuery components hold the whole untruncated resultset if maxResults property is set and the underlying dialect does not support limits --------------------------------------------------------------------------------------------------------------------------------------------- Key: JBSEAM-2590 URL: http://jira.jboss.com/jira/browse/JBSEAM-2590 Project: JBoss Seam Issue Type: Bug Components: Framework Affects Versions: 2.0.1.GA Reporter: vargadan If the dialect supports limits then query objects only hold the number of rows set by the maxResults property. So i.e. if the search results 10000 rows but the page size is 10, only 10 objects are kept. But if the dialect does not support limits (like derby) then truncation of the result list in done in EntityQuery.getResultList() which in the previous example results in the following: - 10000 objects are kept in EntityQuery.resultList - only 10 of them is displayed in one page - EntityQuery.getResultList() returns EntityQuery.resultList the sublist every time when invoked - when paginating the query is executed for every page, so there is no point in holding all the rows. It causes quite a big overhead when query components are kept in conversation scope, which is the case most of the times. If the truncation was done just after querying against the DB, there would not be such an overhead. I.e. Query.truncResultList gets invoked in EntityQuery.initResultList and EntityQuery.resultList holds only the truncated list of results. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

17 years, 8 months

2
3
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

seam-issues April 2008