December 2010 - seam-issues - Jboss List Archives

[JBoss JIRA] Commented: (SEAMCATCH-4) Include the ability to filter stack traces

by Dan Allen (JIRA)

[ https://issues.jboss.org/browse/SEAMCATCH-4?page=com.atlassian.jira.plugi... ] Dan Allen commented on SEAMCATCH-4: ----------------------------------- Here are some examples. 1. Drop all frames in NoDefClassFoundError public class NoClassFoundStackFrameFilter implements ExceptionStackFrameFilter<NoClassDefFoundError> { @Override public StackFrameFilterResult process(StackFrame frame) { return StackFrameFilterResult.BREAK; } } 2. Truncate frames after a threshold (though no indication we did that we did) public class TruncateExceptionStackFilter implements ExceptionStackFrameFilter<Throwable> { @Override public StackFrameFilterResult process(StackFrame frame) { if (frame.getIterationStatus().getIndex() >= 20) { return StackFrameFilterResult.DROP_REMAINING; } return StackFrameFilterResult.INCLUDE; } } 3. Remove noise in between fire event and invoke observer public class InvokeObserverStackFrameFilter implements ExceptionStackFrameFilter<Throwable> { @Override public StackFrameFilterResult process(StackFrame frame) { StackTraceElement el = frame.getStackTraceElement(); if (frame.isMarkSet("event.firing")) { if (isReflectionInvoke(el)) { frame.clearMark("event.firing"); return StackFrameFilterResult.DROP; } else { return StackFrameFilterResult.DROP; } } else if (el.getClassName().contains(".BeanManager") && el.getMethodName().equals("fireEvent")) { frame.mark("event.firing"); return StackFrameFilterResult.INCLUDE; } return StackFrameFilterResult.INCLUDE; } private boolean isReflectionInvoke(StackTraceElement candidate) { return candidate.getClassName().equals(Method.class.getName()) && candidate.getMethodName().equals("invoke"); } } 4. Flatten reflections invoke into a single line public class ReflectionInvokeStackFrameFilter implements ExceptionStackFrameFilter<Throwable> { @Override public StackFrameFilterResult process(StackFrame frame) { if (frame.isMarkSet("reflections.invoke")) { if (frame.getStackTraceElement().getMethodName().startsWith("invoke") || frame.getStackTraceElement().getClassName().contains("_WeldClientProxy")) { return StackFrameFilterResult.DROP; } else { frame.clearMark("reflections.invoke"); } } return StackFrameFilterResult.INCLUDE; } } > Include the ability to filter stack traces > ------------------------------------------ > > Key: SEAMCATCH-4 > URL: https://issues.jboss.org/browse/SEAMCATCH-4 > Project: Seam Catch > Issue Type: Feature Request > Reporter: Jason Porter > Assignee: Jason Porter > Fix For: Alpha3 > > > Catch should support ideas such as http://stackoverflow.com/questions/2504647/bash-how-to-filter-java-except... http://squirrelsewer.blogspot.com/2010/03/filter-your-stack-traces.html and http://pastebin.com/p8aCSeuu -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

15 years, 4 months

1
0
0 / 0

[JBoss JIRA] Commented: (SEAMCATCH-4) Include the ability to filter stack traces

by Dan Allen (JIRA)

[ https://issues.jboss.org/browse/SEAMCATCH-4?page=com.atlassian.jira.plugi... ] Dan Allen commented on SEAMCATCH-4: ----------------------------------- I played around with some ideas and we may even be able to use this for the exception mapping as well. Here are some prototype APIs. /** * A filter for processing the stack frames of a single exception (type parameter allows us to focus on a specific exception type) */ public interface ExceptionStackFrameFilter<T extends Throwable> { public StackFrameFilterResult process(StackFrame frame); } public interface StackFrame { StackElement getStackElement(); StackTraceElement getStackTraceElement(); void mark(String tag); StackFrame getMarkedFrame(String tag); boolean isMarkSet(String tag); void clearMark(String tag); void setStackTraceElement(StackTraceElement element); IterationStatus getIterationStatus(); } public enum StackFrameFilterResult { /** * Include this frame */ INCLUDE, /** * Drop this frame */ DROP, /** * Include this frame, but skip any remaining frames in this cause */ DROP_REMAINING, /** * Drop this frame and any remaining frames in this cause */ BREAK, /** * Stops processing any remaining frames or causes */ TERMINATE, /** * Include this frame, then stop processing any remaining frames or causes */ TERMINATE_AFTER } /** * A filter for processing the chained exceptions (i.e., the causes) */ public interface ExceptionStackFilter { public StackFilterResult process(StackElement element); } public interface StackElement { Throwable getThrowable(); void setThrowable(Throwable throwable); IterationStatus getIterationStatus(); } public enum StackFilterResult { /** * Include this throwable */ INCLUDE, /** * Drop this throwable, go to next in chain (if any) */ DROP, /** * Drop any remaining throwables in the chain */ DROP_REMAINING, /** * Drop throwable and any remaining in the chain */ TERMINATE } > Include the ability to filter stack traces > ------------------------------------------ > > Key: SEAMCATCH-4 > URL: https://issues.jboss.org/browse/SEAMCATCH-4 > Project: Seam Catch > Issue Type: Feature Request > Reporter: Jason Porter > Assignee: Jason Porter > Fix For: Alpha3 > > > Catch should support ideas such as http://stackoverflow.com/questions/2504647/bash-how-to-filter-java-except... http://squirrelsewer.blogspot.com/2010/03/filter-your-stack-traces.html and http://pastebin.com/p8aCSeuu -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

15 years, 4 months

1
0
0 / 0

[JBoss JIRA] Created: (SEAMFACES-64) TransactionPhaseListener - NullPointerException

by Lukas Fryc (JIRA)

TransactionPhaseListener - NullPointerException ----------------------------------------------- Key: SEAMFACES-64 URL: https://issues.jboss.org/browse/SEAMFACES-64 Project: Seam Faces Issue Type: Bug Components: Transactions & Persistence Affects Versions: 3.0.0.Beta1 Environment: JBoss AS 6.0.0.CR1 OpenJDK Runtime Environment (IcedTea6 1.9.2) Apache Maven 3.0 (r1004208; 2010-10-04 13:50:56+0200) Reporter: Lukas Fryc Sample application: https://svn.devel.redhat.com/repos/jboss-qa/people/ozizka/VUTcourse/proje... Revision: 12454 17:04:18,180 ERROR [org.apache.catalina.core.ContainerBase.[jboss.web].[localhost].[/practice03-jpa].[Faces Servlet]] Servlet.service() for servlet Faces Servlet threw exception: java.lang.NullPointerException at org.jboss.seam.faces.transaction.TransactionPhaseListener.begin(TransactionPhaseListener.java:136) [:20101101-1123] at org.jboss.seam.faces.transaction.TransactionPhaseListener.begin(TransactionPhaseListener.java:129) [:20101101-1123] at org.jboss.seam.faces.transaction.TransactionPhaseListener.handleTransactionsBeforePhase(TransactionPhaseListener.java:106) [:20101101-1123] at org.jboss.seam.faces.transaction.TransactionPhaseListener.beforePhase(TransactionPhaseListener.java:82) [:20101101-1123] at org.jboss.seam.faces.event.DelegatingPhaseListener.beforePhase(DelegatingPhaseListener.java:56) [:20101209-1701] at com.sun.faces.lifecycle.Phase.handleBeforePhase(Phase.java:228) [:2.0.2-FCS] at com.sun.faces.lifecycle.Phase.doPhase(Phase.java:99) [:2.0.2-FCS] at com.sun.faces.lifecycle.RestoreViewPhase.doPhase(RestoreViewPhase.java:110) [:2.0.2-FCS] at com.sun.faces.lifecycle.LifecycleImpl.execute(LifecycleImpl.java:118) [:2.0.2-FCS] at javax.faces.webapp.FacesServlet.service(FacesServlet.java:312) [:2.0.2-FCS] at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:324) [:] at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:242) [:] at org.jboss.resteasy.plugins.server.servlet.FilterDispatcher.doFilter(FilterDispatcher.java:63) [:] at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:274) [:] at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:242) [:] at org.jboss.weld.servlet.ConversationPropagationFilter.doFilter(ConversationPropagationFilter.java:68) [:2010-08-30 15:40] at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:274) [:] at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:242) [:] at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:275) [:] at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191) [:] at org.jboss.web.tomcat.security.SecurityAssociationValve.invoke(SecurityAssociationValve.java:181) [:6.0.0.20100911-M5] at org.jboss.modcluster.catalina.CatalinaContext$RequestListenerValve.event(CatalinaContext.java:285) [:1.1.0.CR3] at org.jboss.modcluster.catalina.CatalinaContext$RequestListenerValve.invoke(CatalinaContext.java:261) [:1.1.0.CR3] at org.jboss.web.tomcat.security.JaccContextValve.invoke(JaccContextValve.java:88) [:6.0.0.20100911-M5] at org.jboss.web.tomcat.security.SecurityContextEstablishmentValve.invoke(SecurityContextEstablishmentValve.java:100) [:6.0.0.20100911-M5] at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127) [:] at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102) [:] at org.jboss.web.tomcat.service.jca.CachedConnectionValve.invoke(CachedConnectionValve.java:158) [:6.0.0.20100911-M5] at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109) [:] at org.jboss.web.tomcat.service.request.ActiveRequestResponseCacheValve.invoke(ActiveRequestResponseCacheValve.java:53) [:6.0.0.20100911-M5] at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:362) [:] at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:877) [:] at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:653) [:] at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:951) [:] at java.lang.Thread.run(Thread.java:636) [:1.6.0_20] -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

15 years, 4 months

2
4
0 / 0

[JBoss JIRA] Commented: (SEAMFACES-63) Create a JSF bridge

by Dan Allen (JIRA)

[ https://issues.jboss.org/browse/SEAMFACES-63?page=com.atlassian.jira.plug... ] Dan Allen commented on SEAMFACES-63: ------------------------------------ Ah, I misread what you wrote. Seems like we are on the same page ;) Excellent. > Create a JSF bridge > ------------------- > > Key: SEAMFACES-63 > URL: https://issues.jboss.org/browse/SEAMFACES-63 > Project: Seam Faces > Issue Type: Feature Request > Reporter: Jason Porter > Assignee: Jason Porter > > We need a JSF2 bridge for Catch. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

15 years, 4 months

1
0
0 / 0

[JBoss JIRA] Commented: (SEAMFACES-63) Create a JSF bridge

by Dan Allen (JIRA)

[ https://issues.jboss.org/browse/SEAMFACES-63?page=com.atlassian.jira.plug... ] Dan Allen commented on SEAMFACES-63: ------------------------------------ Nice, isn't it? Again, I don't think we need to do any logging in the bridge. If it gets handled by catch, it will likely get logged or not if the developer doesn't want it to be. Anything not handled by catch will likely get logged by JSF and then thrown up to the Servlet error handler. > Create a JSF bridge > ------------------- > > Key: SEAMFACES-63 > URL: https://issues.jboss.org/browse/SEAMFACES-63 > Project: Seam Faces > Issue Type: Feature Request > Reporter: Jason Porter > Assignee: Jason Porter > > We need a JSF2 bridge for Catch. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

15 years, 4 months

1
0
0 / 0

[JBoss JIRA] Updated: (SOLDER-8) Solder tests fail on IBM JDK

by Dan Allen (JIRA)

[ https://issues.jboss.org/browse/SOLDER-8?page=com.atlassian.jira.plugin.s... ] Dan Allen updated SOLDER-8: --------------------------- Summary: Solder tests fail on IBM JDK (was: Weld Extensions tests fail on IBM JDK) > Solder tests fail on IBM JDK > ---------------------------- > > Key: SOLDER-8 > URL: https://issues.jboss.org/browse/SOLDER-8 > Project: Seam Solder > Issue Type: Bug > Environment: Linux, IBM JDK 1.5 & 1.6 > Reporter: Peter Lenyi > Attachments: consoleText.txt, surefire-reports.zip > > -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

15 years, 4 months

1
0
0 / 0

[JBoss JIRA] Commented: (SEAMFACES-63) Create a JSF bridge

by Brian Leathem (JIRA)

[ https://issues.jboss.org/browse/SEAMFACES-63?page=com.atlassian.jira.plug... ] Brian Leathem commented on SEAMFACES-63: ---------------------------------------- In your implementation I see "if (catchEvent.isHandled())". Didn't know about that. That alleviates the need log the exception, since we can feed it back to JSF to log. Thanks > Create a JSF bridge > ------------------- > > Key: SEAMFACES-63 > URL: https://issues.jboss.org/browse/SEAMFACES-63 > Project: Seam Faces > Issue Type: Feature Request > Reporter: Jason Porter > Assignee: Jason Porter > > We need a JSF2 bridge for Catch. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

15 years, 4 months

1
0
0 / 0

[JBoss JIRA] Commented: (SEAMFACES-63) Create a JSF bridge

by Dan Allen (JIRA)

[ https://issues.jboss.org/browse/SEAMFACES-63?page=com.atlassian.jira.plug... ] Dan Allen commented on SEAMFACES-63: ------------------------------------ Hehehe, good. If you see anything I've got worth stealing, just merge it in :) Please don't log exceptions. Heck, JSF has probably logged it 10 times already anyway. If Catch claims the exception is handled, then it's handled and we need to trust that. If Catch does not mark it as handled, then it will get thrown up to the Servlet (that's why I only remove the exception if Catch reports it as handled). > Create a JSF bridge > ------------------- > > Key: SEAMFACES-63 > URL: https://issues.jboss.org/browse/SEAMFACES-63 > Project: Seam Faces > Issue Type: Feature Request > Reporter: Jason Porter > Assignee: Jason Porter > > We need a JSF2 bridge for Catch. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

15 years, 4 months

1
0
0 / 0

[JBoss JIRA] Commented: (SEAMFACES-63) Create a JSF bridge

by Brian Leathem (JIRA)

[ https://issues.jboss.org/browse/SEAMFACES-63?page=com.atlassian.jira.plug... ] Brian Leathem commented on SEAMFACES-63: ---------------------------------------- Alright, thanks Jason. I'll add a built-in handler to at minimum log the messges. Dan, your implementation looks remarkably similar to mine, we must have had the same inspiration :P > Create a JSF bridge > ------------------- > > Key: SEAMFACES-63 > URL: https://issues.jboss.org/browse/SEAMFACES-63 > Project: Seam Faces > Issue Type: Feature Request > Reporter: Jason Porter > Assignee: Jason Porter > > We need a JSF2 bridge for Catch. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

15 years, 4 months

1
0
0 / 0

[JBoss JIRA] Commented: (SEAMFACES-63) Create a JSF bridge

by Jason Porter (JIRA)

[ https://issues.jboss.org/browse/SEAMFACES-63?page=com.atlassian.jira.plug... ] Jason Porter commented on SEAMFACES-63: --------------------------------------- There currently aren't any built in handlers, if there were, it would be a logging one though. For now, you can create one for JSF. BTW, you're compiling against Alpha2? > Create a JSF bridge > ------------------- > > Key: SEAMFACES-63 > URL: https://issues.jboss.org/browse/SEAMFACES-63 > Project: Seam Faces > Issue Type: Feature Request > Reporter: Jason Porter > Assignee: Jason Porter > > We need a JSF2 bridge for Catch. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

15 years, 4 months

1
0
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

seam-issues December 2010