[jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-2505) ServletContexts instance returns null request during JSF request
[ http://jira.jboss.com/jira/browse/JBSEAM-2505?page=comments#action_12395655 ]
Jacob Orshalick commented on JBSEAM-2505:
-----------------------------------------
Actually I believe this behavior should differ based on whether the request is coming from
a Servlet or a Portlet environment in JSF. ServletContexts expects the ExternalContext to
be an HttpServletRequest. The SeamPhaseListener is where this check is done.
ServletContexts instance returns null request during JSF request
----------------------------------------------------------------
Key: JBSEAM-2505
URL: http://jira.jboss.com/jira/browse/JBSEAM-2505
Project: JBoss Seam
Issue Type: Bug
Components: JSF
Affects Versions: 2.0.1.CR1
Reporter: Jacob Orshalick
Priority: Blocker
The ServletContexts.instance().getRequest() currently returns null during a JSF request.
I would think this should be returning the external context for a JSF request. Remoting
handlers, ContextualHttpServletRequest, and the SoapRequestHandler all set the
HttpServletRequest into the ServletContexts instance. I have applied a patch in the
FacesLifecycle.beginRequest() and it does the trick. I would be happy to submit the patch
if you agree. Thanks.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira