[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-3362) Detect cyclic dependencies and throw exception
5:48 a.m.
Detect cyclic dependencies and throw exception
----------------------------------------------
Key: JBSEAM-3362
URL: https://jira.jboss.org/jira/browse/JBSEAM-3362
Project: Seam
Issue Type: Feature Request
Components: Core
Affects Versions: 2.1.0.BETA1
Reporter: Matt Drees
Assignee: Matt Drees
Imagine a scenario like this. Some client calls someMethod() on a component called Foo.
BijectionInterceptor tries to inject Foo's @in attributes, one of which requires
calling a factory method on Bar. Bar's factory method in turn calls
Foo.someOtherMethod(). Foo is not in a state where it can support method calls, because
it is in the process of injecting dependencies, so this sort of cyclic dependency should
not be allowed. Seam should throw an exception in this case.
BijectionInterceptor used to be coded such that someOtherMethod() would run without any
complaints, and any @In attributes may or may not be null, depending on which fields were
injected first. Recent changes to BijectionInterceptor (for JBSEAM-3295) have changed
this behavior, and now an finite loop results. Neither of these behaviors is desirable.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:50 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-3362) Detect cyclic dependencies and throw exception
[
https://jira.jboss.org/jira/browse/JBSEAM-3362?page=com.atlassian.jira.pl...
]
Matt Drees updated JBSEAM-3362:
-------------------------------
Priority: Minor (was: Major)
Detect cyclic dependencies and throw exception
----------------------------------------------
Key: JBSEAM-3362
URL: https://jira.jboss.org/jira/browse/JBSEAM-3362
Project: Seam
Issue Type: Feature Request
Components: Core
Affects Versions: 2.1.0.BETA1
Reporter: Matt Drees
Assignee: Matt Drees
Priority: Minor
Imagine a scenario like this. Some client calls someMethod() on a component called Foo.
BijectionInterceptor tries to inject Foo's @in attributes, one of which requires
calling a factory method on Bar. Bar's factory method in turn calls
Foo.someOtherMethod(). Foo is not in a state where it can support method calls, because
it is in the process of injecting dependencies, so this sort of cyclic dependency should
not be allowed. Seam should throw an exception in this case.
BijectionInterceptor used to be coded such that someOtherMethod() would run without any
complaints, and any @In attributes may or may not be null, depending on which fields were
injected first. Recent changes to BijectionInterceptor (for JBSEAM-3295) have changed
this behavior, and now an finite loop results. Neither of these behaviors is desirable.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:50 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-3362) Detect cyclic dependencies and throw exception
[
https://jira.jboss.org/jira/browse/JBSEAM-3362?page=com.atlassian.jira.pl...
]
Matt Drees commented on JBSEAM-3362:
------------------------------------
I've coded this, and I'll go ahead and commit tomorrow unless I hear otherwise.
Detect cyclic dependencies and throw exception
----------------------------------------------
Key: JBSEAM-3362
URL: https://jira.jboss.org/jira/browse/JBSEAM-3362
Project: Seam
Issue Type: Feature Request
Components: Core
Affects Versions: 2.1.0.BETA1
Reporter: Matt Drees
Assignee: Matt Drees
Imagine a scenario like this. Some client calls someMethod() on a component called Foo.
BijectionInterceptor tries to inject Foo's @in attributes, one of which requires
calling a factory method on Bar. Bar's factory method in turn calls
Foo.someOtherMethod(). Foo is not in a state where it can support method calls, because
it is in the process of injecting dependencies, so this sort of cyclic dependency should
not be allowed. Seam should throw an exception in this case.
BijectionInterceptor used to be coded such that someOtherMethod() would run without any
complaints, and any @In attributes may or may not be null, depending on which fields were
injected first. Recent changes to BijectionInterceptor (for JBSEAM-3295) have changed
this behavior, and now an finite loop results. Neither of these behaviors is desirable.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:13 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-3362) Detect cyclic dependencies and throw exception
[
https://jira.jboss.org/jira/browse/JBSEAM-3362?page=com.atlassian.jira.pl...
]
Shane Bryzak commented on JBSEAM-3362:
--------------------------------------
This must be the same issue described in JBSEAM-3361 - please go ahead and commit this
Matt.
Detect cyclic dependencies and throw exception
----------------------------------------------
Key: JBSEAM-3362
URL: https://jira.jboss.org/jira/browse/JBSEAM-3362
Project: Seam
Issue Type: Feature Request
Components: Core
Affects Versions: 2.1.0.BETA1
Reporter: Matt Drees
Assignee: Matt Drees
Priority: Minor
Imagine a scenario like this. Some client calls someMethod() on a component called Foo.
BijectionInterceptor tries to inject Foo's @in attributes, one of which requires
calling a factory method on Bar. Bar's factory method in turn calls
Foo.someOtherMethod(). Foo is not in a state where it can support method calls, because
it is in the process of injecting dependencies, so this sort of cyclic dependency should
not be allowed. Seam should throw an exception in this case.
BijectionInterceptor used to be coded such that someOtherMethod() would run without any
complaints, and any @In attributes may or may not be null, depending on which fields were
injected first. Recent changes to BijectionInterceptor (for JBSEAM-3295) have changed
this behavior, and now an finite loop results. Neither of these behaviors is desirable.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:11 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Resolved: (JBSEAM-3362) Detect cyclic dependencies and throw exception
[
https://jira.jboss.org/jira/browse/JBSEAM-3362?page=com.atlassian.jira.pl...
]
Matt Drees resolved JBSEAM-3362.
--------------------------------
Fix Version/s: 2.0.3.CR2
2.1.0.CR1
Resolution: Done
Committed.
Detect cyclic dependencies and throw exception
----------------------------------------------
Key: JBSEAM-3362
URL: https://jira.jboss.org/jira/browse/JBSEAM-3362
Project: Seam
Issue Type: Feature Request
Components: Core
Affects Versions: 2.1.0.BETA1
Reporter: Matt Drees
Assignee: Matt Drees
Priority: Minor
Fix For: 2.0.3.CR2, 2.1.0.CR1
Imagine a scenario like this. Some client calls someMethod() on a component called Foo.
BijectionInterceptor tries to inject Foo's @in attributes, one of which requires
calling a factory method on Bar. Bar's factory method in turn calls
Foo.someOtherMethod(). Foo is not in a state where it can support method calls, because
it is in the process of injecting dependencies, so this sort of cyclic dependency should
not be allowed. Seam should throw an exception in this case.
BijectionInterceptor used to be coded such that someOtherMethod() would run without any
complaints, and any @In attributes may or may not be null, depending on which fields were
injected first. Recent changes to BijectionInterceptor (for JBSEAM-3295) have changed
this behavior, and now an finite loop results. Neither of these behaviors is desirable.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:13 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-3362) Detect cyclic dependencies and throw exception
[
https://jira.jboss.org/jira/browse/JBSEAM-3362?page=com.atlassian.jira.pl...
]
Matt Drees updated JBSEAM-3362:
-------------------------------
Affects Version/s: 2.0.3.CR1
Detect cyclic dependencies and throw exception
----------------------------------------------
Key: JBSEAM-3362
URL: https://jira.jboss.org/jira/browse/JBSEAM-3362
Project: Seam
Issue Type: Feature Request
Components: Core
Affects Versions: 2.0.3.CR1, 2.1.0.BETA1
Reporter: Matt Drees
Assignee: Matt Drees
Priority: Minor
Fix For: 2.0.3.CR2, 2.1.0.CR1
Imagine a scenario like this. Some client calls someMethod() on a component called Foo.
BijectionInterceptor tries to inject Foo's @in attributes, one of which requires
calling a factory method on Bar. Bar's factory method in turn calls
Foo.someOtherMethod(). Foo is not in a state where it can support method calls, because
it is in the process of injecting dependencies, so this sort of cyclic dependency should
not be allowed. Seam should throw an exception in this case.
BijectionInterceptor used to be coded such that someOtherMethod() would run without any
complaints, and any @In attributes may or may not be null, depending on which fields were
injected first. Recent changes to BijectionInterceptor (for JBSEAM-3295) have changed
this behavior, and now an finite loop results. Neither of these behaviors is desirable.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:04 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Reopened: (JBSEAM-3362) Detect cyclic dependencies and throw exception
[
https://jira.jboss.org/jira/browse/JBSEAM-3362?page=com.atlassian.jira.pl...
]
Pete Muir reopened JBSEAM-3362:
-------------------------------
This fix is in essence correct however
1) The contextual information in CyclicDependencyException isn't getting printed in
all circumstances (see wiki tests in 2.0 branch)
2) The fix doesn't take account account of the fact that injecting with required=false
should be allowed when a dependency is cyclic (the injection should fail silently I
think)
Detect cyclic dependencies and throw exception
----------------------------------------------
Key: JBSEAM-3362
URL: https://jira.jboss.org/jira/browse/JBSEAM-3362
Project: Seam
Issue Type: Feature Request
Components: Core
Affects Versions: 2.0.3.CR1, 2.1.0.BETA1
Reporter: Matt Drees
Assignee: Matt Drees
Priority: Minor
Fix For: 2.0.3.CR2, 2.1.0.CR1
Imagine a scenario like this. Some client calls someMethod() on a component called Foo.
BijectionInterceptor tries to inject Foo's @in attributes, one of which requires
calling a factory method on Bar. Bar's factory method in turn calls
Foo.someOtherMethod(). Foo is not in a state where it can support method calls, because
it is in the process of injecting dependencies, so this sort of cyclic dependency should
not be allowed. Seam should throw an exception in this case.
BijectionInterceptor used to be coded such that someOtherMethod() would run without any
complaints, and any @In attributes may or may not be null, depending on which fields were
injected first. Recent changes to BijectionInterceptor (for JBSEAM-3295) have changed
this behavior, and now an finite loop results. Neither of these behaviors is desirable.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:36 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-3362) Detect cyclic dependencies and throw exception
[
https://jira.jboss.org/jira/browse/JBSEAM-3362?page=com.atlassian.jira.pl...
]
Matt Drees commented on JBSEAM-3362:
------------------------------------
1) I'll take a look
2) Correct me if I'm wrong here. My understanding of what you'd like is this:
Say Foo has an @In(required=false) attribute called somethingProvidedByBar. When
someMethod() is invoked on Foo, and trying to satisfy the injection of bar results in Bar
calling Foo.someOtherMethod(), then we should bail on this injection attempt, and let
somethingProvidedByBar be null for the invocation of someMethod().
I see the desirability of this, but I don't know how to do the "bail" part.
A cycle is only detected when someOtherMethod() is called, and so trying to bail would
probably require throwing a special exception to propagate back down to the initial
injecting of Foo, where we'd catch it and go on to the next attribute to inject. But
throwing exceptions seems like a bad idea, especially when they might inadvertently cause
a transaction rollback.
Let me know what you think.
Detect cyclic dependencies and throw exception
----------------------------------------------
Key: JBSEAM-3362
URL: https://jira.jboss.org/jira/browse/JBSEAM-3362
Project: Seam
Issue Type: Feature Request
Components: Core
Affects Versions: 2.0.3.CR1, 2.1.0.BETA1
Reporter: Matt Drees
Assignee: Matt Drees
Priority: Minor
Fix For: 2.0.3.CR2, 2.1.0.CR1
Imagine a scenario like this. Some client calls someMethod() on a component called Foo.
BijectionInterceptor tries to inject Foo's @in attributes, one of which requires
calling a factory method on Bar. Bar's factory method in turn calls
Foo.someOtherMethod(). Foo is not in a state where it can support method calls, because
it is in the process of injecting dependencies, so this sort of cyclic dependency should
not be allowed. Seam should throw an exception in this case.
BijectionInterceptor used to be coded such that someOtherMethod() would run without any
complaints, and any @In attributes may or may not be null, depending on which fields were
injected first. Recent changes to BijectionInterceptor (for JBSEAM-3295) have changed
this behavior, and now an finite loop results. Neither of these behaviors is desirable.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:47 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-3362) Detect cyclic dependencies and throw exception
[
https://jira.jboss.org/jira/browse/JBSEAM-3362?page=com.atlassian.jira.pl...
]
Pete Muir commented on JBSEAM-3362:
-----------------------------------
Say Foo has an @In(required=false) attribute called
somethingProvidedByBar.
When someMethod() is invoked on Foo, and trying to satisfy the injection of bar
results in Bar calling Foo.someOtherMethod(), then we should bail on this injection
attempt, and let somethingProvidedByBar be null for the invocation of someMethod().
Exactly. However I too can't immediately see a good way to implement this, apart from
reworking the BijectionInterceptor to allow cyclic dependencies again.
How about we get (1) fixed, and then release like this in CR and see if we get many
complaints from users.
Detect cyclic dependencies and throw exception
----------------------------------------------
Key: JBSEAM-3362
URL: https://jira.jboss.org/jira/browse/JBSEAM-3362
Project: Seam
Issue Type: Feature Request
Components: Core
Affects Versions: 2.0.3.CR1, 2.1.0.BETA1
Reporter: Matt Drees
Assignee: Matt Drees
Priority: Minor
Fix For: 2.0.3.CR2, 2.1.0.CR1
Imagine a scenario like this. Some client calls someMethod() on a component called Foo.
BijectionInterceptor tries to inject Foo's @in attributes, one of which requires
calling a factory method on Bar. Bar's factory method in turn calls
Foo.someOtherMethod(). Foo is not in a state where it can support method calls, because
it is in the process of injecting dependencies, so this sort of cyclic dependency should
not be allowed. Seam should throw an exception in this case.
BijectionInterceptor used to be coded such that someOtherMethod() would run without any
complaints, and any @In attributes may or may not be null, depending on which fields were
injected first. Recent changes to BijectionInterceptor (for JBSEAM-3295) have changed
this behavior, and now an finite loop results. Neither of these behaviors is desirable.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:59 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-3362) Detect cyclic dependencies and throw exception
[
https://jira.jboss.org/jira/browse/JBSEAM-3362?page=com.atlassian.jira.pl...
]
Matt Drees commented on JBSEAM-3362:
------------------------------------
Sounds good to me.
Detect cyclic dependencies and throw exception
----------------------------------------------
Key: JBSEAM-3362
URL: https://jira.jboss.org/jira/browse/JBSEAM-3362
Project: Seam
Issue Type: Feature Request
Components: Core
Affects Versions: 2.0.3.CR1, 2.1.0.BETA1
Reporter: Matt Drees
Assignee: Matt Drees
Priority: Minor
Fix For: 2.0.3.CR2, 2.1.0.CR1
Imagine a scenario like this. Some client calls someMethod() on a component called Foo.
BijectionInterceptor tries to inject Foo's @in attributes, one of which requires
calling a factory method on Bar. Bar's factory method in turn calls
Foo.someOtherMethod(). Foo is not in a state where it can support method calls, because
it is in the process of injecting dependencies, so this sort of cyclic dependency should
not be allowed. Seam should throw an exception in this case.
BijectionInterceptor used to be coded such that someOtherMethod() would run without any
complaints, and any @In attributes may or may not be null, depending on which fields were
injected first. Recent changes to BijectionInterceptor (for JBSEAM-3295) have changed
this behavior, and now an finite loop results. Neither of these behaviors is desirable.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:01 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Resolved: (JBSEAM-3362) Detect cyclic dependencies and throw exception
[
https://jira.jboss.org/jira/browse/JBSEAM-3362?page=com.atlassian.jira.pl...
]
Matt Drees resolved JBSEAM-3362.
--------------------------------
Resolution: Done
I had forgot to check if the thrown CyclicDependencyException gets wrapped by another
exception. This is fixed now.
Detect cyclic dependencies and throw exception
----------------------------------------------
Key: JBSEAM-3362
URL: https://jira.jboss.org/jira/browse/JBSEAM-3362
Project: Seam
Issue Type: Feature Request
Components: Core
Affects Versions: 2.0.3.CR1, 2.1.0.BETA1
Reporter: Matt Drees
Assignee: Matt Drees
Priority: Minor
Fix For: 2.0.3.CR2, 2.1.0.CR1
Imagine a scenario like this. Some client calls someMethod() on a component called Foo.
BijectionInterceptor tries to inject Foo's @in attributes, one of which requires
calling a factory method on Bar. Bar's factory method in turn calls
Foo.someOtherMethod(). Foo is not in a state where it can support method calls, because
it is in the process of injecting dependencies, so this sort of cyclic dependency should
not be allowed. Seam should throw an exception in this case.
BijectionInterceptor used to be coded such that someOtherMethod() would run without any
complaints, and any @In attributes may or may not be null, depending on which fields were
injected first. Recent changes to BijectionInterceptor (for JBSEAM-3295) have changed
this behavior, and now an finite loop results. Neither of these behaviors is desirable.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5766
days inactive
5767
days old
10 comments
3 participants
participants (3)
-
Matt Drees (JIRA) -
Pete Muir (JIRA)
-
Shane Bryzak (JIRA)