Pull requests for the updated patch are up :) If anyone has a better name
for the property please let me know.
From: Martin Kouba <mkouba(a)redhat.com>
To: Benjamin Confino <BENJAMIC(a)uk.ibm.com>, weld-dev(a)lists.jboss.org
Date: 18/04/2018 13:22
Subject: Re: [weld-dev] WIP fix for
Dne 18.4.2018 v 14:02 Martin Kouba napsal(a):
I'm sorry but the Weld team is burried under some high priority issues.
I've quickly went through your proposal and have few comments.
1. I think it would be more convenient to modify
Sorry, I meant
which is used for both the HTTP session and the conversation
2. +1 for config property, we probably need a better name though ;-)
3. You're probably aware that this would not solve the problem
completely. It should trigger the replication when a @SessionScoped bean
instance is obtained from the context, e.g. when a client proxy
is invoked. However, there are some optimizations in Weld which prevent
the context lookup (see also
org.jboss.weld.bean.ContextualInstanceStrategy). Also the replication
may happen before the state is actually changed - it really depends on
replication impl details. Still, I agree that this would improve the
4. +10 for tests. But I guess it would be tricky to write an automated
test for this.
Dne 13.4.2018 v 21:33 Benjamin Confino napsal(a):
> I posed
> this lift list month but have not heard any feedback. When can I
> expect to hear if this concept is good in principal? If the concept is
> good I can begin investigating how to extend the idea to conversation
> scopes and write a test.
> Unless stated otherwise above:
> IBM United Kingdom Limited - Registered in England and Wales with
> number 741598.
> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6
> weld-dev mailing list
Senior Software Engineer
Red Hat, Czech Republic
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU