[
https://jira.jboss.org/jira/browse/EMBJOPR-72?page=com.atlassian.jira.plu...
]
Charles Crouch commented on EMBJOPR-72:
---------------------------------------
(12:07:01 PM) ccrouch: ok first off, we had a big discussion a few months back with stan
(12:07:22 PM) ccrouch: about how we should be using id's not xpath for identifying
elements
(12:08:00 PM) ccrouch: is that still QA's preference? or you good with xpath now?
(12:11:04 PM) ozizka: ccrouch: There are cases when IDs are not an option
(12:11:19 PM) ozizka: Like when working with tables etc.
(12:11:29 PM) ccrouch: ok fair enough
(12:11:48 PM) ccrouch: the change you used as an example there, looks fairly harmless
(12:12:10 PM) ccrouch: as you say as long as it doenst impact form or function, i'm
fine with it
(12:12:53 PM) ozizka: ccrouch: Ok, thanks
Change some HTML bits to improve testability
--------------------------------------------
Key: EMBJOPR-72
URL:
https://jira.jboss.org/jira/browse/EMBJOPR-72
Project: Embedded Jopr
Issue Type: Task
Reporter: Ondrej Žižka
Assignee: Ondrej Žižka
For QA, we use XPath.
Some HTML constructs are XPath - unfriendly, like mixed content on various places where
we need to work with the text.
Mixed content = element that has both text nodes and elements as children.
These changes should not affect functionality nor appearance of EmbJopr.
The changes would be like this one:
Old:
<h:column>
<b>#{
summaryMeasurementDefinitionMap[trait.measurementData.name].displayName}:</b>
#{ trait.measurementValueAndUnits}
</h:column>
New:
<h:column>
<strong>#{
summaryMeasurementDefinitionMap[trait.measurementData.name].displayName}:</strong>
<span>#{ trait.measurementValueAndUnits}</span>
</h:column>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira