Hi Steve,
thanks for the feedback. In doubt, I've released HCANN 5.0.1.Final
without that PR for now.
Thanks,
Sanne
On 23 November 2015 at 19:16, Steve Ebersole <steve(a)hibernate.org> wrote:
As far as the #7 PR, corry I personally have no idea. The problem is
all
the "other" consumers of HCANN I am always told about when I want to change
things in HCANN. I have no idea of the type of impact it might have on some
consumers I know nothing about. For ORM, we do essentially the same checks
in annotation binder as well, so I think that is a reasonable change in
HCANN for ORM's needs.
On Mon, Nov 23, 2015 at 6:16 AM Sanne Grinovero <sanne(a)hibernate.org> wrote:
>
> Hi all,
>
> I just sent a PR for a minor polishing patch to HCANN which seems
> pretty safe and yet scores a solid benefit in terms of performance.
> Considering how often we apply changes, I'd volunteer to release a
> 5.0.1.Final as soon as it's merged, as I assume no more changes will
> flow in for a while?
>
>
> There also is a long standing pull request which seems reasonable, but
> I'm less familiar with that area; could someone have a look at:
> -
https://github.com/hibernate/hibernate-commons-annotations/pull/7
>
> and let me know if that's safe enough to be included soonish as well?
>
> Thanks,
> Sanne
> _______________________________________________
> hibernate-dev mailing list
> hibernate-dev(a)lists.jboss.org
>
https://lists.jboss.org/mailman/listinfo/hibernate-dev